From: Peter Rosin <peda@axentia.se>
To: Lei YU <mine260309@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] docs: i2c: Fix return value of i2c_smbus_xxx functions
Date: Tue, 19 Nov 2019 10:24:00 +0000 [thread overview]
Message-ID: <c8aeb189-16da-0585-db6e-ec61a87eafba@axentia.se> (raw)
In-Reply-To: <CAARXrtmHh-7smvGi1_0J81zRfR9iiEG2+DJK2nDi_fThOKggmA@mail.gmail.com>
On 2019-11-19 10:43, Lei YU wrote:
> On Tue, Nov 19, 2019 at 5:33 PM Peter Rosin <peda@axentia.se> wrote:
>> And the line is now too long compared to the rest of the text, so you
>> need to rewrap the paragraph.
>
> In this patch it's at column 78, that should be OK.
No, that's not ok. If the rest
of the paragraph is wrapped at 72 (or something such), a single line
breaking that pattern will be
disturbing to the reader. The
fact that you don't get some
checkpatch warning has nothing
to do with that.
Cheers,
Peter
prev parent reply other threads:[~2019-11-19 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 8:56 Lei YU
2019-11-19 9:33 ` Peter Rosin
2019-11-19 9:35 ` Peter Rosin
2019-11-19 9:43 ` Lei YU
2019-11-19 10:24 ` Peter Rosin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8aeb189-16da-0585-db6e-ec61a87eafba@axentia.se \
--to=peda@axentia.se \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mine260309@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®