From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, johan@kernel.org, jirislaby@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, "Adam Ford" <aford173@gmail.com>,
"Tony Lindgren" <tony@atomide.com>,
tomi.valkeinen@ideasonboard.com,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
robh@kernel.org, hns@goldelico.com
Subject: Re: [RFC PATCH v2 1/3] gnss: Add AI2 protocol used by some TI combo chips.
Date: Mon, 29 Jan 2024 08:40:58 +0100 [thread overview]
Message-ID: <c8af1073-22ed-4c14-be85-67632d82a3fa@molgen.mpg.de> (raw)
In-Reply-To: <20240128173352.2714442-2-andreas@kemnade.info>
Dear Andreas,
Thank you for your patch. I think Linux Bluetooth patches need to be
have Bluetooth as the prefix for the commit message summary/title. Also,
it’d be great if you removed the dot/period at the end of the commit
message summary/title.
Am 28.01.24 um 18:33 schrieb Andreas Kemnade:
> Texas Instruments uses something called Air Independent Interface (AI2) for
> their WLAN/BT/GPS combo chips.
> No public documentation is available, but allow that protocol to be
> specified.
I’d add a blank line between paragraphs.
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/gnss/core.c | 1 +
> include/linux/gnss.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c
> index 48f2ee0f78c4d..cac9f45aec4b2 100644
> --- a/drivers/gnss/core.c
> +++ b/drivers/gnss/core.c
> @@ -335,6 +335,7 @@ static const char * const gnss_type_names[GNSS_TYPE_COUNT] = {
> [GNSS_TYPE_SIRF] = "SiRF",
> [GNSS_TYPE_UBX] = "UBX",
> [GNSS_TYPE_MTK] = "MTK",
> + [GNSS_TYPE_AI2] = "AI2",
> };
>
> static const char *gnss_type_name(const struct gnss_device *gdev)
> diff --git a/include/linux/gnss.h b/include/linux/gnss.h
> index 36968a0f33e8d..16b565dab83ea 100644
> --- a/include/linux/gnss.h
> +++ b/include/linux/gnss.h
> @@ -23,6 +23,7 @@ enum gnss_type {
> GNSS_TYPE_SIRF,
> GNSS_TYPE_UBX,
> GNSS_TYPE_MTK,
> + GNSS_TYPE_AI2,
>
> GNSS_TYPE_COUNT
> };
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
next prev parent reply other threads:[~2024-01-29 7:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 17:33 [RFC PATCH v2 0/3] bluetooth/gnss: GNSS support for TiWi chips Andreas Kemnade
2024-01-28 17:33 ` [RFC PATCH v2 1/3] gnss: Add AI2 protocol used by some TI combo chips Andreas Kemnade
2024-01-29 7:40 ` Paul Menzel [this message]
2024-01-29 20:34 ` Andreas Kemnade
2024-01-28 17:33 ` [RFC PATCH v2 2/3] bluetooth: ti-st: Add GNSS subdevice for TI Wilink chips Andreas Kemnade
2024-01-29 7:40 ` Paul Menzel
2024-01-28 17:33 ` [RFC PATCH v2 3/3] gnss: Add driver for AI2 protocol Andreas Kemnade
2024-01-29 7:53 ` Paul Menzel
2024-01-29 20:53 ` Andreas Kemnade
2024-02-25 22:16 ` Andreas Kemnade
2024-02-13 13:57 ` Adam Ford
2024-02-13 19:20 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8af1073-22ed-4c14-be85-67632d82a3fa@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=aford173@gmail.com \
--cc=andreas@kemnade.info \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=jirislaby@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=peter.ujfalusi@gmail.com \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®