From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: Hamza Mahfooz <hamza.mahfooz@amd.com>
Cc: "Stylon Wang" <stylon.wang@amd.com>,
"Ivan Lipski" <ivlipski@amd.com>, "Leo Li" <sunpeng.li@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Qingqing Zhuo" <Qingqing.Zhuo@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Alex Hung" <alex.hung@amd.com>,
"Michel Dänzer" <mdaenzer@redhat.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Hersen Wu" <hersenxs.wu@amd.com>,
amd-gfx@lists.freedesktop.org, "Daniel Vetter" <daniel@ffwll.ch>,
"Wayne Lin" <wayne.lin@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Srinivasan Shanmugam" <srinivasan.shanmugam@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor"
Date: Mon, 2 Oct 2023 16:19:56 +0200 [thread overview]
Message-ID: <c8b55d7c-e5e3-db83-3b3d-4db0ca636c7b@mailbox.org> (raw)
In-Reply-To: <39342931-1716-bf53-62d7-613b1191f60a@mailbox.org>
On 10/2/23 12:48, Michel Dänzer wrote:
> On 10/2/23 12:05, Michel Dänzer wrote:
>> On 9/29/23 22:41, Hamza Mahfooz wrote:
>>> From: Ivan Lipski <ivlipski@amd.com>
>>>
>>> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be.
>>>
>>> Since, it causes the following IGT tests to fail:
>>> kms_cursor_legacy@cursor-vs-flip.*
>>> kms_cursor_legacy@flip-vs-cursor.*
>>
>> Any information about how those tests fail? Maybe they accidentally rely on the broken behaviour?
>
> I was able to reproduce, that doesn't seem to be the case. They just rely on multiple legacy cursor ioctl calls being able to complete between consecutive flips, which I suppose is broken by always pulling in non-cursor plane state with any cursor plane state changes.
>
> I'll see if I can find a better solution. Meanwhile,
>
> Acked-by: Michel Dänzer <mdaenzer@redhat.com>
>
> for the revert.
Alternatively, here's an incremental fix:
https://patchwork.freedesktop.org/series/124527/
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
prev parent reply other threads:[~2023-10-02 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 20:41 Hamza Mahfooz
2023-10-02 10:05 ` Michel Dänzer
2023-10-02 10:48 ` Michel Dänzer
2023-10-02 14:19 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b55d7c-e5e3-db83-3b3d-4db0ca636c7b@mailbox.org \
--to=michel.daenzer@mailbox.org \
--cc=Qingqing.Zhuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamza.mahfooz@amd.com \
--cc=harry.wentland@amd.com \
--cc=hersenxs.wu@amd.com \
--cc=ivlipski@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdaenzer@redhat.com \
--cc=srinivasan.shanmugam@amd.com \
--cc=stylon.wang@amd.com \
--cc=sunpeng.li@amd.com \
--cc=wayne.lin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®