From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8360C14EC5C; Wed, 21 Aug 2024 16:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724258107; cv=none; b=s+L3YhLrdWU5m+OC91LiYXJf1KfzIRyqtnIcWbdUn9ShPG5k42hnFi8vlI1m1PGXZR9zIlxeLoXAWsrAarP5uQ16PpzUrMukQxr4wYPgGWQVvslV/0CPdYKF/zN3B2sbRBnFXXvsmtsRoTWWJ0v7Btn7dhLwiUeW72XjFLj4dFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724258107; c=relaxed/simple; bh=ad1bF+QoX7LfB7L18ZTC8ZXQ0Prmmw9IfCG18E2tuYQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=cbfb7565YlJPg6mBzvmzYWT6VRVsRgYij5xW1rbBSnAI2qvgOS9EIoWBUPzSKdnkUXz/p6LoLkTz9lsmVM9EWAbUzY5s+RrOpeQyKaEZ9e8hL/Yp6WbLAxP2GNDfC5x3Oewt4qwxJzx7ER7SCBZ8h7kUQF7IMGzR58oAV1WRjTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=fipWv643; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="fipWv643" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47LFZ7I9019748; Wed, 21 Aug 2024 16:34:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rcc0ZxWhHGUMUB4Hv0nltf1scT7ot8uWMC3hsil2LNA=; b=fipWv643/aI7xHDq JKTo2yBAvlETk1pX5sTw+v4BTP5wZOy2x7yKhoY43I6zEdblN9G7arEfmFFYYH7F VJ3+YBjGhkjyj1TrX06oxTwq7QMaoPJiyLwotfkGsNrY4ZT7UBEbEqkeDodtGoWG 3OmuU/ThzWJ09jDPNBUrkN/BJzbZ2saTTeJf3Zc6yrqlZy7qthnmJ91xSl18DQO8 QfGqQmSEBS2VLf3z9WPMPgRBpwmQJJTM0l/dtoYW6Z81aJqezqyBPJLLJmINWft+ Z3SDIjriA5pmY4HG5HcvciZzHq8Ysa2Csge/V7Tid32fLjHInbtpLAep+Kf0VCYO qpfgMw== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 415bkw9wf6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Aug 2024 16:34:56 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 47LGYtmN030180 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Aug 2024 16:34:55 GMT Received: from [10.216.59.247] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 21 Aug 2024 09:34:49 -0700 Message-ID: Date: Wed, 21 Aug 2024 22:04:46 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 01/16] dt-bindings: dma: qcom,bam: Add bam pipe lock Content-Language: en-US To: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , CC: , , References: <20240815085725.2740390-1-quic_mdalam@quicinc.com> <20240815085725.2740390-2-quic_mdalam@quicinc.com> <0a2b884b-bd28-428e-be12-8fef4fdfd278@kernel.org> From: Md Sadre Alam In-Reply-To: <0a2b884b-bd28-428e-be12-8fef4fdfd278@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: XWDAf-meecaWekiXSolcCXQUbK7qd4Fc X-Proofpoint-GUID: XWDAf-meecaWekiXSolcCXQUbK7qd4Fc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-21_11,2024-08-19_03,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408210121 On 8/17/2024 2:38 PM, Krzysztof Kozlowski wrote: > On 15/08/2024 10:57, Md Sadre Alam wrote: >> BAM having pipe locking mechanism. The Lock and Un-Lock bit >> should be set on CMD descriptor only. Upon encountering a >> descriptor with Lock bit set, the BAM will lock all other >> pipes not related to the current pipe group, and keep >> handling the current pipe only until it sees the Un-Lock >> set. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Ok , will update in next patch. > >> >> Signed-off-by: Md Sadre Alam >> --- >> >> Change in [v2] >> >> * Added initial support for dt-binding >> >> Change in [v1] >> >> * This patch was not included in [v1] >> >> Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> index 3ad0d9b1fbc5..91cc2942aa62 100644 >> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> @@ -77,6 +77,12 @@ properties: >> Indicates that the bam is powered up by a remote processor but must be >> initialized by the local processor. >> >> + qcom,bam_pipe_lock: > > Please follow DTS coding style. Ok > >> + type: boolean >> + description: >> + Indicates that the bam pipe needs locking or not based on client driver >> + sending the LOCK or UNLOK bit set on command descriptor. > > You described the desired Linux feature or behavior, not the actual > hardware. The bindings are about the latter, so instead you need to > rephrase the property and its description to match actual hardware > capabilities/features/configuration etc. Ok, will update in next patch. > >> + >> reg: >> maxItems: 1 >> >> @@ -92,6 +98,8 @@ anyOf: >> - qcom,powered-remotely >> - required: >> - qcom,controlled-remotely >> + - required: >> + - qcom,bam_pipe_lock > > Why is it here? What do you want to achieve? This property added to achieve locking/unlocking of BAM pipe groups for mutual exclusion of resources that can be used across multiple EE's > >> - required: >> - clocks >> - clock-names > > Best regards, > Krzysztof >