From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84FCCC4332F for ; Sun, 16 Oct 2022 09:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiJPJNa (ORCPT ); Sun, 16 Oct 2022 05:13:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbiJPJN1 (ORCPT ); Sun, 16 Oct 2022 05:13:27 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E273B46B; Sun, 16 Oct 2022 02:13:25 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id s30so12259797eds.1; Sun, 16 Oct 2022 02:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IW3EPR5jKO70Dh7Y08XV5EJBDFeZLamcX9yvxRHs2i4=; b=hsuSx3BEUM9P5v4aqIgnycixlvLI9eDqSh8IjP+sM9IyK6ymwgGnjh7rpaJO/v9zRo Mh3Z9JeUpEWSZ/UoIqm8Xgsrju1e7huxWqWFBZ1h8/swBZiJ4z9o+hs7CiVHAe/XWWu4 0xRsDUKffPhnpWCqJwUgPRVjbp8/J/O9h+afK6xO0nm57UE9QMLu0gXgXEDbS8SXt0qE DU93pzQ80P2oCxJiPZ+v4RMQqRnpR5O1/uG953H1vRvGkz7N9/3kxIYIcwQPC29RKd4J LApfzzmV3Sb6br91Hzqcjt43BTSWs5nTTyxBNrnMZ5HAVS5OMYKxAzRRxG9pytNDD3au j9vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IW3EPR5jKO70Dh7Y08XV5EJBDFeZLamcX9yvxRHs2i4=; b=uNdUnm9Fk/xwd41ayBVtZUVyBnvCJw+nDH4xT3An13c54eRNUH3BD+q55ofn0SgK8S kzvF7isV5Eu4WiPJsWvkLVXKh5DYqgGOJTMgxUjmML7g4A+nxSbFgtG7wmXDbGFC8ei7 QdKkoSt4/TSS/OOAGB/gMH9ottYuNr/xDip0q7hHJrDODlYmdEBmRFPz3n5CaN81fBG1 liXi7fuU/QZ+YP8J3Xjze3GM+lW6IGFUwBK7IUyqpk31DgNS5K63ptcBG3KzbN63Tc4U 6jHzRu5wzqAM4zrP+Ntm16jVJhIra55UDIZqUyMQUvZZw6zHWO8WsWK2jmFjvTL97H4d EHlg== X-Gm-Message-State: ACrzQf1OxGbYSshMYJBhUuIae42SeVLuGdBPhxNMIgrbJFhhien/C7bp WXr/eDQMqnIXoWgKPE8qmkY= X-Google-Smtp-Source: AMsMyM4+tZXRdieCgwmJXCZ6T/lHdCcwYAYpb4bmgHmw0RsNPyJ07FzlcUTrRXjfilxcwguaSSN7Sg== X-Received: by 2002:a05:6402:33c4:b0:448:e63e:4f40 with SMTP id a4-20020a05640233c400b00448e63e4f40mr5382804edc.203.1665911604399; Sun, 16 Oct 2022 02:13:24 -0700 (PDT) Received: from [192.168.0.100] (ip5f5abb9b.dynamic.kabel-deutschland.de. [95.90.187.155]) by smtp.gmail.com with ESMTPSA id b29-20020a170906729d00b00782ee6b34f2sm4288914ejl.183.2022.10.16.02.13.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Oct 2022 02:13:23 -0700 (PDT) Message-ID: Date: Sun, 16 Oct 2022 11:13:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 01/10] staging: r8188eu: fix led register settings To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, straube.linux@gmail.com References: <20221015151115.232095-1-martin@kaiser.cx> <20221015151115.232095-2-martin@kaiser.cx> Content-Language: en-US From: Michael Straube In-Reply-To: <20221015151115.232095-2-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15/22 17:11, Martin Kaiser wrote: > Using an InterTech DMG-02 dongle, the led remains on when the system goes > into standby mode. After wakeup, it's no longer possible to control the > led. > > It turned out that the register settings to enable or disable the led were > not correct. They worked for some dongles like the Edimax V2 but not for > others like the InterTech DMG-02. > > This patch fixes the register settings. Bit 3 in the led_cfg2 register > controls the led status, bit 5 must always be set to be able to control > the led, bit 6 has no influence on the led. Setting the mac_pinmux_cfg > register is not necessary. > > These settings were tested with Edimax V2 and InterTech DMG-02. > > Cc: stable@vger.kernel.org > Fixes: 8cd574e6af54 ("staging: r8188eu: introduce new hal dir for RTL8188eu driver") > Suggested-by: Michael Straube > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/core/rtw_led.c | 25 ++----------------------- > 1 file changed, 2 insertions(+), 23 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c > index 2527c252c3e9..5b214488571b 100644 > --- a/drivers/staging/r8188eu/core/rtw_led.c > +++ b/drivers/staging/r8188eu/core/rtw_led.c > @@ -31,40 +31,19 @@ static void ResetLedStatus(struct led_priv *pLed) > > static void SwLedOn(struct adapter *padapter, struct led_priv *pLed) > { > - u8 LedCfg; > - int res; > - > if (padapter->bDriverStopped) > return; > > - res = rtw_read8(padapter, REG_LEDCFG2, &LedCfg); > - if (res) > - return; > - > - rtw_write8(padapter, REG_LEDCFG2, (LedCfg & 0xf0) | BIT(5) | BIT(6)); /* SW control led0 on. */ > + rtw_write8(padapter, REG_LEDCFG2, BIT(5)); /* SW control led0 on. */ > pLed->bLedOn = true; > } > > static void SwLedOff(struct adapter *padapter, struct led_priv *pLed) > { > - u8 LedCfg; > - int res; > - > if (padapter->bDriverStopped) > goto exit; > > - res = rtw_read8(padapter, REG_LEDCFG2, &LedCfg);/* 0x4E */ > - if (res) > - goto exit; > - > - LedCfg &= 0x90; /* Set to software control. */ > - rtw_write8(padapter, REG_LEDCFG2, (LedCfg | BIT(3))); > - res = rtw_read8(padapter, REG_MAC_PINMUX_CFG, &LedCfg); > - if (res) > - goto exit; > - > - LedCfg &= 0xFE; > - rtw_write8(padapter, REG_MAC_PINMUX_CFG, LedCfg); > + rtw_write8(padapter, REG_LEDCFG2, BIT(5) | BIT(3)); > exit: > pLed->bLedOn = false; > } I tested this also with a TP-Link TL-WN725N now and it works fine. Tested-by: Michael Straube # InterTech DMG-02, TP-Link TL-WN725N