From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6038C565106 for ; Wed, 14 Oct 2026 17:16:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791998195; cv=none; b=IZzKGPOGlpkDcrnz3FnfgpZB0tVVxjKTDDKhpVi5/EGWDF4al1hfcqwJ/boqX8tc80dT+78X4fsBc5LR+olhHg23M6tc0WE/7GFJsRIYWZqlIf/GpjbaIP4yyv3ug/eUW2q7HYoIu4Q0DirfB8a7yV4FB5mijnqEZPy8nHnmnDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791998195; c=relaxed/simple; bh=NtivolCQ1nJosxUI9F7OWFpX9s9PxlP7yMWcyfGE/8U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ms9WdH1QQipHA9ducIiw3HofcagZq8BUhbCcm0yj9msRbXy/U07JXkR3GvOXvSrbop5xGloKp1Bb/kWlP8uv7Kg8FFlh7SLnJSb9HxKDvYqbQ8GezQuSZaOFZ452dNDFLEA0pi33wABW60sE+GCFJeUYcaAy/6/xvtWfK8dlRVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R26knpqw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qlb5Q3Xa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R26knpqw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qlb5Q3Xa" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69EEbUSQ3813218 for ; Wed, 14 Oct 2026 17:16:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7SbRzAQqOqMGFrGen933aIJTTXXFDtSgDohs9rQuHzc=; b=R26knpqw1ZB66+aI TqCgaSoGNuEN0u6AeVx+S3yB2Pexc+EhmlDjA0flx3pzmD+gKmQKYY/kMm0mqZmH aJNVMVVNqaJAcJv2TvH3qeg0GQixhbcaf0oBmUz9G6WNByRlHRPFrFtXhrx30FnQ vwafSFqHqMBodongiS1JL64lTb3vD9+07fenxT42P3Xn2+yM0itCNahcfR0dSGXh bUofyG0b6iH2btQzMobU5KFwm0PbWxcBPCiapTU74jn4238vbI8gQrn5FdxLs1dS upbL8QQYpg2L7grtH+epf4ghq9FHkAGS2DUN4VggHvTbnwEIDFk1JYQUxsSbVz7R wzMv+w== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ha46u2qs0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Oct 2026 17:16:31 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-17dc865c94cso619572c88.1 for ; Wed, 14 Oct 2026 10:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791998191; x=1792602991; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7SbRzAQqOqMGFrGen933aIJTTXXFDtSgDohs9rQuHzc=; b=Qlb5Q3Xa8/DWZwcNLMBTqOasnqolO5ZKIWnVRJeqPbCZfagqniVhMCrPEM6jToguVa qR+QOtrit8r68N1cd9jQhrk8ZDa/+/UBVm2Vr8s7VaHEJ1kGDgWo/4y3PZtM6/Q8o/t9 l7npmkiXPY7xec3H2NH3NIrtPc1lechC6hDaC4avUn47KtBpqK2O6qQIvIsyW7lF/bXE 2de0tupBQD9sA6Ek+smGV9MxY+iM9l3ttiUQ45cJKop/p9ln9b0yqBGIXpMY3pOiniNC YbVhQevIgc3zil8tTCP08o9rJRSLC22cwRt4tpr/wD28YQwkQdqFFc0sk4Uf1fMCFe4d o5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791998191; x=1792602991; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7SbRzAQqOqMGFrGen933aIJTTXXFDtSgDohs9rQuHzc=; b=PRKVzYNhc4NBmZIGkw0cSykp9oGA/qpNYqs4Jd1MathufssApz4/iDKqP3pu+5JN/5 Fm0fX8lxx6FicHmmBubNkCkTvDgo3nNr2basXekDRaxpGILiYyQUWwl/vmLTcL6lDujd i9TauSDJ4t1PrStepJBiWbHO7csTpmJEd7BIOeCdvazPplP6GdCyNMiqOulGdF9q/xhH ggTjZ+W5AbH83itKsIslpHKw92oPkv3jK43XWhZYNSlxSHJz+skMyXNUoiDJ+N8ve5UD t5htVDDW7qGgIP7ZA6G4HbZEAZxEHSJ2iu22MzaTWoSVvJsQNyDchw2feWjXGPILLH+i tGlw== X-Forwarded-Encrypted: i=1; AKwUvBwJx0cZv9sP0jwNYbIm0XXTf8rWM/XSp24tOZNHL+pr3Yvf5wNmoa7uLfSzfgnoEjXSaGqOAQnT9rq+ZDw=@vger.kernel.org X-Gm-Message-State: AFq9FYKce0Ss3b8l+r4iWIw5c2Hr/6NsCY8GSNxvARdrbZ8TWKCg0CKG LGbmOeLTOZ5wejMQcM9Svc283WhnF86v/moeZrc5gUwTH7UKW4ZCgj+lh5jK2Xz7pXQ/vJhwOMS h77jppmKuDAcfw6dkd+7NV4zCzk/PFbHquLciLsx/amfH83dRwA6wiEoPT7VSYgAtna8= X-Gm-Gg: AYBFou0exy5aigKX79nT2yQPfcEML7qSMqns72otBsu98Mn1HVX8GFyHsNF40g0vIdM 4IxxNK9iOelqGqwyOvfNvSM5nLZcxpF0LUZeQ0MyFUXwIuvalta/ZhE9LQRXGBbwZc2wKXaDQXX KL9WprdLLEUtS6n5UeA71Y9FtD7hz6HnvZn5B65yEAb4PCeTE+uhCqraKbWPoo54xhlBY/q9LB7 k7nbe+ozLFNiT27/8mphrNwoLfiDF4+eDHvtv87b1ZYwQfGmrkInK1B4hIqde3QLBWgr9T15I0q wCI4CyxrTSNtwb2kkvaLu2gkek2hl7B1H96hGcjA0ZecgoypZ7Hx8esMILgKyHShjsnpW6WpFWz R2pB59n6x26bPVdK8N8DmxAG1gOiVkyHQiPaTcHY= X-Received: by 2002:a05:7022:b9c:b0:144:fb42:52 with SMTP id a92af1059eb24-16a61d5bd24mr35223592c88.28.1791998190430; Wed, 14 Oct 2026 10:16:30 -0700 (PDT) X-Received: by 2002:a05:7022:b9c:b0:144:fb42:52 with SMTP id a92af1059eb24-16a61d5bd24mr35223517c88.28.1791998189644; Wed, 14 Oct 2026 10:16:29 -0700 (PDT) Received: from [192.168.1.5] ([223.230.101.206]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-17dc865cbffsm11282540c88.6.2026.10.14.10.16.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 10:16:29 -0700 (PDT) Message-ID: Date: Wed, 14 Oct 2026 22:46:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/7] ASoC: dt-bindings: ti,pcm1681: Document the optional SCK clock To: Krzysztof Kozlowski Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Shawn Guo , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20261009-nord-asoc-driver-support-v3-v3-0-0c1897f21ccf@oss.qualcomm.com> <20261009-nord-asoc-driver-support-v3-v3-1-0c1897f21ccf@oss.qualcomm.com> <20261013-supportive-imported-spider-c6e28d@quoll> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <20261013-supportive-imported-spider-c6e28d@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE0MDA2OCBTYWx0ZWRfX/S0F8jLEenRv 1iFaneKbv88U2FSkuEPP1CxoxPbo6cdAe5h78YTPKyS4tRn569AHHMraRIPaT0gz5j5SJA8U0YV w14y/Ro1+Fu5VHXGHO+YcJHxVIcBFWc= X-Proofpoint-GUID: sL7VEI5qJKcsrsjgM0_DzFMHKGt3ZnuF X-Authority-Analysis: v=2.4 cv=Y6ttIReN c=1 sm=1 tr=0 ts=6acfb8ef cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=89gBhgtN2V0NwPD6rb2Hew==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=UYrAC0ybtJ6TP4zHPckA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE0MDA2OCBTYWx0ZWRfX3nXUxaLgiyzq U1ZnlzJoGjdUujOFAY+Tp+YIxqmh/yaIgSfScztyP28djHW16T3E4vqYrvKQIrAK1sCyizypyH/ v0leJWfNdd/gv37Jac4u3K3yA9l8t1pdFnSC1sPxroAnKEHg2vMbukaoREqghuc5RTHeoGvh5wb 3r0Z+B1i3K13fHEXSfU4oNa8HK5+cJd29eQlf/PrIOsvQVaH1ZSpnJQ/PTeeVr6DV1ah5SfELPT /Ou/79u1ifeKRTflihHjKCtXGoHcvNRwFqRNDpPDg1aRUQNmG687CPT91Lanv55VcofxTYMXvte t2w1yDiCUICrYqa8XadgB5Q++6gehplTb6S6zvnD7y4fmHUJ3Oz3b060rIOahQ9sS8uIHx8IlH1 LS2pDZvTiCy8LaGn4vQpocD+Lg9q7EUVkOkx9BcNEi4nKXSuXEF2NnjSaXYfMV+x/4xqCGtGrZR supRAYYkvXRLflndQcA== X-Proofpoint-ORIG-GUID: sL7VEI5qJKcsrsjgM0_DzFMHKGt3ZnuF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 suspectscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610140068 On 10/13/2026 12:31 PM, Krzysztof Kozlowski wrote: > On Fri, Oct 09, 2026 at 06:42:47PM +0530, Mohammad Rafi Shaik wrote: >> The PCM1681 can use an external system clock supplied on the SCK input >> pin. Platforms that provide this clock need a way to describe the clock >> connection in Device Tree. >> >> Document the optional 'clocks' and 'clock-names' properties and define >> the clock name as "sck" to represent the external system clock source. >> >> This allows boards using an externally supplied SCK clock to accurately >> describe the hardware configuration. >> >> Reviewed-by: Shawn Guo >> Signed-off-by: Mohammad Rafi Shaik >> --- >> Documentation/devicetree/bindings/sound/ti,pcm1681.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml >> index 1f0e6787a..1b3803518 100644 >> --- a/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml >> +++ b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml >> @@ -21,6 +21,13 @@ properties: >> reg: >> maxItems: 1 >> >> + clocks: >> + maxItems: 1 >> + description: System clock (SCK) >> + >> + clock-names: >> + const: sck > > Drop the names. If they are needed for any reason, then use the same > name other device uses already, so scki. Ack, Yes, the clock name is required as it represents the system clock. I’ll use scki, consistent with the other implementations. Best Regards, Rafi. > > Best regards, > Krzysztof >