From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92C837F732 for ; Mon, 6 Jul 2026 15:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783350052; cv=none; b=jufHlfdJSHEnCLqwm9dzyJYE5CHlrdRHd6SBy64B7d+diJYdl/+XySWtNwRc6mp04ywrZ8HGsQ0/CuTAkHXmfBUPxOHDcrP8zfYDUP4vzVlGtVzB0gmr0bXz0K5MR7YNzPRkRgLVTVSD+mzifCWRW+3c67n5lsqzKAh3OfLpxcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783350052; c=relaxed/simple; bh=JcmRqCG0MWijOutzaquv4FjszCnulc7vhMUEe5kuxXE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=EcfY3xAenQ5feKgxZUNi4TCjfwXmUo4L1X5Yo7U8W9A+McVTJ7gG2WSsXtr8xMaRVQCW/2iu/po1sS5iZjbRZj8zqhixEjnGLmSoZepQknv44oPqn+UuckYFqS70cZ/Y2V/TLhu6rKeSrryQkuXx6Z7OvSorKuO0VkByxTQ91EU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b+cWUwqN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IBdV/4HW; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b+cWUwqN"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IBdV/4HW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783350050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XWPAPea/4nYf8fBZI2bdCug+P82JPz4RYQoXBwMUFNk=; b=b+cWUwqNPCYWM6Min9hjxfHqpbwL6Q9KqnpueKY25lSv0NIt9C0NhqyYZgoo9jRten8M60 PmO2/etrC6vzWmiAENJoTfT5EdKGsLrX7DlNsPq7lVVkP9Nc3JJScOleZCkGjI9xppdWk8 fO/34IwjLt39xpe+YESyDtLM8UpYUnQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-bA0NUd7POlKjbIouNk_gYw-1; Mon, 06 Jul 2026 11:00:48 -0400 X-MC-Unique: bA0NUd7POlKjbIouNk_gYw-1 X-Mimecast-MFC-AGG-ID: bA0NUd7POlKjbIouNk_gYw_1783350047 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-493c1bc7a70so28874385e9.1 for ; Mon, 06 Jul 2026 08:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783350047; x=1783954847; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=XWPAPea/4nYf8fBZI2bdCug+P82JPz4RYQoXBwMUFNk=; b=IBdV/4HWF7S3eXlZT8LhlWZdfCQejPRqwzxYs5aoTUlQCL7WEDmMDo+2PiHKKL2R4N Y1PDHuWSf9ar393vbsB/k+EA+e08ZKiXMDAkDTl4aYEtaXqoB7ijZiqBPQI1oYakmW+C qBvo1Cw7gDd2YwuE9Ur/oQoFP51jEVB7B4cvINWT3bAHiCYsEMtqNxOGD1sFDGJk9Zo2 FR/ZICsDNH4R5+0X9osQQjirhJGgOHFcX6EXbS17nXciecgoOQnn/y48MZGhXSMwOBL/ R+x/0TujOko6VRMDiUQ067ZxIF9vioxEneHYQDTY64ZO4CRZLA7qrYiFn/dokiiKQQME Q7JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783350047; x=1783954847; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XWPAPea/4nYf8fBZI2bdCug+P82JPz4RYQoXBwMUFNk=; b=hkxpf+nQlIvoi7m9kEKdZFiskqhgDGXLVYBXEd/zQeVFj2iQXSla4RX8DzZswnEB6j o9fXI67svFc6SA9z5I++UhE1KNwM4VTru7rYshJTMMzDpe6/sNWTKbLXIO1hl9chDTZ9 mJ5uC0Uyu0YxSA8ShGmKG44BVolTnhy0LnHI+9w4rRWlzeC9QdbpvmBmzOC0pilwAXaV A47QB/ujwpPGOfrP83Og06fECmZRyE9c95nukvxkRgVXBL07ibklKuq95d+nuBGy6m7u V31v0IIvX2djP064lvc0/A6VJ7gFT+xjAqkqN6DBiREbrHsv14u0i9CDThB7EjUs8ws9 E0Yg== X-Forwarded-Encrypted: i=1; AHgh+Rq4QoAUB5UE9WpEPC0/+oU7lucOvUPsZ3ZQtaRSY7zcyXknAFNdVq6JMRJy4lwbillTneafRlvZlndNtHM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4QTflHimBm8E/vgNyKyixaf+rL6mdU7XbscYZ0SF6Rsk0Tqq/ 8CQv4CB9nlvNC9M8ztaiS3Ng3d1EHYtZM4ASSH256MshUj2d/FJLVMauqAa3kTCZJQd6I5X2Tqc EMJUgOcOlvY9XrIQFrIqQP6/qICxWYfrPwikjlTyW4kI5kastW3sgoQJYPql44aeKjDG/Qz5In2 s5 X-Gm-Gg: AfdE7cmpFbqwN47mADhEpuxqLzDwcuOsF1qhZe/831lDAE3tMdmtjUl/94ZopGQR+bc zPycGD66EyOPDGyRd0gkspL0Xp9ZgtKidE/FPhpLtCEjyzeI6DIx3xFsTYzsSyLEvpsxroy+k5O Lxzx0zgYQZo0dJLUkOTqaVVX36Qvsitsg47bXL4wEVGaJp+3xE1+ZuxL0kkBCOq8gmvMRPd4R6/ UbgobxO0fg/3+9r/jgfHFJfn5gTWJoLmkBS0/kTSYtCoyxVw2FEX/GBlzH1gk80G44eGXR6bR49 Imwb+Oi0LrMxBlWs3AbK+pfZ0NZ3jTBE3uXV3NGIv/ISB8SW1G0xmIddWkN2l+NODMCEQ5pOEpB IxfTnTVNZcXAQsm/s1ZoswOmKPPvyeKdqtyVZbe3aUfbNrA5cTotLyim3ltj0EPzG5pww3wShLH ZA30XM X-Received: by 2002:a05:600c:848d:b0:493:adc3:cced with SMTP id 5b1f17b1804b1-493df0b4e28mr10439565e9.34.1783350047267; Mon, 06 Jul 2026 08:00:47 -0700 (PDT) X-Received: by 2002:a05:600c:848d:b0:493:adc3:cced with SMTP id 5b1f17b1804b1-493df0b4e28mr10439015e9.34.1783350046859; Mon, 06 Jul 2026 08:00:46 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63172fesm641026435e9.0.2026.07.06.08.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 08:00:46 -0700 (PDT) Message-ID: Subject: Re: [PATCH 3/3] rv/reactors: add KUnit tests for reactor_panic From: Gabriele Monaco To: wen.yang@linux.dev Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 06 Jul 2026 17:00:44 +0200 In-Reply-To: <810f587d63c84b64067f990299be02b88f5d8106.1781541556.git.wen.yang@linux.dev> References: <810f587d63c84b64067f990299be02b88f5d8106.1781541556.git.wen.yang@linux.dev> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-06-16 at 00:44 +0800, wen.yang@linux.dev wrote: > +/* > + * Test 2: panic notifier chain is reachable. > + * > + * vpanic() calls atomic_notifier_call_chain(&panic_notifier_list, ...). > + * Drive the chain directly to verify panic notifiers receive the > notification =E2=80=94 > + * the observable side-effect of reactor_panic without halting the syste= m. > + */ > +static void test_panic_notifier_called(struct kunit *test) > +{ > + atomic_notifier_chain_register(&panic_notifier_list, &mock_panic_nb); > + atomic_notifier_call_chain(&panic_notifier_list, 0, > + =C2=A0=C2=A0 "panic violation message"); > + atomic_notifier_chain_unregister(&panic_notifier_list, > &mock_panic_nb); I just realised this isn't even testing the reactor, it's testing the notifier_chain thing, I don't think we really need this here or am I missin= g something? Thanks, Gabriele > + > + KUNIT_EXPECT_TRUE(test, panic_test_state.notifier_called); > +} > + > +static struct kunit_case reactor_panic_kunit_cases[] =3D { > + KUNIT_CASE(test_panic_register_unregister), > + KUNIT_CASE(test_panic_notifier_called), > + {} > +}; > + > +static struct kunit_suite reactor_panic_kunit_suite =3D { > + .name =3D "rv_reactor_panic", > + .init =3D reactor_panic_kunit_init, > + .test_cases =3D reactor_panic_kunit_cases, > +}; > + > +kunit_test_suite(reactor_panic_kunit_suite); > + > +MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("KUnit tests for reactor_panic");