From: Javier Martinez Canillas <javierm@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-kernel@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
LUU HOAI <hoai.luu.ub@renesas.com>,
dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Subject: Re: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI
Date: Thu, 3 Nov 2022 19:31:05 +0100 [thread overview]
Message-ID: <c8c7baad-e8ce-7683-933a-1d5f98f9c843@redhat.com> (raw)
In-Reply-To: <f5a46aef-780e-6fec-85b4-82549fb7a7a1@infradead.org>
On 11/3/22 17:26, Randy Dunlap wrote:
[...]
>>
>> Randy, I think that it's more idiomatic though to it express as following:
>>
>> depends on DRM_RCAR_MIPI_DSI || !DRM_RCAR_MIPI_DSI
>
> I count just over 200 of each idiom (but my grep strings could be
> too crude). I guess that you want a v2 with that change?
>
I believe Kieran was happy with either so no objections from
me. I don't have a strong opinion, I just thought the latter
was more idiomatic but you said that both are used alike.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2022-11-03 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 18:18 Randy Dunlap
2022-11-03 6:06 ` Randy Dunlap
2022-11-03 10:59 ` Kieran Bingham
2022-11-03 11:53 ` Javier Martinez Canillas
2022-11-03 11:56 ` Javier Martinez Canillas
2022-11-03 11:59 ` Kieran Bingham
2022-11-03 16:26 ` Randy Dunlap
2022-11-03 18:31 ` Javier Martinez Canillas [this message]
2022-11-09 14:11 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8c7baad-e8ce-7683-933a-1d5f98f9c843@redhat.com \
--to=javierm@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoai.luu.ub@renesas.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®