From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 222D8421A0E for ; Tue, 7 Jul 2026 13:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783432034; cv=none; b=liThIUjaxxbu2ggVCPy5UqNmmrNXhyODaUUc3lc+4x0CPmZ45T9t/1fzqry7rE6KNAy1NBlIBUhVs4Y4+T3ojy7J4mIQmk44usSL2PALXdW6726G2qsItGm/8MjxipYuYf5OuMvFWk8SA24F4mA51Tfe7JJMJl0z3qBkmz19wFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783432034; c=relaxed/simple; bh=bENWIoUDmb+p3ApVBhAj+ipAHOlaLeCOdg1Ywad5Xuc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ruDs+bqPAVE4d+ikGoBE9lo2XqqAdPWIeUkgmTGl/QQOUQ8OaQQXxRmH98XeH748SXVgBVABerfoDUPoUN3IRY3jl+42sT7Zzl1tppOnHXLs7LfkAqArW9en5C9kRJA7xHLZ3GLv7VIyjQ0yZrG8PvWmMdgPLdhUxShbLaT8ccs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N/BS5pSA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jBBTVAAl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N/BS5pSA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jBBTVAAl" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C8Vt13741880 for ; Tue, 7 Jul 2026 13:47:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PyqAei8u+t7l/e/rvtU8ZVllDYwd5+yugM7bTcE/irY=; b=N/BS5pSAK22IBIPR C7q8d4MPC6CupunpWede6AWAyvgf3jJfvxsuLdOoqZuhTw7ITo0iveWUP7L5U0S2 TMQ3sTEwFtG+Tt7oNXCKnhszvPMY8orddr/sMLvSCrCC5cvbVMihZJSBJD/NhaPM px1VLvSP36vpimk3cG9J5y57XFI7WDeCm6DFS29gURmNw1Gm6izCYFQdBVDbNyCm vX5i497hU+zCAzIKG9HGuU6oKc9YoFBptFDU3cATN81vhOJUjv1J0gDSa8rDfI0t k94NwFNi2Pw1CRJ7y6EjFbnNvAIHNBcL8xIIUcV/Km3bRJ8zIzn/orwX1/wfuyy4 33sV8w== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8ye0gtw1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 13:47:12 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1a9764f0so55369151cf.1 for ; Tue, 07 Jul 2026 06:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783432031; x=1784036831; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PyqAei8u+t7l/e/rvtU8ZVllDYwd5+yugM7bTcE/irY=; b=jBBTVAAljrtlwIbIJ6RRbiv0cxugWIQFllytqMrCLAMK+1E+ZcX1CJcD3NFtcGqK9f Ak8sPimeZUTVynGxGU6PMhWU4uBZP1qXI66aRFlA10T8vJKJdLlb9IuM9djQZ3YOFqKd hAJDuDXHCzwO7Z3yTIrfqSEw/RMZ/ZSWRjwkuzLMsksQ7nIcu/YxC+f2TEWQI17vlw0b 1bHJfqrGqik9BW5Dcwb/PwkDiTnLqd3Fn4TiOvIKsph4Xof8Cel5qiFVY9sPNeBeJpCE D/8ee6C70qEZp4/ooXl83Pt86KS+LLU1RepGN9bw1LBAO5tKMfDdOSl1DaBe5e8Nw+Ti QUAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783432031; x=1784036831; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PyqAei8u+t7l/e/rvtU8ZVllDYwd5+yugM7bTcE/irY=; b=W3dhQCVsSSNVL0MM37LU+zCATJmyesBjwM987TPasQOoxRFyKUSiEjy7LRGhw6fuqi 8xAYY5eEfkEKgRBdi8E/kVomKwsNpNL0qN9rITUwD8TNHDFqNPfZSb5n7lZNYpVBU2lj 1jqsuQpPE/nDAXYrNzr8mDuA76Cmqq0DtjsXwLXwbaDY2L4bVlr+/MeEMsFO99QBCm14 mqvbsgEcYoGIkI8beDNnieOFLjfCGXaR+WYbEUwRGlBmQly0SeleyUHd7n+du7Lb4pLk KOuwezypBTZ85PWzy4ZFjZOujBsoIGuIHfqYCo61XMDt3NzyjE6KzDgX5tPKN8auqrYc /MRQ== X-Forwarded-Encrypted: i=1; AHgh+RqcGxDJ4ys3I6aFoLqgwF+qGBzUyr5umN4rG+ljTe2UvDMTN0xpOAVsXZ/09Ui/tiJ77/WfFhd0Kc2dAuU=@vger.kernel.org X-Gm-Message-State: AOJu0YyflbBSL42NAUsfyLUYHxKQDPotqNhos0H/vLwcGYWf+q0FsDgi ZkyQel+8LUNy8rPeR4QXX8cjszC7eKB4ycbqV/hKsgYuYT/3AHcEIoXdQEb865KxkfVPdkoIWis lGgKmoj5SL4ujSg5PksZaMKUOqGm5rtFpEIhEwrpEenqvP6GY/egNPV0sUmDEJi8CX38= X-Gm-Gg: AfdE7ckkyWBt1IGEkhvoEzeS7du8FAAwqjaEJmvbwsgn89oQ8yVSTwnCnT2TmZaBpn4 dCAXCkL3CEP+x2Di3AnF288LN+K5yDCq6v4RWXmmWQa6KANHqsbThyhAqye6WkoycQCk0X4PWOF 1JbfEPIhFUXhzJuHle+2UlVn5mfam5SdAqbw9KDZPGlai1W5w1uzDQNXfa8+fuypdb4zLvJrf5V Pjw3ArUTsGC/235zZdeAJPOe5UkKx3PNcf2j587J+4JD41VPBr0VdbY+RLH4zpUqywBrq4hdEMs VKfCVD19e/F5qj+x8JmekzSvL+aCfj2ssq7vAaORTvBGHMp4A8q+JvT1JFJ88hAhOmUchmPzhFe QVrvb7xbV3b0XiTeAlnMIhjqskWMJcE4Wct9kNmjypSgPe1XJ6LT1scg/FtE8qNuXwE/3IUp1z1 rD2iewdb0= X-Received: by 2002:a05:622a:2516:b0:51c:c37:df31 with SMTP id d75a77b69052e-51c747780eemr58798701cf.7.1783432031386; Tue, 07 Jul 2026 06:47:11 -0700 (PDT) X-Received: by 2002:a05:622a:2516:b0:51c:c37:df31 with SMTP id d75a77b69052e-51c747780eemr58798071cf.7.1783432030794; Tue, 07 Jul 2026 06:47:10 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19daafe2sm5659651a12.25.2026.07.07.06.47.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 06:47:09 -0700 (PDT) Message-ID: Date: Tue, 7 Jul 2026 16:47:07 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder To: Dmitry Baryshkov Cc: Vladimir Zapolskiy , Atanas Filipov , linux-media@vger.kernel.org, bryan.odonoghue@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <20260706071113.383215-6-atanas.filipov@oss.qualcomm.com> <51a0abf2-2a72-4551-894b-2c2de91ba0c2@linaro.org> <74a5b549-987c-4dac-a1a0-ff81150cd6ab@oss.qualcomm.com> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 6duWMtmJMieNXgd2F1csaCesbLpBh4nj X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDEzMyBTYWx0ZWRfXxCbSqSB9upXy uZwpqT9dpkUPM14i2hATb0w3//JZFI5+sqborWu1sQqhvCyu3+n9F4LWiuKVwM+n1cmbjsoXvHj K3VsrkKiyogyV7RZMDb06tPy4e1Z+4Q= X-Authority-Analysis: v=2.4 cv=SZfHsPRu c=1 sm=1 tr=0 ts=6a4d0360 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=FYVyraQ01RCAgbHwNcEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: 6duWMtmJMieNXgd2F1csaCesbLpBh4nj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDEzMyBTYWx0ZWRfX+knMoUhKSnvC sVmjC/dN10G3YWCgitvUowAWl8MNyQ7ROND5wo6zVy5U0ZduUdR72EpDdmlfGULQ2Xj7N6BiqeD /2Ec/y0EfrMLUAJc3WJq5p4OI5wV6q02wkpB2fp7scFDWkgAnl6U0XLbYqQOInz5h7jaejYMQGf 8PFbkhmAVSIHf9lg7QWX9KG9PHGY76zD3EVQ0vNZd+c4A9Ex/5YaGUFrThoSllZZvx2b4qWELxE aDRG115WbxDk3K8Y28sfGTFoum55b3jy2bxt2FsHDPCrUhlpm2UPui/3STniec0PlEyGOmx4Zaz Y5Q9PAKW3pg+85VQ57gtC49JDqX1R9pa95a6qyPXMC/Ua6KWkPDFYqrxb5QcNt6SdJDG6LiCdaM 9o4mP7WBe6HNpNI2zlo86Vw70fhN5fMB+eBTkhUOXCsadfF382KdqcWQ+ExaOnOkOl3uXJlj/Gz AiHTKBY6ffiajX0reYw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070133 Hi Dmitry, On 7/7/2026 4:32 PM, Dmitry Baryshkov wrote: > On Tue, Jul 07, 2026 at 04:24:19PM +0300, Gjorgji Rosikopulos (Consultant) wrote: >> Hi Vlad, >> >> On 7/6/2026 10:46 AM, Vladimir Zapolskiy wrote: >> >>>> >>>> +            interconnects = <&gem_noc MASTER_AMPSS_M0 >>>> QCOM_ICC_TAG_ACTIVE_ONLY >>>> +                             &config_noc SLAVE_CAMERA_CFG >>>> QCOM_ICC_TAG_ACTIVE_ONLY>, >>>> +                            <&mmss_noc MASTER_CAMNOC_HF >>>> QCOM_ICC_TAG_ALWAYS >>>> +                             &mc_virt SLAVE_EBI_CH0 >>>> QCOM_ICC_TAG_ALWAYS>, >>>> +                            <&mmss_noc MASTER_CAMNOC_SF >>>> QCOM_ICC_TAG_ALWAYS >>>> +                             &mc_virt SLAVE_EBI_CH0 >>>> QCOM_ICC_TAG_ALWAYS>; >>>> +            interconnect-names = "cpu-cfg", >>>> +                                 "hf-mnoc", >>>> +                                 "sf-mnoc"; >>> >>> This is the topic, which may raise a disagreement, but I'll repeat my >>> position about the need to remove all "CAMSS bus" specific resources from >>> the device node, they are found and should be allocated on parent's side. >> >> The interconnect has functionality to handle bw requests from different >> clients. >> >> Yes the best will be to have camss interconnect, so jpeg and other hw's to >> vote >> >> on that (actually it is possible in icc framework) but what is the benefit >> of moving >> >> those to camss? Is it not better to create camss icc. I understand > > Please fix your email client and stop inserting extra empty lines. Apologies for that. Some Thunderbird settings were missing on my side, i hope now is fine...> >> >> you want them to be on parent side. But how to vote on bw? Most of the time >> it > > If the driver actually votes on those, I think, it should be fine. This > patchset seemed to add bandwidth voting, but then it dropped all the > votes in the last commit. > >> >> depends on the jpeg encoder configuration based on resolution format etc. to >> set properly average bw. >> >> So i dont see how that can be done with not explicit dependency on jpeg with >> camss and some exported >> >> API's which we discussed with Bryan they are preferable. > > Interconnects should be fine to be referenced here. Especially, if JPEG > has its own port to those busses (hint, commit message). > > As I wrote, I see a bigger issue with the clocks. You need to have some > API to vote on them (and then let camss driver aggregate those votes in > a platform-specific manner). Can we use icc-clk framework to vote on them. I think even today there may be some issues in camss for the clock voting. Regards, ~Gjorgji