From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934020AbdJQL7x (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 07:59:53 -0400
Received: from smtp2.infineon.com ([217.10.52.18]:21662 "EHLO
        smtp2.infineon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932959AbdJQL7v (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 07:59:51 -0400
X-Greylist: delayed 583 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 Oct 2017 07:59:50 EDT
X-SBRS: None
From: <Alexander.Steffen@infineon.com>
To: <andriy.shevchenko@linux.intel.com>, <elfring@users.sourceforge.net>,
        <linux-integrity@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
        <benh@kernel.crashing.org>, <clabbe.montjoie@gmail.com>,
        <jarkko.sakkinen@linux.intel.com>, <jgunthorpe@obsidianresearch.com>,
        <jsnitsel@redhat.com>, <kgold@linux.vnet.ibm.com>,
        <mpe@ellerman.id.au>, <nayna@linux.vnet.ibm.com>, <paulus@samba.org>,
        <PeterHuewe@gmx.de>, <stefanb@linux.vnet.ibm.com>
CC: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH 3/4] char/tpm: Improve a size determination in nine
 functions
Thread-Topic: [PATCH 3/4] char/tpm: Improve a size determination in nine
 functions
Thread-Index: AQHTRqUDkaozMKlkKUKzGLQaIH+3kaLnwC4AgAArvfA=
Date: Tue, 17 Oct 2017 11:50:05 +0000
Message-ID: <c8d37c0407a949c1abb35cfd79c17f58@infineon.com>
References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net>
         <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net>
 <1508238182.16112.475.camel@linux.intel.com>
In-Reply-To: <1508238182.16112.475.camel@linux.intel.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.23.8.247]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v9HBxvj0015979

> > Replace the specification of data structures by pointer dereferences
> > as the parameter for the operator "sizeof" to make the corresponding
> > size
> > determination a bit safer according to the Linux coding style
> > convention.
> 
> 
> This patch does one style in favor of the other.

I actually prefer that style, so I'd welcome this change :)

> At the end it's Jarkko's call, though I would NAK this as I think some
> one already told this to you for some other similar patch(es).
> 
> 
> I even would suggest to stop doing this noisy stuff, which keeps people
> busy for nothing.

Cleaning up old code is also worth something, even if does not change one bit in the assembly output in the end...

Alexander