Re: [PATCH 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

[Hans Verkuil <hansverk@cisco.com>]

On 06/13/17 12:06, Jose Abreu wrote:
> Hi Hans,
> 
> 
> On 13-06-2017 11:01, Jose Abreu wrote:
> 
> [snip]
>> Changes from RFC:
>> 	- Added support for HDCP 1.4
> 
> [snip]
>> +
>> +/* HDCP 1.4 */
>> +#define DW_HDMI_HDCP14_BKSV_SIZE	2
>> +#define DW_HDMI_HDCP14_KEYS_SIZE	(2 * 40)
>> +
>> +struct dw_hdmi_hdcp14_key {
>> +	u32 seed;
>> +	u32 bksv[DW_HDMI_HDCP14_BKSV_SIZE];
>> +	u32 keys[DW_HDMI_HDCP14_KEYS_SIZE];
>> +	bool keys_valid;
>> +};
>> +
>> +struct dw_hdmi_rx_pdata {
>> +	/* Controller configuration */
>> +	unsigned int iref_clk; /* MHz */
>> +	struct dw_hdmi_hdcp14_key hdcp14_keys;
>> +	/* 5V sense interface */
>> +	bool (*dw_5v_status)(void __iomem *regs, int input);
>> +	void (*dw_5v_clear)(void __iomem *regs);
>> +	void __iomem *dw_5v_arg;
>> +	/* Zcal interface */
>> +	void (*dw_zcal_reset)(void __iomem *regs);
>> +	bool (*dw_zcal_done)(void __iomem *regs);
>> +	void __iomem *dw_zcal_arg;
>> +};
>> +
>> +#endif /* __DW_HDMI_RX_PDATA_H__ */
> 
> I now have support for HDCP 1.4 in this driver. Can you send me
> the patches about HDCP that you mentioned a while ago?

This is what I have:

https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=hdcp

This is very old and somewhat messy.

It uses ioctls for the bksv's, but I wonder if array/compound controls
wouldn't be more appropriate (those didn't exist when this was written
originally).

It also needs to be checked against HDCP 2 so it can support that as well
(or at least be easily extended for that).

Regards,

	Hans