From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AABFC21E08A for ; Fri, 20 Dec 2024 17:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734716035; cv=none; b=mE1G7c4E/jn/XMEAtNYsmBMd1mSBbZvdiCGyVFZu4g7AEHmKKl51d0rrodLzIMEZvH/duaGqyyZrlkc+Pz+WEtMQOpFT9rKSZ/gPJ8V3Hm6Tff8wq31aqexvDqJpJTckrmTe2RJjukzXS3NSJqsUs2WdfuMzEUb9ioiZaqiPK5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734716035; c=relaxed/simple; bh=EOSgJFqbNzZue8PcEmo8AOIhn9yrJuIFDZjAitrdngA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NQCdPuaA/KNslDWQVuApMroespHq3mKjpHaLlNY8paVxKTIaUvR1fxYCwLJG10MTmPoq0fe8jON95GjHQ9p4+RK5tVioPXeY4g2Bdg41tz2aOtwYO3nsNwG45gl0BCHcT4rIq+ZhFTVDggys6oDVm9aiDPhU+Qvs2QjFTmbf7oA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SC/wT12U; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SC/wT12U" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-844dfe4b136so74420939f.3 for ; Fri, 20 Dec 2024 09:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1734716033; x=1735320833; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m3lDWXYieWaSwhCuCMEtUeqlkkHZALzZ6qVm2AYz5YE=; b=SC/wT12Uf2ED7mrE5a/zeZQ2TDmilhHWP09B7xOyT9a1pr/q+ehgg6UeVcfbJIISGn s/PCLkoZapjuYJKXUvS/HFTWabKwLbLHO6eX2gg/94WGkNn5RwENM0nG1NisuoWkWQ72 F5e1hOl+5X/8lJtw7GSRm56Z0YWaxm48PMmeo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734716033; x=1735320833; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m3lDWXYieWaSwhCuCMEtUeqlkkHZALzZ6qVm2AYz5YE=; b=uhbIArx+ROKRKig/5xD+Twd9nbaZ+7J3Ve5GlSVtjNR2P0eiOR0pDB6F1dMZt2vQtH zIrdT8JeqalPQ+kfGPb1LWuPLcY2SZVza8AWtora7aBv1FvPL5qYkM+aa/dBoijj/67m vKA/mN3ggiWNHbMI7f7aQXLFfyjbpnZFNmJShwQ+/fTZzQhmyttdLxj77vBwEc7gt9oO nrwO3W7PDluanX8tPzaP2DXncrYqPZUxNiOpHRed/K8n8ObkvXF/HjUeUtQWPGO0GSfd BQ63wYiD7UDtAa/EJQsGt1Xsqh1tGDMmbByML5ziL5Qt62mzLIKhzbLEJK+CVSdOXZ7s qF0g== X-Forwarded-Encrypted: i=1; AJvYcCVvz+hnGYSuDXhcNEJ+EdNf/C4hFAFge+5IqQGg3INn7NsQyp7CfHaDZ0T0VMdkFhkbJmXVVgf4ErvrVro=@vger.kernel.org X-Gm-Message-State: AOJu0YztQX1Uf30zZ/oXO1gemfLY58Q0+pt2Ychc5C2GXFeA0lIIM22R Qk3kfFyNlEEsSwzCibvuiJV1zPk9M6ewXA2blyFphOegoFW07PP4b5jdoCJRu10= X-Gm-Gg: ASbGncsNB/Bu6n+xQslwlLr2ypLL00qjGUsjbw3hqLSSAes4AIlC3Z5x/F0iqmeSg7c A/RglGG099mWUXirXETFph/dXFqssxYw5OVn962L7oG+mLdRnVPSUaXiS5JmqCvaCGyGzuB+Zky m227nCB+VOumzkj3CWoCP+uGvOmArVEAIUfF9vorblZaISjIXQzqBnVCPSMJi05ZeoP75rAu8QX QHQc5kUxWwwbBfZy3tR2azHuBc+fmCd5aSI7flSku4vUpa+bYE1zHstHByVym3Uj490 X-Google-Smtp-Source: AGHT+IFxMb2oesh8pBt/S0AGpufvN5zhHv/M30Pf7wTX/edjZ8qrqpLT9QM7STSTrQpfkOUyEB4LOQ== X-Received: by 2002:a05:6602:2dd5:b0:843:e9c1:930b with SMTP id ca18e2360f4ac-8499e679bddmr394514739f.14.1734716032784; Fri, 20 Dec 2024 09:33:52 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e68bf7ecc6sm877195173.70.2024.12.20.09.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 09:33:52 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 10:33:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc To: David Gow , Brian Norris Cc: Greg Kroah-Hartman , Maxime Ripard , linux-acpi@vger.kernel.org, Rae Moar , Rob Herring , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Shuah Khan References: <20241216201148.535115-1-briannorris@chromium.org> <20241216201148.535115-2-briannorris@chromium.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/18/24 22:45, David Gow wrote: > On Tue, 17 Dec 2024 at 04:12, Brian Norris wrote: >> >> of_find_device_by_node(), bus_find_device_by_of_node(), >> bus_find_device_by_fwnode(), ..., all produce arbitrary results when >> provided with a NULL of_node, fwnode, ACPI handle, etc. This is >> counterintuitive, and the source of a few bugs, such as the one fixed by >> commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if >> one actually exists"). >> >> It's hard to imagine a good reason that these device_match_*() APIs >> should return 'true' for a NULL argument. Augment these to return 0 >> (false). >> >> Reviewed-by: Rob Herring (Arm) >> Acked-by: Rafael J. Wysocki >> Signed-off-by: Brian Norris >> --- > > Seems sensible enough to me. > > Acked-by: David Gow > > I assume this series (including the KUnit test changes) will go in via Greg. > Works for me. Acked-by: Shuah Khan thanks, -- Shuah