mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Francesco Dolcini <francesco@dolcini.it>,
	Matthias Kaehlcke <mka@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stefan Eichenberger <stefan.eichenberger@toradex.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Subject: Re: [PATCH v1 2/2] usb: misc: onboard-hub: add support for Microchip USB5744
Date: Wed, 15 Nov 2023 12:20:35 +0100	[thread overview]
Message-ID: <c8e52587-5ad2-46ac-a5a8-71738b9f5ac7@amd.com> (raw)
In-Reply-To: <20231113145921.30104-3-francesco@dolcini.it>



On 11/13/23 15:59, Francesco Dolcini wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> Add support for the Microchip USB5744 USB3.0 and USB2.0 Hub.
> 
> The Microchip USB5744 supports two power supplies, one for 1V2 and one
> for 3V3. According to the datasheet there is no need for a delay between
> power on and reset, so this value is set to 0.
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

The patch is correct based on functionality you want to add. Would be good to 
also add support for initialization over i2c which will change couple of things.

Thanks,
Michal

  reply	other threads:[~2023-11-15 11:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 14:59 [PATCH v1 0/2] " Francesco Dolcini
2023-11-13 14:59 ` [PATCH v1 1/2] dt-bindings: usb: microchip,usb5744: Add second supply Francesco Dolcini
2023-11-13 19:55   ` Conor Dooley
2023-11-13 20:08     ` Francesco Dolcini
2023-11-13 20:31       ` Conor Dooley
2023-11-13 14:59 ` [PATCH v1 2/2] usb: misc: onboard-hub: add support for Microchip USB5744 Francesco Dolcini
2023-11-15 11:20   ` Michal Simek [this message]
2023-11-15 22:53   ` Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8e52587-5ad2-46ac-a5a8-71738b9f5ac7@amd.com \
    --to=michal.simek@amd.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=stefan.eichenberger@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®