From: Stefan Wahren <stefan.wahren@i2se.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
eric@anholt.net, gregkh@linuxfoundation.org,
f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, tuomas.tynkkynen@iki.fi,
inf.braun@fau.de, tobias.buettner@fau.de, hofrat@osadl.org
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.org>
Subject: Re: [PATCH] staging: bcm2835-camera: Avoid apotential sleep while holding a spin_lock
Date: Mon, 24 Jun 2019 10:13:48 +0200 [thread overview]
Message-ID: <c8e5abba-7441-b201-1618-c92dfdfc7b1c@i2se.com> (raw)
In-Reply-To: <20190624053351.5217-1-christophe.jaillet@wanadoo.fr>
Hi Christophe,
Am 24.06.2019 um 07:33 schrieb Christophe JAILLET:
> Do not allocate memory with GFP_KERNEL when holding a spin_lock, it may
> sleep. Use GFP_NOWAIT instead.
>
> Fixes: 950fd867c635 ("staging: bcm2835-camera: Replace open-coded idr with a struct idr.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
there has been a fix for this, which isn't upstreamed yet. The preferred
solution is to replace the spin_lock with a mutex. Since i'm currently
working on this i would take care of this.
Sorry about this.
Stefan
prev parent reply other threads:[~2019-06-24 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 5:33 Christophe JAILLET
2019-06-24 6:37 ` Nicholas Mc Guire
2019-06-24 8:13 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8e5abba-7441-b201-1618-c92dfdfc7b1c@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.stevenson@raspberrypi.org \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=inf.braun@fau.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=tobias.buettner@fau.de \
--cc=tuomas.tynkkynen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®