From: David Lechner <david@lechnology.com>
To: Sekhar Nori <nsekhar@ti.com>, linux-arm-kernel@lists.infradead.org
Cc: Kevin Hilman <khilman@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: davinci: DA8XX: fix oops in USB PHY driver due to stack allocated platform platform_data
Date: Fri, 16 Mar 2018 10:20:36 -0500 [thread overview]
Message-ID: <c8ece16e-7335-f99e-8602-5f0be6897a1d@lechnology.com> (raw)
In-Reply-To: <382a269a-f486-8c1a-23b2-9620a01a073c@ti.com>
On 03/16/2018 05:17 AM, Sekhar Nori wrote:
> On Thursday 15 March 2018 11:32 PM, David Lechner wrote:
>> This fixes a possible kernel oops due to using stack allocated platform
>> data for the USB PHY driver on DA8XX devices. If the platform device
>> probe is deferred, then we get a corrupt pointer for the platform data.
>>
>> We now use a global static struct for the platform data so that the
>> platform data pointer does not get written over.
>>
>> Tested on OMAP-L138 LCDK board using legacy board file.
>
> Oops. That should have been caught in review.
>
>>
>> Fixes: 9b504750923cb ("ARM: davinci: da8xx: Add USB PHY platform device")
>
> The offending commit seems to be bdec5a6b5789 ("ARM: da8xx: use platform
> data for CFGCHIP syscon regmap") in my tree which should be in
> linux-next. I don't think we have this issue in mainline. Right?
You are right. I'm not sure how I got that older commit. The issue is not
in mainline yet.
>
>> Signed-off-by: David Lechner <david@lechnology.com>
>
> Thanks,
> Sekhar
>
prev parent reply other threads:[~2018-03-16 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 18:02 David Lechner
2018-03-15 19:14 ` David Lechner
2018-03-16 10:17 ` Sekhar Nori
2018-03-16 15:20 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8ece16e-7335-f99e-8602-5f0be6897a1d@lechnology.com \
--to=david@lechnology.com \
--cc=bgolaszewski@baylibre.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®