From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CB4A2AEF5 for ; Wed, 18 Mar 2026 00:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773794648; cv=none; b=cu5mkC17I4Rsh/dE38/UDKVuVkG2tfcqstIew38WCLy/Xuk2oN2pXAD8a9bYSgKcsBwn9BKNH2NUZQwzPjMNClVMaGsf2B8m4kx5otGp3zm89OvC775JZxwha3XHiMA0kPn/2qfcw8mu6OjM/tLJc0nalZwY79rx/76N/0/M0Yw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773794648; c=relaxed/simple; bh=NGoE1cDoBcTftVSQ+ZwV650yL2LvXWLP8EZteCeKrZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t3D9kqGe8MaHWJU0VMkHzXx6gJUI1rsBU5zA9zgzlfRumTgvs1EJ1JVOBJH7+EdnANUSQnmygEFRYQvjzwH9oFzlHzSiKmsUnK/y39a+ckYv42RvfCJFzQEgpxj/w4NgpK6GvMkBnjcXv99zN1GpDbWt5a8vHYMzTFyO9wRmgOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pardini.net; spf=pass smtp.mailfrom=pardini.net; dkim=pass (2048-bit key) header.d=pardini.net header.i=@pardini.net header.b=Am4pLtbB; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pardini.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pardini.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pardini.net header.i=@pardini.net header.b="Am4pLtbB" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso7610800eec.1 for ; Tue, 17 Mar 2026 17:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pardini.net; s=google; t=1773794646; x=1774399446; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z3klIIEcX92zdVI267329I5bjpI/sVO4ClpefsxUOMo=; b=Am4pLtbBfWD8PZl2n9Y7ItBgJdRHbJJ4wRz1cPJQN8FUEya/Yygcsn9a72XH9rRWm4 hUEHdRynGCs+9UQrxAKx6CLuDjmWX375X8Ha5BuBSObcR92FES47CDAZ8okf0eG8NarZ cc82nxQnts02QJ1FtHaQ80BoklPoMIllO/RA2cOB6PBO6MBoEG2pOwG9LS4SnxOOh/eh NEUPYIfHI9ARRZXQjl7OPyoBHEXwtQgolKeRhgNxoqd9JXcuLouqS9v7sknKygdMPaoo qzNJvxdC4htViSbAY1sfr0z+3QF+oBZVuVtYBnJLhRsh7VTo/GKHM832wjW3SK5Q0/FO fc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773794646; x=1774399446; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z3klIIEcX92zdVI267329I5bjpI/sVO4ClpefsxUOMo=; b=oRshix77vCJXwjUoktXTVPy5+1D59Q4Kru7t+Y3Mw2sAhKhZW92QOVPzF4qZDiLkXh lAqhd2gLJgZSHg1TTHqSmiJhJ7uLGhjSj6BB2PbDZVJ7DFscjDagDCOZyiFblngZl1zQ f8RigvbB5g1W09D4fL1KhYfBbypKI6ZvFr5+V6UXBfwLJk28fPIcPiESnUXEKLD1v7iA JGfgpHMKL715Pri3YB8D+dq9k6SIPc59LxBwYtHWFJRCk8rOnXB3F5cKMV6C2TUggGcO 4B5+6zQf8LtzCYz5QhM99j3tnHWyKfIxHQ/SmhrrolWNTUkeKpzELuu7FnEIa5yOA3qI lAlQ== X-Forwarded-Encrypted: i=1; AJvYcCWjzhWoAwxkeFegLlAHs9KSVxIJLMSTDuk1yhm1kTOTAOB0WqPhH6oifrG1nOtCKjPjGiGFH0FhyuEMb68=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ9URBJvKnJl3ltAQhaKgN1rxJ8CRJwSCu/8ygAofdUiC5WpxY zAoA7VtCHJ+SKr6OdMS8su1SjYTQpzuf3DOOrpQORLXVZCAD9U8KgFdtltCC6kWjkA== X-Gm-Gg: ATEYQzwHMNmYqNmZlx+/1UAg6HthdqFnCK4ugNrTK/5EwJ5mdzszt01mjK0QqdoOQTA Q5cdd1DdFXLwiRiYidzpF/ZPI8ewENkLdF68078J6neuz22fNaNvKwVLRtxnOyzMcFtt70Vp/vY LeHV1YmB+i4K8IyW+Tspq5ig4ddydCSX/PubtfpBQWkPgnV63t/e7qk19kkBp9wac8hrq07bs4I 5ExWHmwlo5XJDJ/Mzr02UsrwVDwt+bOPLoQIFusMUrrSl9DjawbuWwH6RmloCepE02z2/aSe56c 4SwtNfvDDZJGbld0GOkFQ2wmhVE8oyznhYKx76JCtx7NylrRfOVoaqHPhuErn1HvFZ+EnaBMQQ9 94sh71JoY1Yj6fc9rprZ6TcZtjuJ/4eAXtvH3/oo5kf5JQ8RYzRsOuODCiqaqAOKBnA8p7AOxad 4VMhI72NySwukdBCtzYV3+WzKWZnyDcSnpm23SYcerWgivLjHneYaFxCwPsfXwdKJaQsLO0Jcm3 FMz01eXjoQf3cIPOA== X-Received: by 2002:a05:7300:ad2d:b0:2ba:6723:503d with SMTP id 5a478bee46e88-2c0e5193913mr637584eec.20.1773794646317; Tue, 17 Mar 2026 17:44:06 -0700 (PDT) Received: from ?IPV6:2804:7f0:6980:fbfc:7d22:811:8e46:acbe? ([2804:7f0:6980:fbfc:7d22:811:8e46:acbe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55ee672sm1972724eec.28.2026.03.17.17.44.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 17:44:05 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 21:44:00 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] clk: rockchip: rk3588: add I2S MCLK output gate clocks To: Daniele Briguglio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Nicolas Frattaroli References: <20260316-rk3588-mclk-gate-grf-v1-0-66fb9a246718@superkali.me> Content-Language: en-US From: Ricardo Pardini In-Reply-To: <20260316-rk3588-mclk-gate-grf-v1-0-66fb9a246718@superkali.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/03/2026 10:06, Daniele Briguglio wrote: > On RK3588, the four I2S master clock (MCLK) outputs to external IO > pins are gated by bits in SYS_GRF SOC_CON6 (offset 0x0318). These > are set-to-disable gates with hiword mask semantics. > > The TRM documents the reset value of these bits as 0 (gate open), > but in practice the Rockchip firmware (BL31) may set them during > early boot, preventing the MCLK signal from reaching external audio > codecs. The kernel should manage these gates explicitly so that > audio functionality does not depend on bootloader register state. Hi Daniele, This series fixes ES8388 audio on a board (Mekotronics R58X-Pro) which I've not "yet" sent to the list due to lack of time but also because analog audio was not working. Without these patches, the i2s0_8ch_mclkout_to_io gate remains closed (enable_count=0 in the clk_summary), and the codec receives no master clock. DAPM reports all widgets as powered on and playback streams run without errors, but the hardware produces no sound — a rather frustrating failure mode to debug. With the series applied and the board DTS updated to reference I2S0_8CH_MCLKOUT_TO_IO from the codec node: es8388: audio-codec@10 { compatible = "everest,es8388", "everest,es8328"; reg = <0x10>; clocks = <&cru I2S0_8CH_MCLKOUT_TO_IO>; assigned-clocks = <&cru I2S0_8CH_MCLKOUT>; assigned-clock-rates = <12288000>; ... }; audio playback then works correctly, tested on headphone output; thus: Tested-by: Ricardo Pardini Thanks a lot! -- Regards, Ricardo