From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751252AbdEaO6G (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 May 2017 10:58:06 -0400
Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:56609
        "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1751032AbdEaO6F (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 May 2017 10:58:05 -0400
Subject: Re: [PATCH] selftests: sync: Skip the test if kernel support is not
 found
To: Gustavo Padovan <gustavo.padovan@collabora.com>,
        Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kselftest@vger.kernel.org, emilio.lopez@collabora.co.uk,
        linux-kernel@vger.kernel.org, fathi.boudra@linaro.org,
        shuah Khan <shuahkh@osg.samsung.com>
References: <1496227215-16371-1-git-send-email-mpe@ellerman.id.au>
 <7552d17a-04b5-ea8c-e5c0-f0db1bea5f16@collabora.com>
From: Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <c8f0c6da-8a50-b099-0480-9d066fa61e88@osg.samsung.com>
Date: Wed, 31 May 2017 08:57:55 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <7552d17a-04b5-ea8c-e5c0-f0db1bea5f16@collabora.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/31/2017 08:44 AM, Gustavo Padovan wrote:
> Hi Michael,
> 
> On 05/31/2017 07:40 PM, Michael Ellerman wrote:
>> The "Sync framework" test doesn't work if the kernel has no support,
>> obviously. Rather than reporting a failure, check for the kernel support
>> by looking for /sys/kernel/debug/sync/sw_sync, and if not found skip the
>> test.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> ---
>>  tools/testing/selftests/sync/sync_test.c | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
>> index 9ea08d9f0b13..62fa666e501a 100644
>> --- a/tools/testing/selftests/sync/sync_test.c
>> +++ b/tools/testing/selftests/sync/sync_test.c
>> @@ -29,6 +29,7 @@
>>  #include <unistd.h>
>>  #include <stdlib.h>
>>  #include <sys/types.h>
>> +#include <sys/stat.h>
>>  #include <sys/wait.h>
>>  
>>  #include "synctest.h"
>> @@ -52,10 +53,22 @@ static int run_test(int (*test)(void), char *name)
>>  	exit(test());
>>  }
>>  
>> +static int sync_api_supported(void)
>> +{
>> +	struct stat sbuf;
>> +
>> +	return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
>> +}
>> +
>>  int main(void)
>>  {
>>  	int err = 0;
>>  
>> +	if (!sync_api_supported()) {
>> +		printf("SKIP: Sync framework not supported by kernel\n");
>> +		return 0;
>> +	}
>> +
>>  	printf("[RUN]\tTesting sync framework\n");
>>  
>>  	err += RUN_TEST(test_alloc_timeline);
>>
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> 

Thanks both. I will pull this into kselftest for 4.13-rc1

-- Shuah