From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933571AbeAKWAO (ORCPT + 1 other); Thu, 11 Jan 2018 17:00:14 -0500 Received: from mail-eopbgr00113.outbound.protection.outlook.com ([40.107.0.113]:21189 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932790AbeAKWAJ (ORCPT ); Thu, 11 Jan 2018 17:00:09 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage To: Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Kostya Serebryany References: From: Andrey Ryabinin Message-ID: Date: Fri, 12 Jan 2018 00:59:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [84.47.128.244] X-ClientProxiedBy: DB6PR0402CA0012.eurprd04.prod.outlook.com (2603:10a6:4:91::22) To DB6PR08MB2822.eurprd08.prod.outlook.com (2603:10a6:6:1d::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c5ba878-ea0b-4b47-af53-08d5593eac4a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020072)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:DB6PR08MB2822; X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2822;3:TY/BUp7yVsWBpQpLRiAxRMbUOzmBRUpL8Q3e9hqtsnlhCAU+jRIh+/1wIP93Kkd+NiSMNaP0eVbihpzFwoutXrLYITgQWPg/OfUkDi2MMgE/lQUnx0kRNK/vKW7X9trjvxtcPn9H+Oej8NS10GsYMvFaslbian22DyyV9Hj6qkD1HuNd061O6Zz/G5GQbDgEEzqpIZJayrHVsUqQPzv4T71FY6tPZNflf0LMfdiLD6gjlpp9mPkuu83b+tXcQ6Lh;25:IyXF+6DtuTkzT5VEg1bm9+PZoDuhUawdScKornw++jkrpb7jxF59agJfdru5OFhyRyzvL1O5H3HIqcSfiaE1Y1RnxsWlWf4HTPfMrLKGak08fMdDGpxnvrj+rtdIKhb4dXSnEI7814aSm020l4OgxTi7JT/xchhFRkL2lUs14ewo0RWH9E2NDUlErhvkAKEmvnevELME7OGq2SkFfGGA95MdSoXN7LzBiyNNgZonRbSRFxtqedldwm0HLplVDJeVLokYQFpTHIs2WdJ+xRUc6QVCMJUeCYuuopuK6CEBkqDi+XLmpG0PAl4jFMf85fJYNMVfquwdLgpgPlreIB/SSA==;31:ijZ1D0cYCRCbcG5AVYjfYFtN4PVzg32lYhH++6ciVL6QL75nQgnsjnSnNQV95TbN0/C4YuaKg/nsh/M/DalcDRg+V3nzImJmTMY3CT6Gtf8Lh0/JL9gBBHjobJkk4+KwCb9ogc6fYE+ZyZ06jVnP9+TyUbW755wrYj/LGotXCLXxwy+l/6KC1BiKWj/UscfOgJVGvAWtOr6N/AgLBYCLu/xTMbGD6JsHq25hK++pMnE= X-MS-TrafficTypeDiagnostic: DB6PR08MB2822: X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2822;20:sebGwHIHdCjliv3QNpq0l1rC9yYgOzOet27MldWBb/j86S22qZE6mZ/Ssw7kBhRRt6etNJkt5uxBZCMo+pu454GzQ1/iPs/JlyY6okf8F6NipQuMx7fas7DjfnYVU/RMPpttFmjW8y/y615gYycSYoWHhQIGSprV3aF0kNqs5EWUlhkcppmYBV4YQiiguLP5lp2L+7hddgJsAyMXbsEQVZC84hwGWbu9Dix0M6UwYZSDwtDmzB/X5BPqWy4vOSq1b9iBT1do6xQ6tQ1F2cLGxHBv5Jed+UxgMAAg5/k3+UHPxvgk5CbhWQsLNMFSBg5qB0VQa7J456iaRRzI72bt2zRX/xwwH7Y1ZCI6Nx83DBSjRh1Q0WqoymwQviOKFa5bu7u64Dob28Z3dIyY8YXyYGU/5/he0pLbhTAg0OMg4yY=;4:2FVZoBWz8m5RYYh+mggfZMbnbWwigYkwvGL78/8AguMuKv1i72fJNy+DQSJfUiOVQ8DBa9vroMHZ+l23CSrnZvJ8v4UHbNbQex2gOqudmv+d5cm0fILNv0zer2kqqLm3hY4ZN4jwZTrBAaSPuztxvrVdYMQPxk9fAIu+TeUJ/IlIoVpDYY1qmW58gA7Ol7XGm2zl1QGCsKJrG+Ix/x3B1yuwgIqSCytuUkhuJYcqr4/MEJBeVj35+jzL72/a2DnT5s6u2EvTtSRxcU98i94Oig== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(944501136)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011);SRVR:DB6PR08MB2822;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB6PR08MB2822; X-Forefront-PRVS: 0549E6FD50 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(396003)(39380400002)(39850400004)(376002)(346002)(366004)(24454002)(199004)(189003)(230700001)(8936002)(77096006)(86362001)(6486002)(478600001)(2950100002)(6666003)(50466002)(6246003)(97736004)(31696002)(53936002)(229853002)(31686004)(36756003)(68736007)(64126003)(7736002)(65826007)(316002)(5660300001)(386003)(305945005)(16576012)(59450400001)(58126008)(2906002)(53546011)(76176011)(23676004)(52116002)(110136005)(7416002)(52146003)(2486003)(83506002)(3846002)(6116002)(65956001)(81156014)(65806001)(106356001)(4326008)(81166006)(105586002)(66066001)(8676002)(25786009)(16526018)(47776003)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR08MB2822;H:[10.52.82.104];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4TUIyODIyOzIzOnFhRHN1THVsbCtKL1hXVEtoWFJQd09YaGRz?= =?utf-8?B?eGZqQzBmdDBYcEpvMDVpaDYzK3VZL1FmeUFzaUdjNmZ4SkdLZ2lhTVdlUVIr?= =?utf-8?B?eklEWUdwd29wSjV6YU1xazNPVGltekhqTXZTWlMzV2E2a3V5M0haZW5QY2hi?= =?utf-8?B?K2xxelB1aFhnbUNxZDhnM05tRUVrM3c5WWhreE5nRkJrZzhocFMzOGR4NEdS?= =?utf-8?B?aFpyUGs1QUJvbUlSbDhUZy9manFLeEhtQlM1TUk3OUZwS0VxeWMwNkZneDgv?= =?utf-8?B?YUN6em5sMnRrR1hYMUlGWldmNjFxa2poTEgra3BSalJtcEJpQy9KNzZoN1pZ?= =?utf-8?B?K25DVXUxNk41N3ZCNlc3MDZSekkxN1JZU05oV3VpMEwwRFEvNVd6SFlRcFlE?= =?utf-8?B?dk1XSXVEOWR1SGdwUXRuVHExQng0ZFVybEp4aEJ5VXlZZGF6U25ib2hGTFJj?= =?utf-8?B?YllqemFCREw2WGhhdkpPSmVvdUl5WXFSZjFiTEIvRk5BSmFTeER2a2Rna2lR?= =?utf-8?B?bENIMFh3aHJOQyt4WFZlUnY0aHJHcUdKbE5TRGpXZUVaY3JhekhMdlA1Tkhv?= =?utf-8?B?YU8wcTBQTG9aUEZseEFoK0lOcVNZc3VnTEJpWlNmbzFpZCtMK1VJZ3ZEUUZI?= =?utf-8?B?TGF5bnV6MkFKb1VEbGYzSC9Hb0RkZlkrQjFQcEpJeU9xUWx2WDJGL2lmNEFj?= =?utf-8?B?cFpNT2QzQkIwUXlxNkVacmdqTllWVVc5K3hFQ3g5MGdvVHZVRUtQY2RwL0tv?= =?utf-8?B?MVplTXVGTDNSemNIWVV6RC9yaWpHVk1teE9iQ2xRaUYwMVh3dlcyamJKZmNW?= =?utf-8?B?dHJhNDNqOEtKRFlmaktpNGExQUFNcENBZmJXUHJvRmk2VUpkQlRHTnFqbjBw?= =?utf-8?B?bEpkYkVuZGVJb2oxWWQ5aG9ENkh0Y0p4M0t5SDI3TW80NEdoaTlEcjR3N0Yz?= =?utf-8?B?UW9yY201WTBJZFNjSDBMLzVjSTdEZjJYTk5QRHpxZUJiYTRORSt5ZHdtK2Ry?= =?utf-8?B?dmhaL3V1M1hVZ1BwZFNwRjdjRCtoNzd4T1FyV3VFWndSYzBWL0gvTFJ0dk5V?= =?utf-8?B?ckJ5Y3FPK0NicldXU3hVMjJnVCsvanYrc1k4cXBtWHhUcUYyWGt4Z2s3MW5h?= =?utf-8?B?QUxGcGU3Qk02RVErT2RiYnZNUzJhcDBxaHZZNzlqUEgzWTkvUFlQcHJkcFRw?= =?utf-8?B?SzBRUmphdTBZRVB2Q1VYK1Ivako3SlZPR0hhR0JKb0JKa3U0dEJIUEtMcVVl?= =?utf-8?B?N2x1bldCWWFZaU9Sb2plWFlGQWhxbXlGRUovN1JnWVJnTzRkRm9oRFlVVlZt?= =?utf-8?B?MEpqTUd1RGxjRVZHOEF4ZnZiL05xZUhDdEdQUXUzb0Y1enJ3WkVtaldqK1ZS?= =?utf-8?B?c0FwRHZmZW4vNjNzSzVBaFhNZFRKVXNZSzRhNis2Yzdyd3VjWFVncyt0cWtG?= =?utf-8?B?RHFoOWVhdzRxTFlRTFZ2bU5TdjZ5ZFhlaTJEU1VvMVE0QW8yV3d6MXRYL281?= =?utf-8?B?WThLVGVBRHBsSnBON1huNlNQRis0VVNNL281N0ZwMjV5eWpvOXlMMkFuM0VR?= =?utf-8?B?UXZsZWpjQit5RTBnNVN4eGs5UGh2VHVPd3ZyblF5dS82N2loWWdNL1Qxb1dE?= =?utf-8?B?cFRPcTFtcUJjY0RGUVV0SC9XZzJ2SHlucjlHYzN5S1cyRGN3djBaa3ovSWNo?= =?utf-8?B?U2tiWFRlYWZ3dlNOMlROUjl3b3RwelZONHlzRVJWUG9SOFBKL2ltNW82cFVY?= =?utf-8?B?OXpXN2J4eGZsS25wc05wVHpwUWE2RWNrUUhhaXU2endrcERTSVdDYXlld0VS?= =?utf-8?B?bmpOWnBFRXpQdUlmYkZ4cnVGeitqbjlSZFRBNHIyemZNU01GbHR1VzFKb3ZC?= =?utf-8?B?L1ZrYlFZUDg1QnRtWEY1WWd5YlludUJKUDV2bklhWlEyNHZ6cTlDR0drTlUv?= =?utf-8?B?NG9qZFlyN0x3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2822;6:xr6rDAWjveKuVtLpYTfA16IDb66ifO9ypLwzG2OH7OEoNv8mQwLRQ3YVDZ3KKWKcSdaXA5qkFmhASmWqQ9pAXcX6711ZuYkpv+0Yz3Hv/jMuA95f2C9A/QWHuFrGTFvUi52tYws6kLcQ4GaOGwaZaXrafFWwztdK79f8oSDTHHtQaa+j+/zPMTIEBEYEhpLY9P/x/yq02gr0rPtcV7c5sW6/w2eugdiD2BSRHLjQQkeWT2A7xL8giDbDbgA3f7m45tdpK/ZIB4UIfK4J6DNCBnrNvUcrBIwKPsdmudMpp3XMRHvj2SOyUpf/ocaSJNGq7zte9gixcTy3Ie0oiQGNGgrAPoum8WB1rtM3SJ7CNV0=;5:somFt39wOM6oXaapzJiN5U5SIsbia2ss/etElqWDDXEWA9eOTqXK2hbm0UIivRVWTkIekMvqFqY/5pLn4uH/+R4O83l7b1AmOIRqk6tdXlJlOVAHSiLRsRIe7gUG+HwUckW8wpX+jzeRic9TYGGLOJYYD7pTL8R9pmj5O431WfQ=;24:nDhDRha3z0pJ3zRgLDbMCiV3DJIk10amddDIMz3HtPnkhuMlOgygTeLzjvp8dKEguVqOpDJFtQM6fzNDdvivM2xhc7xHd/Dl9r3+oHIt/c8=;7:mrXuBaMyboIE3EJJpGjT2o/urX5sVIVr6uOFd6AEUay19Y/QWmvZ+0OCbUQjj+WYKeKQM/ifJFMeOiM40wNbaYn2dKMI+IuwtYVJvKspFdyAw8HC52opuyIUTNOgJqx9+guxg9/QYW4fr/Kd9MxNv798CaqwfM5n0VSdA5tfKgKT2gyzjwM3fVT0YZiP9ejtFBPf21u9TAaRIaBA9sj5WbDR1SHdrBAztDrYwo7csqG9pao83nIR6rao4dZn9edH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2822;20:JONoGYLekuBkBqQJsULmoh6bFtlsoJwV7m5Fb3lqmo3iAES3f+UcN1ybDgqozKBHCbFgESeNNxHgbN/DsPXfxPKwycQpxrkTbTMM7Kp93ZCKGjq4BpatWpm35jP+QM+tA69aHZfnqb/kS7CrNXKO1TKg4vCFMOKKIvdR5iUuEjA= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2018 22:00:04.4494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c5ba878-ea0b-4b47-af53-08d5593eac4a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2822 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/11/2018 06:29 PM, Andrey Konovalov wrote: > diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h > index e266f80e45b7..811643fe7640 100644 > --- a/arch/arm64/include/asm/kasan.h > +++ b/arch/arm64/include/asm/kasan.h > @@ -27,7 +27,8 @@ > * should satisfy the following equation: > * KASAN_SHADOW_OFFSET = KASAN_SHADOW_END - (1ULL << 61) Care to update comments as well? > */ > -#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << (64 - 3))) > +#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << \ > + (64 - KASAN_SHADOW_SCALE_SHIFT))) > > void kasan_init(void); > void kasan_copy_shadow(pgd_t *pgdir);