From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0656C433FE for ; Sun, 20 Mar 2022 13:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239999AbiCTNXY (ORCPT ); Sun, 20 Mar 2022 09:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237391AbiCTNXW (ORCPT ); Sun, 20 Mar 2022 09:23:22 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF6343D1CB for ; Sun, 20 Mar 2022 06:21:58 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id bg31-20020a05600c3c9f00b00381590dbb33so7086608wmb.3 for ; Sun, 20 Mar 2022 06:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=CiwhGRNrXz4QNizMa/oAhqtF2xiNgjqkYli9zHg8NMo=; b=ooINi4qmadEwMMSSbUh9xuE2GUMZdFzpXR1++zh7EgKuDr1/NmJNrR7aEgX9YEYnqR j/C7WHJwAEaroHujPrPBwHaVKiGIbu1nwhw6Bvq+dEbjefo+cmS41dhKhkQ7W2enDIcn FwsFB9BzT3mLwMM+/x6ZL3laea9/DI7YnSRRxUERp8zMouKs6KjyFAF0jRCtuQjp1GFb NzO6gACyZQm+mAnPo/n3gilRevnFb/8ycSHL5qutcWmYhYgL/Hn1gcm7GD7dGf2KMLkg 14giC/KDFp/is73wLuzsjr6B2mi5ks2+ehWaq7GJRiCaKi+k83jrzVLsf4GEDI/JshXs kKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=CiwhGRNrXz4QNizMa/oAhqtF2xiNgjqkYli9zHg8NMo=; b=CzveUV+hUqFKT5i1dNOvSp8bJa+nzLao/67MYI85tffDyIwaDoy0VztmqbXuJ4iAWn C5Gr111omkLnmerzu7si5WbNw67kQI7dizonPXWwXRLdRShnMzBOX+Ou0SseBj8nmoku 99ogKlegdx+GZIpilCkm40bsc+uiV4p4gO+uX7S1SP/L0QPrN7M11HjH8A8ETRxHQU8/ 54S/8Y0eITgI58DCN1MB5pzTZJnvAMV8s0dVscIV62MektRtZsg6XgTzifPYLvETbQyZ wiO5FKgyEHkVW9Npu9WByoct9Gyx57c6uJfIwfT9u4Sc8vyW6LpvZ15Td9QQjGPTY4UT aC5w== X-Gm-Message-State: AOAM532bTfMpdtu9dz4GgK86/tEvAEh/i1sUxmphNBnzVBt0b4/Hpnx3 kuA6yfSav8tuOD4HfMSV8pWRsw== X-Google-Smtp-Source: ABdhPJwpvkdAY6cBXr3dOsU2mQlSFPo8+WDyEP4JRfxs73L2obnJJNJLtCZo6KY0b0mYyHj82adJdg== X-Received: by 2002:a7b:c2aa:0:b0:389:891f:1fd1 with SMTP id c10-20020a7bc2aa000000b00389891f1fd1mr23391259wmk.138.1647782517417; Sun, 20 Mar 2022 06:21:57 -0700 (PDT) Received: from [192.168.0.69] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id l9-20020a5d6d89000000b00203d62072c4sm11795831wrs.43.2022.03.20.06.21.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 06:21:56 -0700 (PDT) Message-ID: Date: Sun, 20 Mar 2022 13:21:55 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2 2/2] wcn36xx: Implement tx_rate reporting Content-Language: en-US To: Edmond Gagnon , Kalle Valo Cc: Benjamin Li , Kalle Valo , "David S. Miller" , Jakub Kicinski , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220318195804.4169686-1-egagnon@squareup.com> <20220318195804.4169686-3-egagnon@squareup.com> From: Bryan O'Donoghue In-Reply-To: <20220318195804.4169686-3-egagnon@squareup.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/03/2022 19:58, Edmond Gagnon wrote: > + INIT_DELAYED_WORK(&wcn->get_stats_work, wcn36xx_get_stats_work); Instead of forking a worker and polling we could add the relevant SMD command to static int wcn36xx_smd_tx_compl_ind(struct wcn36xx *wcn, void *buf, size_t len) { wcn36xx_smd_get_stats(wcn, 0xSomeMask); } That way we only ever ask for and report a new TX data rate when we know a TX event - and hence a potential TX data-rate update - has taken place. --- bod