From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168126AbcKAIwU (ORCPT ); Tue, 1 Nov 2016 04:52:20 -0400 Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:41812 "EHLO lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1168109AbcKAIwS (ORCPT ); Tue, 1 Nov 2016 04:52:18 -0400 Subject: Re: [PATCH] [media] atmel-isc: release the filehandle if it's not the only one. To: Songjun Wu , nicolas.ferre@atmel.com References: <1477987726-4257-1-git-send-email-songjun.wu@microchip.com> Cc: linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org From: Hans Verkuil Message-ID: Date: Tue, 1 Nov 2016 09:52:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477987726-4257-1-git-send-email-songjun.wu@microchip.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/16 09:08, Songjun Wu wrote: > Release the filehandle in 'isc_open' if it's not the only filehandle > opened for the associated video_device. What's wrong with that? You should always be able to open the device multiple times. v4l2-compliance will fail after this patch. I'm not sure what you intended to do here, but this patch is wrong. Regards, Hans > > Signed-off-by: Songjun Wu > --- > > drivers/media/platform/atmel/atmel-isc.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c > index 8e25d3f..5e08404 100644 > --- a/drivers/media/platform/atmel/atmel-isc.c > +++ b/drivers/media/platform/atmel/atmel-isc.c > @@ -926,21 +926,21 @@ static int isc_open(struct file *file) > if (ret < 0) > goto unlock; > > - if (!v4l2_fh_is_singular_file(file)) > - goto unlock; > + ret = !v4l2_fh_is_singular_file(file); > + if (ret) > + goto fh_rel; > > ret = v4l2_subdev_call(sd, core, s_power, 1); > - if (ret < 0 && ret != -ENOIOCTLCMD) { > - v4l2_fh_release(file); > - goto unlock; > - } > + if (ret < 0 && ret != -ENOIOCTLCMD) > + goto fh_rel; > > ret = isc_set_fmt(isc, &isc->fmt); > - if (ret) { > + if (ret) > v4l2_subdev_call(sd, core, s_power, 0); > - v4l2_fh_release(file); > - } > > +fh_rel: > + if (ret) > + v4l2_fh_release(file); > unlock: > mutex_unlock(&isc->lock); > return ret; >