From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xingyu Wu <xingyu.wu@starfivetech.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Samin Guo <samin.guo@starfivetech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: watchdog: Add watchdog for StarFive JH7110
Date: Mon, 19 Dec 2022 11:44:42 +0100 [thread overview]
Message-ID: <c906603f-bf84-06d4-3e9c-bd4ab748591d@linaro.org> (raw)
In-Reply-To: <20221219094233.179153-2-xingyu.wu@starfivetech.com>
On 19/12/2022 10:42, Xingyu Wu wrote:
> Add bindings to describe the watchdog for the StarFive JH7110 SoC.
>
> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
> ---
> .../watchdog/starfive,jh7110-wdt.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml
> new file mode 100644
> index 000000000000..a7bfe0751928
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/starfive,jh7110-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive Watchdog
> +
> +maintainers:
> + - Samin Guo <samin.guo@starfivetech.com>
> + - Xingyu Wu <xingyu.wu@starfivetech.com>
> +
You miss watchdog.yaml. I asked to drop the quotes (so the " character),
not the $ref. Please keep the $ref: watchdog.yaml and use
unevaluatedProperties at the end (instead of additionalProperties).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-19 10:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 9:42 [PATCH v2 0/3] Add watchdog driver for StarFive JH7110 RISC-V SoC Xingyu Wu
2022-12-19 9:42 ` [PATCH v2 1/3] dt-bindings: watchdog: Add watchdog for StarFive JH7110 Xingyu Wu
2022-12-19 10:44 ` Krzysztof Kozlowski [this message]
2022-12-19 9:42 ` [PATCH v2 2/3] drivers: watchdog: Add StarFive Watchdog driver Xingyu Wu
2023-01-17 6:35 ` Xingyu Wu
2023-02-01 22:46 ` Guenter Roeck
2023-02-10 7:01 ` Xingyu Wu
2023-02-10 15:28 ` Guenter Roeck
2023-02-13 13:29 ` Xingyu Wu
2023-02-13 15:26 ` Guenter Roeck
2023-02-16 7:11 ` Xingyu Wu
2023-02-16 14:57 ` Guenter Roeck
2023-02-17 2:30 ` Xingyu Wu
2023-02-17 7:29 ` Xingyu Wu
2022-12-19 9:42 ` [PATCH v2 3/3] riscv: dts: starfive: jh7110: Add watchdog node Xingyu Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c906603f-bf84-06d4-3e9c-bd4ab748591d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®