From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254C2C433EF for ; Sun, 16 Jan 2022 21:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236244AbiAPVrI (ORCPT ); Sun, 16 Jan 2022 16:47:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233771AbiAPVrI (ORCPT ); Sun, 16 Jan 2022 16:47:08 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62AFEC061574 for ; Sun, 16 Jan 2022 13:47:07 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id m1so50557178lfq.4 for ; Sun, 16 Jan 2022 13:47:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=EvCUOP5l/xUm9Ih4QfQxYRATDJQR7bxJhJawcjpWBaQ=; b=Txv/NF3iEKEyQK1LuA1INgaaW3XLF23PzWKv3Ya6f01kRqh/aYGa3UohY2ARes5Tdu aT3inXEKixY/mZm8gaNM+nE2ms7FKWYRW3XPs/j+TRUTvy44fIWDYWvbg5iiRFkn1HmZ lLlEhmaOx+HBbtmtlbH9W91YyHxdj+DB1R0WVZNlJYP8fI7M9fm+br0iwo+qiSbYUymG o66X2pd4MpBgZXtEcmiz/1v0N2PGVCLQD8Lz0DAJg83JMZUbepjiP0evy617n8ZIzD9g eFoTUemnSFEmU5XP8yzuc9HU2aA/hrH+g3UkVQZoXXBcDd7PURpiSWaC4HzBz4JmfDl2 G/gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=EvCUOP5l/xUm9Ih4QfQxYRATDJQR7bxJhJawcjpWBaQ=; b=IlxFph+rVuu3uPA0PmO/I7B40JYncbMYNHWHihpfnBCPRXtQ6lN4IrUoXNQTK9b8UO qNzobcwONKc0PZq521EvFJz55EZT0eLaEkwgtWh3kIIHPyyo3OKt3jZioxJcXyun5SWg D7C0l/rVaLEDsTQAJD365OGLJQc129S+DpLiVUmdbV+RC3ybjsd35UoqzM+WhNriv7sb usbYMpcRDxQdkh4Ildscsj5T/ZZe8AhYXoniRO/89JWEisB9IdzjL0xQOwfHIuwt/b9X /WKsEo0iz9ntrEm/3+lU2XaFeA/Y+YDBCHG45ybgr0ItsuJsaGX20jmP7M6lFXpLDg8E wCOw== X-Gm-Message-State: AOAM530BjoFkDeBOrzUsoKyIVd5F7mwZN4AlJmqRIruPX5g2C/0kHv7Y kJw7Xx2DqiOUEDQrvgAyKiA= X-Google-Smtp-Source: ABdhPJyDya66CkmXshaXuImVg7rp1Y+lioNQqwieC9gFb7QSx0Qacr8x4blt2Qf3sU+PUxkaRx9+2g== X-Received: by 2002:a2e:98c5:: with SMTP id s5mr14268358ljj.221.1642369625327; Sun, 16 Jan 2022 13:47:05 -0800 (PST) Received: from [192.168.1.11] ([217.117.245.67]) by smtp.gmail.com with ESMTPSA id h3sm940703lft.74.2022.01.16.13.47.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jan 2022 13:47:04 -0800 (PST) Message-ID: Date: Mon, 17 Jan 2022 00:47:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH] staging: r8188eu: handle rtw_init_netdev_name() failure appropriately Content-Language: en-US To: Vihas Mak , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, martin@kaiser.cx, straube.linux@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220116192611.19224-1-makvihas@gmail.com> From: Pavel Skripkin In-Reply-To: <20220116192611.19224-1-makvihas@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vihas, On 1/16/22 22:26, Vihas Mak wrote: > rtw_init_netdev_name() calls dev_alloc_name() which allocates the name > for the device as per the given name format. > It returns a negative err code if the format is invalid. Currently the > name format is specified by the module parameter "ifname". > Warn the user if "ifname" is invalid. > > Signed-off-by: Vihas Mak > --- > drivers/staging/r8188eu/os_dep/usb_intf.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c > index 91792dfd3..875815b5e 100644 > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c > @@ -399,7 +399,10 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj, > DBG_88E("can't get autopm:\n"); > > /* alloc dev name after read efuse. */ > - rtw_init_netdev_name(pnetdev, padapter->registrypriv.ifname); > + if (rtw_init_netdev_name(pnetdev, padapter->registrypriv.ifname) < 0) { > + DBG_88E("rtw_init_netdev_name failed, ifname:%s\n", > + padapter->registrypriv.ifname); > + } > rtw_macaddr_cfg(padapter->eeprompriv.mac_addr); > rtw_init_wifidirect_addrs(padapter, padapter->eeprompriv.mac_addr, > padapter->eeprompriv.mac_addr); rtw_init_netdev_name() has an error message in case of allocation failure. It looks like it's better to handle the error normally and pass it to caller With regards, Pavel Skripkin