From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B33C0502A for ; Sat, 27 Aug 2022 03:11:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345073AbiH0DLx (ORCPT ); Fri, 26 Aug 2022 23:11:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231216AbiH0DLu (ORCPT ); Fri, 26 Aug 2022 23:11:50 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D10E5B1ED; Fri, 26 Aug 2022 20:11:48 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MF1sR44KMzGpqY; Sat, 27 Aug 2022 11:10:03 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 27 Aug 2022 11:11:46 +0800 Received: from [127.0.0.1] (10.174.177.249) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 27 Aug 2022 11:11:45 +0800 Subject: Re: [PATCH] xfs: donot need to check return value of xlog_kvmalloc() To: "Darrick J. Wong" , , "linux-kernel@vger.kernel.org" CC: linfeilong , wuguanghao References: <514e5e4b-e7c8-365f-8459-75974c067993@huawei.com> From: Zhiqiang Liu Message-ID: Date: Sat, 27 Aug 2022 11:11:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <514e5e4b-e7c8-365f-8459-75974c067993@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.177.249] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org friendly ping.. On 2022/8/22 19:46, Zhiqiang Liu wrote: > In xfs_attri_log_nameval_alloc(), xlog_kvmalloc() is called > to alloc memory, which will always return > successfully, so we donot need to check return value. > > Signed-off-by: Zhiqiang Liu > --- > fs/xfs/xfs_attr_item.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c > index 5077a7ad5646..667e151a2bca 100644 > --- a/fs/xfs/xfs_attr_item.c > +++ b/fs/xfs/xfs_attr_item.c > @@ -86,8 +86,6 @@ xfs_attri_log_nameval_alloc( > */ > nv = xlog_kvmalloc(sizeof(struct xfs_attri_log_nameval) + > name_len + value_len); > - if (!nv) > - return nv; > > nv->name.i_addr = nv + 1; > nv->name.i_len = name_len;