From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751294AbdBWLry (ORCPT ); Thu, 23 Feb 2017 06:47:54 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:2953 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751249AbdBWLrx (ORCPT ); Thu, 23 Feb 2017 06:47:53 -0500 Subject: Re: [PATCH 3/3] f2fs: avoid reading NAT page by get_node_info To: Jaegeuk Kim , , , References: <20170214020644.18189-1-jaegeuk@kernel.org> <20170214020644.18189-3-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Thu, 23 Feb 2017 19:47:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170214020644.18189-3-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.58AECBD7.003C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 814b1c2d46adc9bd1a30271e2fb2c338 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/2/14 10:06, Jaegeuk Kim wrote: > We've not seen this buggy case for a long time, so it's time to avoid this > unnecessary get_node_info() call which reading NAT page to cache nat entry. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/node.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index e001d084667f..b63bdb85ad66 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1033,7 +1033,7 @@ struct page *new_node_page(struct dnode_of_data *dn, > unsigned int ofs, struct page *ipage) > { > struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode); > - struct node_info old_ni, new_ni; > + struct node_info new_ni; > struct page *page; > int err; > > @@ -1049,12 +1049,11 @@ struct page *new_node_page(struct dnode_of_data *dn, > goto fail; > } > > - get_node_info(sbi, dn->nid, &old_ni); > - > - /* Reinitialize old_ni with new node page */ > - f2fs_bug_on(sbi, old_ni.blk_addr != NULL_ADDR); What about keeping get_node_info covered with CONFIG_F2FS_CHECK_FS for consistence as we just introduce two new free nid caches, I think it will be helpful for detecting bugs of these new codes. Thanks, > - new_ni = old_ni; > + new_ni.nid = dn->nid; > new_ni.ino = dn->inode->i_ino; > + new_ni.blk_addr = NULL_ADDR; > + new_ni.flag = 0; > + new_ni.version = 0; > set_node_addr(sbi, &new_ni, NEW_ADDR, false); > > f2fs_wait_on_page_writeback(page, NODE, true); >