From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Chao Yu <chao@kernel.org>, xiang@kernel.org
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Yue Hu <zbestahu@gmail.com>,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Sandeep Dhavale <dhavale@google.com>,
Hongbo Li <lihongbo22@huawei.com>
Subject: Re: [PATCH] erofs: fix to add missing tracepoint in erofs_readahead()
Date: Mon, 7 Jul 2025 18:17:48 +0800 [thread overview]
Message-ID: <c911e159-d216-4b0f-865b-f4524e6f8f0f@linux.alibaba.com> (raw)
In-Reply-To: <20250707084832.2725677-1-chao@kernel.org>
On 2025/7/7 16:48, Chao Yu wrote:
> Commit 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
> converts to use iomap interface, it removed trace_erofs_readahead()
> tracepoint in the meantime, let's add it back.
>
> Fixes: 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
Thanks Chao, btw, should we add tracepoint to erofs_read_folio() too?
Thanks,
Gao Xiang
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/erofs/data.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index 6a329c329f43..534ac359976e 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -356,6 +356,9 @@ static int erofs_read_folio(struct file *file, struct folio *folio)
>
> static void erofs_readahead(struct readahead_control *rac)
> {
> + trace_erofs_readahead(rac->mapping->host, readahead_index(rac),
> + readahead_count(rac), true);
> +
> return iomap_readahead(rac, &erofs_iomap_ops);
> }
>
next prev parent reply other threads:[~2025-07-07 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 8:48 Chao Yu
2025-07-07 10:17 ` Gao Xiang [this message]
2025-07-07 11:22 ` Chao Yu
2025-07-07 11:33 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c911e159-d216-4b0f-865b-f4524e6f8f0f@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=dhavale@google.com \
--cc=jefflexu@linux.alibaba.com \
--cc=lihongbo22@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®