From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6133A43635E for ; Mon, 10 Aug 2026 18:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385625; cv=none; b=mJ/WMBv1/GWP2aY19aUQU5DlmexMLoLkY8VaIt5XP/X6Fr5oGDKazz5O9P9JJQbme7YJEabhJWP0XSkUDXdMk6GfR6ktnS/jgE/PW+s6AvOtNeMfydUFwYe0NltTkzs2GlMvZh6twBzTmtsUXE2nb5huuefPcvKtlyX4N9utD9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385625; c=relaxed/simple; bh=0Eb8GRKvMJHasoh02hWFih058UEYzEaV5ZwlBwnYodA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JF7vl3w9deUY6fWszNYocxNrLR56AOW3627FnItmwxDAyRRqWHKYLyY5pmNN607bCzRnWs8hf0YHSxWfDc0PMnuP8S6qjjZdwkrK6BvvxOJSXtWHzAW8XwbdZeHORrnqmvNNnQ9fcnpKuT8m3XGpMfjf5l0Z0iKOKtGEIlNYht4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G6gQg008; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G6gQg008" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38125cebfdaso2782410a91.1 for ; Mon, 10 Aug 2026 11:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385624; x=1786990424; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CwhhaAGdCkcDIiyyyywufIBhF9Feu3uUwtXlOqQT0nU=; b=G6gQg008M+lMrX8Dw493FoxwK4Mygi9p2lRudqQFKpeo0nZUCzrBeQeTM6YoduEJ1j DuuUvelujl3MXjd4LW+C+V0q0PDIRqm/UVylvIKomn3LubWg+RIxcTx3JYOyOb4vLdFI 2MYs10r0B7U6+bwznivU+9kyhIrMaKf5wLqELXUR/bZkle4zy2J+kokPdBati1Mm4Dli Y++oHEsBBCxNpvF1bCdLxxHBz7QaYVPqwiyxg3E2hxrNBiYMM7X+UUPGL7dIZ+2QEr4E 4HkgEY2BnAVPPg/nFTIJSOGM2Y2DU2MscqoQtEN8+U0sR0AYSLlT9i2P0QQnTUWbvDDj 9iuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385624; x=1786990424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CwhhaAGdCkcDIiyyyywufIBhF9Feu3uUwtXlOqQT0nU=; b=RPGJzS8abTaHgjM+OhO911SmRQSqYjP0JT9XTgk64wAcnEhHNnVoWC+6SX/Pp80vfW joM3tltWyH9/3BFC5UAYvIek1a3RtRPhubBesuWSkJLzrXgzDlTLIeYwqsetxNLIQVa3 uJqvTL1MaQIL82wx3GfXnVL9SrDc3mKI0vxsxFYtIy0HiUjqKp9Kgk1EaoWy64Y2Ou7f BSqyC1bcaNmUCFCX4VgixorXf/nWoE8MW+pL3B3a0aIi7QnxnZHKD9QmKdKyUPuyIywN hH7xgYr2d0rduOnrsgXQWdA3mh6vJBlNOLXyXrebnuW9i8P7p2CyUWaceDJShBAr0Ulf QlNw== X-Forwarded-Encrypted: i=1; AHgh+RohlIWD9i6rsFM6Xg8bX7bTMrVEUaMQeeNJd9SGeZ1ZI+Ffxb7j7Fg+3CUhamEZ5STdd9b8Nrpoa0FjFoU=@vger.kernel.org X-Gm-Message-State: AOJu0YyxGsjA4cIyxfY/hLvh4VIkyoyGACJ89B+xV2hXFW6Rka/5CjK7 ax+LTq61z2A66XnPPO7h73mOXr/dea17XVxbAzCiHplXZn75MaLBQP4m X-Gm-Gg: AR+sD13LpzeAdBo/X3prx7axZMpSRUp//vl9EbiQwgx36D1hBwsPWJw86TWx52jXwOs uqfTa5lZbchjNaszjn2Tu5FyLdYpBysHrBi6fHoLLB6yz/3h+L28fXjTyJK3kXYac0tRG32+Lju nuackPU0PMadZNwUp/O+bcBtoldRgk7ybtd6pH6GJmgjXjlPByuLBF/cQCqO/natE2OajxaZGUa 0mmUNXQJccWeytu2tu0WX5fW7ilji7TvCHGCEa4ocWAwGleppu4elXngTpjRkCkVA9Q7A78oLfz 1AakbJt3vPAs2gl/XjM1yCAhBKOSZ0EdolrQs0lOomfVSjPtO4sQpiVPONSc7VBQ2Ps92AG0MRa tLSxxyY0aQ9NL72QOudPmnKQDXv8sSS1bH3Ivs/HAISUELXYr3/APZIn+TL8qmKCUepynEPr0ZF 02TCIL35npHBPZG+cRgdYThvmNEAeKs2VLCr07ahyEkCn4KPFDsky3j1XxypAHk98= X-Received: by 2002:a17:90b:288d:b0:38f:26c7:165e with SMTP id 98e67ed59e1d1-39261ff3945mr30245873a91.9.1786385623771; Mon, 10 Aug 2026 11:13:43 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:13:43 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Logan Gunthorpe , Kelvin Cao Subject: [PATCH v3 34/34] dmaengine: switchtec: use channel BH helpers Date: Mon, 10 Aug 2026 11:09:35 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel descriptor completion tasklet with the shared dmaengine BH helpers. Client callbacks remain in softirq context while using the common scheduling and teardown mechanism. Signed-off-by: Allen Pais Reviewed-by: Logan Gunthorpe --- drivers/dma/switchtec_dma.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/dma/switchtec_dma.c b/drivers/dma/switchtec_dma.c index 71d9868ce613..849f1f2f8105 100644 --- a/drivers/dma/switchtec_dma.c +++ b/drivers/dma/switchtec_dma.c @@ -133,8 +133,6 @@ struct switchtec_dma_chan { /* Serialize hardware control register access */ spinlock_t hw_ctrl_lock; - struct tasklet_struct desc_task; - /* Serialize descriptor preparation */ spinlock_t submit_lock; bool ring_active; @@ -584,6 +582,7 @@ static void switchtec_dma_synchronize(struct dma_chan *chan) int rc; + dmaengine_kill_bh(chan); switchtec_dma_abort_desc(swdma_chan, 1); rc = enable_channel(swdma_chan); @@ -820,9 +819,10 @@ static int switchtec_dma_resume(struct dma_chan *chan) return ret; } -static void switchtec_dma_desc_task(unsigned long data) +static void switchtec_dma_desc_task(struct dma_chan *chan) { - struct switchtec_dma_chan *swdma_chan = (void *)data; + struct switchtec_dma_chan *swdma_chan = + container_of(chan, struct switchtec_dma_chan, dma_chan); switchtec_dma_cleanup_completed(swdma_chan); } @@ -832,7 +832,7 @@ static irqreturn_t switchtec_dma_isr(int irq, void *chan) struct switchtec_dma_chan *swdma_chan = chan; if (swdma_chan->comp_ring_active) - tasklet_schedule(&swdma_chan->desc_task); + dmaengine_schedule_bh(&swdma_chan->dma_chan); return IRQ_HANDLED; } @@ -1041,6 +1041,7 @@ static void switchtec_dma_free_chan_resources(struct dma_chan *chan) spin_unlock_bh(&swdma_chan->complete_lock); switchtec_dma_chan_stop(swdma_chan); + dmaengine_kill_bh(chan); switchtec_dma_abort_desc(swdma_chan, 0); switchtec_dma_free_desc(swdma_chan); @@ -1067,8 +1068,6 @@ static int switchtec_dma_chan_init(struct switchtec_dma_dev *swdma_dev, spin_lock_init(&swdma_chan->hw_ctrl_lock); spin_lock_init(&swdma_chan->submit_lock); spin_lock_init(&swdma_chan->complete_lock); - tasklet_init(&swdma_chan->desc_task, switchtec_dma_desc_task, - (unsigned long)swdma_chan); swdma_chan->mmio_chan_fw = swdma_dev->bar + SWITCHTEC_DMAC_CHAN_CFG_STS_OFFSET + @@ -1116,6 +1115,7 @@ static int switchtec_dma_chan_init(struct switchtec_dma_dev *swdma_dev, chan = &swdma_chan->dma_chan; chan->device = dma; dma_cookie_init(chan); + dmaengine_init_bh(chan, switchtec_dma_desc_task); list_add_tail(&chan->device_node, &dma->channels); @@ -1138,7 +1138,7 @@ static int switchtec_dma_chan_free(struct pci_dev *pdev, spin_unlock_bh(&swdma_chan->complete_lock); pci_free_irq(pdev, swdma_chan->irq, swdma_chan); - tasklet_kill(&swdma_chan->desc_task); + dmaengine_kill_bh(&swdma_chan->dma_chan); switchtec_dma_chan_stop(swdma_chan); -- 2.43.0