From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C0DC4742C for ; Mon, 2 Nov 2020 20:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83DCE22268 for ; Mon, 2 Nov 2020 20:06:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="siNHqjmb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbgKBUGd (ORCPT ); Mon, 2 Nov 2020 15:06:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbgKBUGZ (ORCPT ); Mon, 2 Nov 2020 15:06:25 -0500 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0687C0617A6 for ; Mon, 2 Nov 2020 12:06:24 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id t11so15519703edj.13 for ; Mon, 02 Nov 2020 12:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=w3IRnJzG4XjUcIM6h66eH4WlctfkNHefOPDkKyf49Dc=; b=siNHqjmbla66+WUg+oZsw0diCCWy6NqAWJ4FQla7ocOXGqqP9CWNK3eH/fG65GwntQ FzbcB3xTlxGRA8YiXdtz1eQ3wrFIczsrJUibOqgPAukv+W+2L0oPtreXtpGYNqP/PgPe JyiWGuo3rSPJ6oDzPLR/tIcLfupMn6pPFUO+Evzj1AzYOIHM7SKacjXgKhhI6ekI3fz1 A8+GRwTgok1eLjJox3XHgqcZc5HxLR+k9Ldx8KgdIc8qmpJKfUVG5otxonCHMh026h6h +v5+h4qN8oqsnn+Lyh48SGqxTgsHbgC2G21BAwBuCKkjOsMbXt/7pu3nW9w5JEyDA6EF Ixxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=w3IRnJzG4XjUcIM6h66eH4WlctfkNHefOPDkKyf49Dc=; b=mUIPmPIKkFqva/tI+ihsytN9SHoJs1bRS0tU7wFo+PX+F/pLQWLgkv4ssX56G6aUtk 6GLm7cfBGt5exBmvkAUakGrJ0d77fNP3n1+eDuLmxm7f64IVpUQDc1RHxsoIh3q3ZBjr 3sZGaKrQU0TGFKEvoOEmpuUdS3zpy45PinLbwr5jpUgc0pO88JWoJ6Bykb79uqv0sMAF 2hFoOiQZMsNNw5oyg5rqamX7kh++JdrRSp3UDrzVtRZY4Vki/wv9GtmXaURsEJPR2J3L obSBB5MtfGSpsXqhiSKWn+9WTfBk1ydeLmFKidRyDDwd/0SddpOBRSvJakDtYzfwEMYE halQ== X-Gm-Message-State: AOAM532Nun2N2t2BzWYgRI5C5R9aLhgGJJn48q1rYVfzNE2S6qWSsUJi OKq5k0r72PfkQ1kiUDfkRwU= X-Google-Smtp-Source: ABdhPJy0aMGn1kELGS+uke5nHRhUK4NXtI5kkC7cUQTLJaWJHBrr8+w/qfFLOHaR/k37qH8hWGwrew== X-Received: by 2002:a50:88e5:: with SMTP id d92mr18507918edd.145.1604347583544; Mon, 02 Nov 2020 12:06:23 -0800 (PST) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id c3sm10752877edl.60.2020.11.02.12.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2020 12:06:22 -0800 (PST) Reply-To: christian.koenig@amd.com Subject: Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL To: Alex Deucher , Deepak R Varma Cc: David Airlie , Greg KH , LKML , Maling list - DRI developers , Melissa Wen , amd-gfx list , Daniel Vetter , Daniel Vetter , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20201102184147.GA42288@localhost> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Mon, 2 Nov 2020 21:06:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 02.11.20 um 20:43 schrieb Alex Deucher: > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: >> Initializing global variable to 0 or NULL is not necessary and should >> be avoided. Issue reported by checkpatch script as: >> ERROR: do not initialise globals to 0 (or NULL). > I agree that this is technically correct, but a lot of people don't > seem to know that so we get a lot of comments about this code for the > variables that are not explicitly set. Seems less confusing to > initialize them even if it not necessary. I don't have a particularly > strong opinion on it however. Agree with Alex. Especially for the module parameters we should have a explicit init value for documentation purposes, even when it is 0. Christian. > > Alex > >> Signed-off-by: Deepak R Varma >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 46 ++++++++++++------------- >> drivers/gpu/drm/amd/amdgpu/atom.c | 4 +-- >> 2 files changed, 25 insertions(+), 25 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> index 8ab6126ff70c..6de94c46bc91 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> @@ -94,16 +94,16 @@ >> #define KMS_DRIVER_MINOR 40 >> #define KMS_DRIVER_PATCHLEVEL 0 >> >> -int amdgpu_vram_limit = 0; >> -int amdgpu_vis_vram_limit = 0; >> +int amdgpu_vram_limit; >> +int amdgpu_vis_vram_limit; >> int amdgpu_gart_size = -1; /* auto */ >> int amdgpu_gtt_size = -1; /* auto */ >> int amdgpu_moverate = -1; /* auto */ >> -int amdgpu_benchmarking = 0; >> -int amdgpu_testing = 0; >> +int amdgpu_benchmarking; >> +int amdgpu_testing; >> int amdgpu_audio = -1; >> -int amdgpu_disp_priority = 0; >> -int amdgpu_hw_i2c = 0; >> +int amdgpu_disp_priority; >> +int amdgpu_hw_i2c; >> int amdgpu_pcie_gen2 = -1; >> int amdgpu_msi = -1; >> char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENGTH]; >> @@ -113,43 +113,43 @@ int amdgpu_aspm = -1; >> int amdgpu_runtime_pm = -1; >> uint amdgpu_ip_block_mask = 0xffffffff; >> int amdgpu_bapm = -1; >> -int amdgpu_deep_color = 0; >> +int amdgpu_deep_color; >> int amdgpu_vm_size = -1; >> int amdgpu_vm_fragment_size = -1; >> int amdgpu_vm_block_size = -1; >> -int amdgpu_vm_fault_stop = 0; >> -int amdgpu_vm_debug = 0; >> +int amdgpu_vm_fault_stop; >> +int amdgpu_vm_debug; >> int amdgpu_vm_update_mode = -1; >> -int amdgpu_exp_hw_support = 0; >> +int amdgpu_exp_hw_support; >> int amdgpu_dc = -1; >> int amdgpu_sched_jobs = 32; >> int amdgpu_sched_hw_submission = 2; >> -uint amdgpu_pcie_gen_cap = 0; >> -uint amdgpu_pcie_lane_cap = 0; >> +uint amdgpu_pcie_gen_cap; >> +uint amdgpu_pcie_lane_cap; >> uint amdgpu_cg_mask = 0xffffffff; >> uint amdgpu_pg_mask = 0xffffffff; >> uint amdgpu_sdma_phase_quantum = 32; >> -char *amdgpu_disable_cu = NULL; >> -char *amdgpu_virtual_display = NULL; >> +char *amdgpu_disable_cu; >> +char *amdgpu_virtual_display; >> /* OverDrive(bit 14) disabled by default*/ >> uint amdgpu_pp_feature_mask = 0xffffbfff; >> -uint amdgpu_force_long_training = 0; >> -int amdgpu_job_hang_limit = 0; >> +uint amdgpu_force_long_training; >> +int amdgpu_job_hang_limit; >> int amdgpu_lbpw = -1; >> int amdgpu_compute_multipipe = -1; >> int amdgpu_gpu_recovery = -1; /* auto */ >> -int amdgpu_emu_mode = 0; >> -uint amdgpu_smu_memory_pool_size = 0; >> +int amdgpu_emu_mode; >> +uint amdgpu_smu_memory_pool_size; >> /* FBC (bit 0) disabled by default*/ >> -uint amdgpu_dc_feature_mask = 0; >> -uint amdgpu_dc_debug_mask = 0; >> +uint amdgpu_dc_feature_mask; >> +uint amdgpu_dc_debug_mask; >> int amdgpu_async_gfx_ring = 1; >> -int amdgpu_mcbp = 0; >> +int amdgpu_mcbp; >> int amdgpu_discovery = -1; >> -int amdgpu_mes = 0; >> +int amdgpu_mes; >> int amdgpu_noretry = -1; >> int amdgpu_force_asic_type = -1; >> -int amdgpu_tmz = 0; >> +int amdgpu_tmz; >> int amdgpu_reset_method = -1; /* auto */ >> int amdgpu_num_kcq = -1; >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c b/drivers/gpu/drm/amd/amdgpu/atom.c >> index 696e97ab77eb..46c00ee580b1 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/atom.c >> +++ b/drivers/gpu/drm/amd/amdgpu/atom.c >> @@ -66,7 +66,7 @@ typedef struct { >> bool abort; >> } atom_exec_context; >> >> -int amdgpu_atom_debug = 0; >> +int amdgpu_atom_debug; >> static int amdgpu_atom_execute_table_locked(struct atom_context *ctx, int index, uint32_t * params); >> int amdgpu_atom_execute_table(struct atom_context *ctx, int index, uint32_t * params); >> >> @@ -88,7 +88,7 @@ static int atom_dst_to_src[8][4] = { >> }; >> static int atom_def_dst[8] = { 0, 0, 1, 2, 0, 1, 2, 3 }; >> >> -static int debug_depth = 0; >> +static int debug_depth; >> #ifdef ATOM_DEBUG >> static void debug_print_spaces(int n) >> { >> -- >> 2.25.1 >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx