mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Abdun Nihaal <abdun.nihaal@gmail.com>,
	linux-wireless@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Johannes Berg <johannes@sipsolutions.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Alexey Khoroshilov <khoroshilov@ispras.ru>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	Erick Archer <erick.archer@outlook.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Kalle Valo <kvalo@kernel.org>,
	Miri Korenblit <miriam.rachel.korenblit@intel.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: [PATCH] Fix use after free access in at76_disconnect
Date: Sun, 30 Mar 2025 13:53:11 +0200	[thread overview]
Message-ID: <c9185d57-0c01-4f8b-80a9-dbdf5062586a@web.de> (raw)
In-Reply-To: <20250330093320.22293-1-abdun.nihaal@gmail.com>

> The memory pointed to by priv is freed at the end of at76_delete_device
> function (using ieee80211_free_hw). But the code then accesses the udev
> field of the freed object to put the USB device. This may also lead to a
> memory leak of the usb device. Fix this by using udev from interface.

* A corresponding subsystem specification can usually be helpful here.
  https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/net/wireless/atmel/at76c50x-usb.c?h=next-20250328

* Would you like to append parentheses to any function names?


Regards,
Markus

      reply	other threads:[~2025-03-30 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-30  9:33 Abdun Nihaal
2025-03-30 11:53 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9185d57-0c01-4f8b-80a9-dbdf5062586a@web.de \
    --to=markus.elfring@web.de \
    --cc=abdun.nihaal@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=emmanuel.grumbach@intel.com \
    --cc=erick.archer@outlook.com \
    --cc=johannes@sipsolutions.net \
    --cc=khoroshilov@ispras.ru \
    --cc=kvalo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®