From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751909AbdG2VMG (ORCPT <rfc822;w@1wt.eu>);
        Sat, 29 Jul 2017 17:12:06 -0400
Received: from mail-lf0-f42.google.com ([209.85.215.42]:33433 "EHLO
        mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751543AbdG2VME (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 29 Jul 2017 17:12:04 -0400
Subject: Re: [PATCH] ti-msgmgr: fix of_irq_get_byname() error check
To: Jassi Brar <jassisinghbrar@gmail.com>, linux-kernel@vger.kernel.org
References: <20170729210444.190235497@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Organization: Cogent Embedded
Message-ID: <c918dd3c-8112-f330-831e-3bbc51ec525c@cogentembedded.com>
Date: Sun, 30 Jul 2017 00:12:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170729210444.190235497@cogentembedded.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/30/2017 12:04 AM, Sergei Shtylyov wrote:

> of_irq_get_byname() may  return 0 as well as negative error number on
> failure,  while the driver only checks for the negative values. The driver
> would then call request_irq(0, ...) in ti_msgmgr_queue_startup() and never
> get a valid channel interrupt.
>
> Check for 'qinst->irq <= 0' instead and return -ENXIO from
> ti_msgmgr_queue_setup() and this fail the driver's probe iff

   s/this/thus/, sorry for the typo.

> of_irq_get_byname() returned 0.
>
> Fixes: aace66b170ce ("mailbox: Introduce TI message manager driver")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]

MBR, Sergei