From: Markus Elfring <Markus.Elfring@web.de>
To: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, nbd@other.debian.org,
stable@kernel.org,
syzbot+934037347002901b8d2a@syzkaller.appspotmail.com,
Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] nbd: Fix memory leak from krealloc() if another allocation fails
Date: Fri, 10 Apr 2020 21:08:50 +0200 [thread overview]
Message-ID: <c91c88ef-0600-4733-d301-de1e2e62cb94@web.de> (raw)
> syzkaller reports a memory leak when injecting allocation failures:
…
> as then config->num_connections is not incremented and the cleanup code
> freeing config->socks is skipped. Just make it run always.
How do you think about to add the tag “Fixes” for the final change description?
Regards,
Markus
next reply other threads:[~2020-04-10 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 19:08 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-10 12:29 Tuomas Tynkkynen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91c88ef-0600-4733-d301-de1e2e62cb94@web.de \
--to=markus.elfring@web.de \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=stable@kernel.org \
--cc=syzbot+934037347002901b8d2a@syzkaller.appspotmail.com \
--cc=tuomas.tynkkynen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®