From: Mark Brown <broonie@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/7] regulator: Handle system-critical under-voltage events
Date: Wed, 25 Oct 2023 13:47:38 +0100 [thread overview]
Message-ID: <c91e53ee-2054-49d0-b554-ab96a5f68b19@sirena.org.uk> (raw)
In-Reply-To: <20231025084614.3092295-3-o.rempel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 504 bytes --]
On Wed, Oct 25, 2023 at 10:46:09AM +0200, Oleksij Rempel wrote:
> + if (rdev->constraints->system_critical &&
> + event == REGULATOR_EVENT_UNDER_VOLTAGE)
> + hw_protection_shutdown("System critical voltage drop detected",
> + REGULATOR_DEF_EMERG_SHUTDWN_TMO);
> +
This should probably be a switch statement for the event and also handle
REGULATOR_EVENT_FAIL, possibly other errors this would also be
appropriate handling but it's less immediately obvious and we can
always extend later.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-10-25 12:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 8:46 [PATCH v3 0/7] regulator: add under-voltage support Oleksij Rempel
2023-10-25 8:46 ` [PATCH v3 1/7] regulator: dt-bindings: Add system-critical-regulator property Oleksij Rempel
2023-10-25 8:46 ` [PATCH v3 2/7] regulator: Handle system-critical under-voltage events Oleksij Rempel
2023-10-25 12:47 ` Mark Brown [this message]
2023-10-25 8:46 ` [PATCH v3 3/7] regulator: dt-bindings: fixed-regulator: Add under-voltage interrupt support Oleksij Rempel
2023-10-25 8:46 ` [PATCH v3 4/7] regulator: dt-bindings: whitelist system-critical-regulator property for fixed-regulator Oleksij Rempel
2023-10-25 12:41 ` Mark Brown
2023-10-26 7:10 ` Oleksij Rempel
2023-10-25 8:46 ` [PATCH v3 5/7] regulator: fixed: add support for under-voltage IRQ Oleksij Rempel
2023-10-25 8:46 ` [PATCH v3 6/7] regulator: dt-bindings: Add regulator-uv-survival-time-ms property Oleksij Rempel
2023-10-27 20:35 ` Rob Herring
2023-10-25 8:46 ` [PATCH v3 7/7] regulator: Implement uv_survival_time for handling under-voltage events Oleksij Rempel
2023-10-25 17:47 ` (subset) [PATCH v3 0/7] regulator: add under-voltage support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91e53ee-2054-49d0-b554-ab96a5f68b19@sirena.org.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®