From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C112C64E8A for ; Wed, 2 Dec 2020 13:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1ACC2075A for ; Wed, 2 Dec 2020 13:34:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729802AbgLBNeo (ORCPT ); Wed, 2 Dec 2020 08:34:44 -0500 Received: from foss.arm.com ([217.140.110.172]:39776 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727398AbgLBNen (ORCPT ); Wed, 2 Dec 2020 08:34:43 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E083E30E; Wed, 2 Dec 2020 05:33:56 -0800 (PST) Received: from [10.57.0.85] (unknown [10.57.0.85]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4DCB93F718; Wed, 2 Dec 2020 05:33:54 -0800 (PST) Subject: Re: [PATCH v4 2/4] Documentation/powercap/dtpm: Add documentation for dtpm To: Daniel Lezcano Cc: rjw@rjwysocki.net, ulf.hansson@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Thara Gopinath , Lina Iyer , Ram Chandrasekar , Zhang Rui , Jonathan Corbet , Len Brown , Pavel Machek References: <20201201192801.27607-1-daniel.lezcano@linaro.org> <20201201192801.27607-3-daniel.lezcano@linaro.org> From: Lukasz Luba Message-ID: Date: Wed, 2 Dec 2020 13:33:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20201201192801.27607-3-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Only small issues found. The output build looks OK. The content LGTM. On 12/1/20 7:27 PM, Daniel Lezcano wrote: > The dynamic thermal and power management is a technique to dynamically > adjust the power consumption of different devices in order to ensure a > global thermal constraint. > > An userspace daemon is usually monitoring the temperature and the > power to take immediate action on the device. > > The DTPM framework provides an unified API to userspace to act on the > power. > > Document this framework. > > Cc: Thara Gopinath > Cc: Lina Iyer > Cc: Ram Chandrasekar > Cc: Zhang Rui > Cc: Jonathan Corbet > Signed-off-by: Daniel Lezcano > --- > Documentation/power/index.rst | 1 + > Documentation/power/powercap/dtpm.rst | 210 ++++++++++++++++++++++++++ > 2 files changed, 211 insertions(+) > create mode 100644 Documentation/power/powercap/dtpm.rst > > diff --git a/Documentation/power/index.rst b/Documentation/power/index.rst > index ced8a8007434..a0f5244fb427 100644 > --- a/Documentation/power/index.rst > +++ b/Documentation/power/index.rst > @@ -30,6 +30,7 @@ Power Management > userland-swsusp > > powercap/powercap > + powercap/dtpm > > regulator/consumer > regulator/design > diff --git a/Documentation/power/powercap/dtpm.rst b/Documentation/power/powercap/dtpm.rst > new file mode 100644 > index 000000000000..ca095ef4b887 > --- /dev/null > +++ b/Documentation/power/powercap/dtpm.rst > @@ -0,0 +1,210 @@ Probably missing SPDX? .. SPDX-License-Identifier: GPL-2.0-only > +========================================== > +Dynamic Thermal Power Management framework > +========================================== > + > +On the embedded world, the complexity of the SoC leads to an > +increasing number of hotspots which need to be monitored and mitigated > +as a whole in order to prevent the temperature to go above the > +normative and legally stated 'skin temperature'. > + > +Another aspect is to sustain the performance for a given power budget, > +for example virtual reality where the user can feel dizziness if the > +performance is capped while a big CPU is processing something else. Or > +reduce the battery charging because the dissipated power is too high > +compared with the power consumed by other devices. > + > +The userspace is the most adequate place to dynamically act on the I have compared with PowerCap description and they use 'user space'. I am not an expert in grammar, but maybe DTPM should also use it. > +different devices by limiting their power given an application > +profile: it has the knowledge of the platform. > + > +The Dynamic Thermal Power Management (DTPM) is a technique acting on > +the device power by limiting and/or balancing a power budget among > +different devices. > + > +The DTPM framework provides an unified interface to act on the > +device power. > + > +Overview > +======== > + > +The DTPM framework relies on the powercap framework to create the > +powercap entries in the sysfs directory and implement the backend > +driver to do the connection with the power manageable device. > + > +The DTPM is a tree representation describing the power constraints > +shared between devices, not their physical positions. > + > +The nodes of the tree are a virtual description aggregating the power > +characteristics of the children nodes and their power limitations. > + > +The leaves of the tree are the real power manageable devices. > + > +For instance:: > + > + SoC > + | > + `-- pkg > + | > + |-- pd0 (cpu0-3) > + | > + `-- pd1 (cpu4-5) > + > +The pkg power will be the sum of pd0 and pd1 power numbers:: > + > + SoC (400mW - 3100mW) > + | > + `-- pkg (400mW - 3100mW) > + | > + |-- pd0 (100mW - 700mW) > + | > + `-- pd1 (300mW - 2400mW) > + > +When the nodes are inserted in the tree, their power characteristics are propagated to the parents:: > + > + SoC (600mW - 5900mW) > + | > + |-- pkg (400mW - 3100mW) > + | | > + | |-- pd0 (100mW - 700mW) > + | | > + | `-- pd1 (300mW - 2400mW) > + | > + `-- pd2 (200mW - 2800mW) > + > +Each node have a weight on a 2^10 basis reflecting the percentage of power consumption along the siblings:: > + > + SoC (w=1024) > + | > + |-- pkg (w=538) > + | | > + | |-- pd0 (w=231) > + | | > + | `-- pd1 (w=794) > + | > + `-- pd2 (w=486) > + > + Note the sum of weights at the same level are equal to 1024. This sentence landed inside the rectangle with the tree above. Just pointing out, because I don't know if it was by design or not. > + > +When a power limitation is applied to a node, then it is distributed along the children given their weights. For example, if we set a power limitation of 3200mW at the 'SoC' root node, the resulting tree will be:: > + > + SoC (w=1024) <--- power_limit = 3200mW > + | > + |-- pkg (w=538) --> power_limit = 1681mW > + | | > + | |-- pd0 (w=231) --> power_limit = 378mW > + | | > + | `-- pd1 (w=794) --> power_limit = 1303mW > + | > + `-- pd2 (w=486) --> power_limit = 1519mW > + > + > +Flat description > +---------------- > + > +A root node is created and it is the parent of all the nodes. This > +description is the simplest one and it is supposed to give to > +userspace a flat representation of all the devices supporting the > +power limitation without any power limitation distribution. > + > +Hierarchical description > +------------------------ > + > +The different devices supporting the power limitation are represented > +hierarchically. There is one root node, all intermediate nodes are > +grouping the child nodes which can be intermediate nodes also or real > +devices. > + > +The intermediate nodes aggregate the power information and allows to > +set the power limit given the weight of the nodes. > + > +Userspace API > +============= > + > +As stated in the overview, the DTPM framework is built on top of the > +powercap framework. Thus the sysfs interface is the same, please refer > +to the powercap documentation for further details. > + > + * power_uw: Instantaneous power consumption. If the node is an > + intermediate node, then the power consumption will be the sum of all > + children power consumption. > + > + * max_power_range_uw: The power range resulting of the maximum power > + minus the minimum power. > + > + * name: The name of the node. This is implementation dependant. Even s/dependant/dependent/ > + if it is not recommended for the userspace, several nodes can have > + the same name. > + > + * constraint_X_name: The name of the constraint. > + > + * constraint_X_max_power_uw: The maximum power limit to be applicable > + to the node. > + > + * constraint_X_power_limit_uw: The power limit to be applied to the > + node. If the value contained in constraint_X_max_power_uw is set, > + the constraint will be removed. > + > + * constraint_X_time_window_us: The meaning of this file will depend > + on the constraint number. > + > +Constraints > +----------- > + > + * Constraint 0: The power limitation is immediately applied, without > + limitation in time. > + > +Kernel API > +========== > + > +Overview > +-------- > + > +The DTPM framework has no power limiting backend support. It is > +generic and provides a set of API to let the different drivers to > +implement the backend part for the power limitation and create a the s/a the/the/ > +power constraints tree. > + > +It is up to the platform to provide the initialization function to > +allocate and link the different nodes of the tree. > + > +A special macro has the role of declaring a node and the corresponding > +initialization function via a description structure. This one contains > +an optional parent field allowing to hook different devices to an > +already existing tree at boot time. > + > +For instance:: > + > + struct dtpm_descr my_descr = { > + .name = "my_name", > + .init = my_init_func, > + }; > + > + DTPM_DECLARE(my_descr); > + > +The nodes of the DTPM tree are described with dtpm structure. The > +steps to add a new power limitable device is done in three steps: > + > + * Allocate the dtpm node > + * Set the power number of the dtpm node > + * Register the dtpm node > + > +The registration of the dtpm node is done with the powercap > +ops. Basically, it must implements the callbacks to get and set the > +power and the limit. > + > +Alternatively, if the node to be inserted is an intermediate one, then > +a simple function to insert it as a future parent is available. > + > +If a device has its power characteristics changing, then the tree must > +be updated with the new power numbers and weights. > + > +Nomenclature > +------------ > + > + * dtpm_alloc() : Allocate and initialize a dtpm structure > + > + * dtpm_register() : Add the dtpm node to the tree > + > + * dtpm_unregister() : Remove the dtpm node from the tree > + > + * dtpm_update_power() : Update the power characteristics of the dtpm node > When you fix these small issues, feel free to add: Reviewed-by: Lukasz Luba Regards, Lukasz