From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D90B2DA771 for ; Sat, 7 Feb 2026 19:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770494396; cv=none; b=szNDkpg73uhvXp2jpo50DHBAdeNCtiv4KhdoTa8hb/LUozzVqAZ5VQWB2D8qito4CuAMxZlA54CYTB+dsTCqh58XLVO5J6tz1xMFSL2+RZ/MBfoWZFPgry1Xdqiwk/UaUInPE88kB01BWpWYdfxQirUl6mJcx1qLMc/KcNPE/dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770494396; c=relaxed/simple; bh=+Xr8rYTGybFifeFwE8v5Ha3sigxdFru5hwVghREHhjc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HcQVw8wnXfHsNyqCvewJTKh2cckLsrk8Oa6r3ysrN4CM0OQ1JemiJbI5wASS4ITTWmRYgVTiuAaAX0LCh0exVyNsduufsxEu/73gygd7Bly1NS7hbxHvcfasJQlEektp5z+0itQP63Dum3SxEj+V4hg/JPyyL0XOvLj4bEN/bMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L/GWVAlI; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L/GWVAlI" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so42526805e9.1 for ; Sat, 07 Feb 2026 11:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770494394; x=1771099194; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6OXJ4VqhuGT/CfXgMjy4IV1o4Ev+iXuopy/eJZiNHX4=; b=L/GWVAlI9NWBUh/GGRrUPo+0uccBexf9259PkTtDRtzlAXx0oP32KkrL8TaCaHkgWr AClBOtuWtT+TMk5BHVeIwN+bQHxJoIhFYmkWAK+8kcZvLDKNw8zCy8SGNMjU1DMb2hB7 QmZqKwX4o9AHnIfWu0GzqbHGULnQw61t+3MaStuAByYEOlZbhFBubVFzqf3IG8uOZRPd GH27tO5iSR5eYxsBFvorqhAgW8+YMmOPKPv+PjModA0lxrVQl5aJYOs9pwt+q7I2tEO8 jELJ+JsRCZrhHJI3u2eZThlyWdt0PHbpDaxZb2YATeTUqfSMgxxyNj2tgizLCwmFYpZt bXGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770494394; x=1771099194; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6OXJ4VqhuGT/CfXgMjy4IV1o4Ev+iXuopy/eJZiNHX4=; b=rWWmGcRhY83gNUaNqsi/rV35VG3m8auRTMAwZbdSHCwL85ebu3mkJdnmP3zK9EAKd0 2fxlOCiKMK4E1hsy066d9KUfyrB5dYtMCHrjP1+kqZj8n4ZXbS+nDfFmAA2lGksmV5iz Q4FaECFY5imCwMSPPrgGLTsG9dkBs7oLadsEZZbR071ip7VglFVydktlQJdO44wf8h5N 1N+8lQerzrILPila+YvfxX+ZB1eF2ovM65gXCFPHM90Ufr/alyECGvP0+L4xl31Lewnk bjH9g+p7gQnY9bg058aPVM2CT8mdgugTGGxAmB/8yAvb5UTd/BbWfQCg11RkmqlduSbV pcpg== X-Forwarded-Encrypted: i=1; AJvYcCUF0mN2gpmZRpf8AC4xHVfMyGU49B/33vrVxHMHeIwxQLmfvRHeKri6mO11Vc3hl7lRPhZY7JeVduiPrjs=@vger.kernel.org X-Gm-Message-State: AOJu0YyY4HtpTnpnVvoDr7Gh9+0km9EbKo5vTfoMf2jnu461a5p9geMV Hefbn87nK3tPWxg6yHYr3lvwUxzaBoJwnVnqe0TpUCECmNkjhMMO7Wg4 X-Gm-Gg: AZuq6aITniOalGKqvg8AQCmFEOJG4vvcQqB5bCJef7CEcpF+WoQZwtDI2z/P1dr2Lmx K73dYgH5OEwDpfjrroSz/uGDChBYutz8RsrSQPk7C29KPfCj8PgMkdeMNQcjVWbfzcOAtgtUdC4 jG1BPeN2iJ2lfSjs11Bts39Q8h4BqOvrJqOEyfktAfZ2jO8FdKR79YjYBDjxS3jQq93Cwdy7Zmc z8LMbkdKS6MKrTCJw2Qrnc25p4qtoHOk7cdAy1oGMCLECg/cVX4p+LBTI6+Hj4LpOQYO4D+EpO+ XxezigKRDnA6l97m1txdmeKSXAEJN2Lam7sAtJH09Vtc6/Kk1DvPWXhc5Eusog3WQRHXOvPHEn0 mjyNJuYugOhHh3J9GMI2QfudeA4jt8g+bpFlOSNzdlYotyWMIhwPZS0hqo52BeEi5UbWoQOu2ci pw2TneZ26MiDMPDYUNn+8AlD+Gw7sJO6dqdZAvtpb0wxmt9QVzbrX80oQ2up53dKkN1zXaIbhx5 atN2Lf38O4oQrc= X-Received: by 2002:a05:600c:4fc8:b0:46f:c55a:5a8d with SMTP id 5b1f17b1804b1-483201dc396mr100885895e9.4.1770494393810; Sat, 07 Feb 2026 11:59:53 -0800 (PST) Received: from ?IPV6:2a02:6b6f:e752:9400:18cf:c773:ee86:c436? ([2a02:6b6f:e752:9400:18cf:c773:ee86:c436]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48320719b8fsm143031285e9.9.2026.02.07.11.59.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Feb 2026 11:59:52 -0800 (PST) Message-ID: Date: Sat, 7 Feb 2026 19:59:51 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 30/31] mm: memcontrol: eliminate the problem of dying memory cgroup for LRU folios Content-Language: en-GB To: Qi Zheng , hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng References: <9e332cc8436b6092dd6ef9c2d5f69072bb38eaf6.1770279888.git.zhengqi.arch@bytedance.com> From: Usama Arif In-Reply-To: <9e332cc8436b6092dd6ef9c2d5f69072bb38eaf6.1770279888.git.zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e7d4e4ff411b6..0e0efaa511d3d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -247,11 +247,25 @@ static inline void reparent_state_local(struct mem_cgroup *memcg, struct mem_cgr > > static inline void reparent_locks(struct mem_cgroup *memcg, struct mem_cgroup *parent) > { > + int nid, nest = 0; > + > spin_lock_irq(&objcg_lock); > + for_each_node(nid) { > + spin_lock_nested(&mem_cgroup_lruvec(memcg, > + NODE_DATA(nid))->lru_lock, nest++); > + spin_lock_nested(&mem_cgroup_lruvec(parent, > + NODE_DATA(nid))->lru_lock, nest++); > + } > } > mWould this break lockdep on more than 4 NUMA nodes as MAX_LOCKDEP_SUBCLASSES = 8 and 2 locks are being acquired per node. > static inline void reparent_unlocks(struct mem_cgroup *memcg, struct mem_cgroup *parent) > { > + int nid; > + > + for_each_node(nid) { > + spin_unlock(&mem_cgroup_lruvec(parent, NODE_DATA(nid))->lru_lock); > + spin_unlock(&mem_cgroup_lruvec(memcg, NODE_DATA(nid))->lru_lock); > + } > spin_unlock_irq(&objcg_lock); > }