From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC95C433F5 for ; Wed, 27 Apr 2022 22:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236023AbiD0WU2 (ORCPT ); Wed, 27 Apr 2022 18:20:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbiD0WU0 (ORCPT ); Wed, 27 Apr 2022 18:20:26 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5CCA496A8; Wed, 27 Apr 2022 15:17:13 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 4090B2224E; Thu, 28 Apr 2022 00:17:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1651097832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZxv+ND74jZFakl/W5jjwXzeN0ncd5RrSaX/5eCEVgA=; b=B67NSfE4oeqpT1dv3/7Wx1liIee+2qOveDspLbFHeBGtZUqKWhOlvbcBalqaA5+6MZR4Yc e+t0SkNIIb3wLH46nZmPtN9XcXj1O8ecvTAKo0SJJ6a1xNRpUkexqYzE1JlIhhVg2Pkj6k shA3Vnp29YarqdbrTqqYb/02hYT1ly0= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 28 Apr 2022 00:17:12 +0200 From: Michael Walle To: Florian Fainelli Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1 3/3] net: phy: micrel: add coma mode GPIO In-Reply-To: References: <20220427214406.1348872-1-michael@walle.cc> <20220427214406.1348872-4-michael@walle.cc> <652a5d64-4f06-7ac8-a792-df0a4b43686f@gmail.com> <635fd80542e089722e506bba0ff390ff@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-04-28 00:12, schrieb Florian Fainelli: > On 4/27/22 15:08, Michael Walle wrote: >> Am 2022-04-28 00:06, schrieb Florian Fainelli: >>> On 4/27/2022 2:44 PM, Michael Walle wrote: >>>> The LAN8814 has a coma mode pin which puts the PHY into isolate and >>>> power-dowm mode. Unfortunately, the mode cannot be disabled by a >> s/dowm/down/ >> >>>> register. Usually, the input pin has a pull-up and connected to a >>>> GPIO >>>> which can then be used to disable the mode. Try to get the GPIO and >>>> deassert it. >>> >>> Poor choice of word, how about deep sleep, dormant, super isolate? >> >> Which one do you mean? Super isolate sounded like broadcom wording ;) > > Coma is not a great term to use IMHO. Yes Super isolate (tm) is a > Broadcom thing, and you can come out of super isolate mode with > register writes, so maybe not the best suggestion. I didn't come up with that name. It's all in the datasheets and it's actually already used grep for "COMA_MODE" in phy/mscc. (Yes on that one you can actually disable it with register access..). Even if it is not a great name (which I agree), I'd use the same naming as the datasheet and esp. the pin name. -michael