From: Joe Perches <joe@perches.com>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Madhumitha Prabakaran <madhumithabiw@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Emanuel Bennici <benniciemanuel78@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Hardik Singh Rathore <hardiksingh.k@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
viswanath.barenkala@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: core fix warning "Comparison to bool"
Date: Sun, 12 May 2019 09:59:42 -0700 [thread overview]
Message-ID: <c929d6ee3acd820fbd29a7eb639f0b565d15063f.camel@perches.com> (raw)
In-Reply-To: <20190512121923.GA28044@hari-Inspiron-1545>
On Sun, 2019-05-12 at 17:49 +0530, Hariprasad Kelam wrote:
> fix below issue reported by coccicheck
> drivers/staging/rtl8723bs/core/rtw_cmd.c:1741:7-17: WARNING: Comparison
> to bool
[]
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
[]
> @@ -1738,7 +1738,7 @@ static void rtw_chk_hi_queue_hdl(struct adapter *padapter)
> pstapriv->tim_bitmap &= ~BIT(0);
> pstapriv->sta_dz_bitmap &= ~BIT(0);
>
> - if (update_tim == true)
> + if (update_tim)
> update_beacon(padapter, _TIM_IE_, NULL, true);
> } else {/* re check again */
> rtw_chk_hi_queue_cmd(padapter);
There are dozens of these in this file and
even more in the subsystem.
$ git grep -P '(==|!=)\s*(true|false)' drivers/staging/rtl8723bs/core/rtw_cmd.c | wc -l
22
When you submit a patch for a single file,
at least please try to do all the instances
in the file.
prev parent reply other threads:[~2019-05-12 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 12:19 Hariprasad Kelam
2019-05-12 16:59 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c929d6ee3acd820fbd29a7eb639f0b565d15063f.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=benniciemanuel78@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hardiksingh.k@gmail.com \
--cc=hariprasad.kelam@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madhumithabiw@gmail.com \
--cc=viswanath.barenkala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®