From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8427C001E0 for ; Wed, 16 Aug 2023 06:19:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242088AbjHPGSo (ORCPT ); Wed, 16 Aug 2023 02:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242081AbjHPGSY (ORCPT ); Wed, 16 Aug 2023 02:18:24 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A97981BF7 for ; Tue, 15 Aug 2023 23:18:22 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fe2048c910so56893995e9.1 for ; Tue, 15 Aug 2023 23:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692166701; x=1692771501; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mx1UIYShAlyyGP0ErV9nIroDLEozIanzm7Ts9TKbkrM=; b=sGRsL/QwaCaMlCql1uvOL6IGh0E98/pBn3LrQQXZsTX8IqKKEWtEAB2CZwq+H668RF JbqBn8YtMPi6ldm/E8BbYohvY6iQa8T24TGbSt0iyICvjA2Z+TckZ/Z+jZOmX4mHKw8+ DiimN6PrAGcy8YoVTAylTFhDeKSOSIkwt8Yh2QK2IRHPksPknXZpTUvoZDcEIa8hgCTo WIaFh7qkGangROXZNy088IpQUAeeYFjHAMfXXOMX3iyL8Rmf98u8ZgHcufFlF6x64c8a 8cyCl0uN4/fNsetPTh/N4UANeU2pkXVVlOqppc2hh5I5zE+5Yxpdh+PCnfXNnYcwfnjG 34LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692166701; x=1692771501; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mx1UIYShAlyyGP0ErV9nIroDLEozIanzm7Ts9TKbkrM=; b=Y3r/BZc8UICiwkXr/J8S2qoMsHViOL+hEQGIbwmJrZpABfDScYgugr9KsvtXh4b0PZ J9cBnWI8gc17SBnlOmDDhYVtNbPzaQL/5j0g0TazkcHmnn9uUNZxzNbZBqgpBEd0mPyr BNhi1PRWQZHkay0TevWxk4ackJABwwOUtAgYXhr2nYFO2iA7D/qXci+tCO4XrWBUuKEV QA8tu/MyKxSt46ZFKNM90/NC3xK4BGTs0LsbXZa6JiK4kN80MKRROAZtnp0cK5Mxbl46 Ic+7ZGAh1aY2eww4wp8aN6e02aFtZbEyFt/2+a2c6QlCcqxh16mEwTtWpBvkMzkMWzS/ ToEw== X-Gm-Message-State: AOJu0Yy8YMYZ0OD+GtMGO2viVZWYHHX8bHgajv4UjVRU/RJH44zDrbq4 BEfq8wzHADfiTDJL3ejsRnGSCA== X-Google-Smtp-Source: AGHT+IE+Q/6wB3/7hbdxzeM5zH2YL/GCM/loFcZttKMzb+hJ56y2b4Px4vAxawaocigURv4jii3uIA== X-Received: by 2002:a5d:6386:0:b0:319:8b4d:5ec with SMTP id p6-20020a5d6386000000b003198b4d05ecmr797710wru.34.1692166701144; Tue, 15 Aug 2023 23:18:21 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id g6-20020adff3c6000000b003197869bcd7sm8630690wrp.13.2023.08.15.23.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 23:18:20 -0700 (PDT) Message-ID: Date: Wed, 16 Aug 2023 08:18:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree bindings Content-Language: en-US To: Sriranjani P , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, richardcochran@gmail.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, alim.akhtar@samsung.com, linux-fsd@tesla.com, pankaj.dubey@samsung.com, swathi.ks@samsung.com, ravi.patel@samsung.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230814112539.70453-1-sriranjani.p@samsung.com> <20230814112539.70453-2-sriranjani.p@samsung.com> <16eab776-07d4-3c31-7e82-444863303102@linaro.org> <000d01d9d006$a211d880$e6358980$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <000d01d9d006$a211d880$e6358980$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/2023 07:58, Sriranjani P wrote: >>> + >>> +allOf: >>> + - $ref: snps,dwmac.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: tesla,fsd-ethqos-4.21.yaml >> >> ? > > Will fix this to tesla,fsd-ethqos.yaml Test your patches before sending. REALLY TEST. > >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + clocks: >>> + minItems: 5 >> >> Why? I expect it to be specific. > > Sorry, I could not understood this comment. In FSD we have two instances of EQoS IP, one in PERIC block, which requires total 10 clocks to be configured and another instance exist in FSYS0 block which needs 5 clocks to be configured, so we kept minItems as 5 and maxItems as 10, but looks like latest items schema do not need maxItems entry so we will drop maxItems entry. In my understanding minItems still required so it should be kept with minimum number of clock requirements. No, the code is fine then. > >> >>> + maxItems: 10 >>> + >>> + clock-names: >>> + minItems: 5 >>> + maxItems: 10 >>> + items: >>> + - const: ptp_ref >>> + - const: master_bus >>> + - const: slave_bus >>> + - const: tx >>> + - const: rx >>> + - const: master2_bus >>> + - const: slave2_bus >>> + - const: eqos_rxclk_mux >>> + - const: eqos_phyrxclk >>> + - const: dout_peric_rgmii_clk >>> + >>> + fsd-rx-clock-skew: >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + items: >>> + - items: >>> + - description: phandle to the syscon node >>> + - description: offset of the control register >>> + description: >>> + Should be phandle/offset pair. The phandle to the syscon node. >>> + >>> + iommus: >>> + maxItems: 1 >>> + >>> + phy-mode: >>> + $ref: ethernet-controller.yaml#/properties/phy-connection-type >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >>> + - clocks >>> + - clock-names >>> + - rx-clock-skew >> >> Eee? Isn't it fsd-rx-clock-skew which anyway is not correct? > > Sorry, I missed to change this in DT schema before posting, I will make this to fsd-rx-clock-skew. Remember about vendor prefixes for every custom property. Best regards, Krzysztof