From: mengfanhui <mengfanhui@kylinos.cn>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: kbusch@kernel.org, axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-multipath: fix bogus request queue reference put
Date: Thu, 14 Mar 2024 14:13:39 +0800 [thread overview]
Message-ID: <c934831a-ec84-4ea4-a156-782880086ffe@kylinos.cn> (raw)
In-Reply-To: <20240117143952.GA27918@lst.de>
Purpose that to check if we ever added a live path (using
NVME_NS_HEAD_HAS_DISK flag) and if not, clear the disk->queue
reference.The purpose is to perform security checks and remove the disk.
在 2024/1/17 22:39, Christoph Hellwig 写道:
> On Wed, Jan 17, 2024 at 04:04:12PM +0200, Sagi Grimberg wrote:
>> How did you see this? disk->queue is allocated in blk_alloc_disk called
>> in nvme_mpath_alloc_disk... I don't understand how you saw the same
>> dereference that was addressed by this commit.
>
> This looks like a backport of an old patch of yours to a geriatric
> kernel to me..
next prev parent reply other threads:[~2024-03-14 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 6:50 mengfanhui
2024-01-17 14:04 ` Sagi Grimberg
2024-01-17 14:39 ` Christoph Hellwig
2024-03-14 6:13 ` mengfanhui [this message]
2024-03-17 7:33 ` Sagi Grimberg
2024-03-20 2:03 ` mengfanhui
2024-03-20 9:06 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c934831a-ec84-4ea4-a156-782880086ffe@kylinos.cn \
--to=mengfanhui@kylinos.cn \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®