From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B9531F561D for ; Tue, 5 Aug 2025 12:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754396799; cv=none; b=pIC+JNn2K/BtF2xqfIqRoYU9RSjBHpu4ba14CxJofAllb6q6fqXs59cZ/l77e7NhAt0LpRhrzowz22YZUImZrgsrG3LNMFDq5lAl1ouXSG4NYTTvwldmhw8vsif34n67OfKzTHdlzyhgTYeB7yVtckV417nHX8VxJGDrWAkWyCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754396799; c=relaxed/simple; bh=ljY9GgX/i79FhFLesLpbCq8C8FNyRyDzkOq04/esudg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KVGrQx6OVMS+0xzW69dxa2XWtAtoq69fCCjl+KagIfto+bmfr8gwe+ilqveRX/ZCsHLM1+7MIDTn19MENG/VWhtqQgYxqAnqmJ1FzJ0h0SLaUf9pqRSdmKKzvQIjbPsi4nhzCmyuYbxua63MIJkSpuEMieXCbtX7qq9lH8UqN2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PfGnsAWw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PfGnsAWw" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 575Bhi8F016608 for ; Tue, 5 Aug 2025 12:26:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= czu/NJl1TSk2ux1ztbgQmXFWRXTjEbgvSc5lgIlAp6k=; b=PfGnsAWwjxFVvuQT xQywcKw6H21EiUrZf0wnqGK0l7ppANpNEuef4mg04aDRdV8rbfwjwExO8MGrkpIq exXNMUw76Xd+JAAqO/Dapfsh/EIkSuZV6oJPz9nZaoo09V1VCfeWMLKOkGZtVmd7 OFeGE7bgJZM3BeaFkEbtjLDHey+ccN6NnnX7TkorlaieHHoF5ekISPye2cABWByO zfKBNqCW3+bQLb7QNOqQBTk47Eu59AhdqpflotoLIiJRX+OEeakKKToc0S249go9 AjLSwGj8eWset1sKHYK793uWzD5zfLsYgdZxrbeePcdd/Yz8e+QjNCIn0QInCMFC BCsnjw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 489b2a89qh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 05 Aug 2025 12:26:36 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7e698aaff5bso10348385a.3 for ; Tue, 05 Aug 2025 05:26:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754396796; x=1755001596; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=czu/NJl1TSk2ux1ztbgQmXFWRXTjEbgvSc5lgIlAp6k=; b=bL8ape9LPTANICtQTKriPLWzZigdqnOv3K4CNedgqEEE5mBzFkymxx9Ze8Bfyyh0sl 4/C5xQqnq/XtnIM4MbOEP6nHNZQG/+CfoQvCk6Wq7xEamY2ODAfPFhtTSX4U8uyJiaw1 eQsRMcTeHki0FaJcqH+GR8JZDGUaZFvsT3mkskWAF5egUjwGtB8rJuK+DTYpSxfZMVfp 8x6kSaaK0vTgH2r3TprnI+nX6pJcDvckzIn75cLaSC+Xxk1MRXJt3wtkecrebWmzhn9e 260QTMov1Ox5knYROqLdxrxT2s4hxYRGpJRMoxsHv43DptZm0XVzOnwGRsqQ6382UVJx c8rg== X-Forwarded-Encrypted: i=1; AJvYcCU+RR/hyxMz+qzNSC2wW2bs0SsurzYSdn7M7LUqhNXT/05A/r2YTkQD7zk+s+E94TH51xRBYEn4xC+ks/g=@vger.kernel.org X-Gm-Message-State: AOJu0YxJDF+1G3YqS3AB4kAAezWmHbcXEks735cxaUCTxusbkVnW4mRj 8Q78XbqUThProif7YNbxHGQ7S2DhmxG8vD7YyeYyHgLD5ybtM1FC3oNnX7uXABKed0MbBysYr+y paOJ5PkpUPnFhLhYZLBKZV3+iUvTHJ4GltImmgT16IprsOE/cavNxRI5UfO1VwBfj7FQ= X-Gm-Gg: ASbGncsMmsHu/xco/z9uMuHtTC8yeAw9+XAT1R34IPpzLTIaJ6jAkpSn25YiqXHf9do lW8LIr7hJtD3TFDE9jtKezOilJ4ywu0tje/YyaUhNDsfwuC8R7UrcSA+7zoL27Y618qN1T6CCaU 3d6t/atay6u38n3UKn4ZgoNgFTwfmpkwvMlm3R/dUmA3Nv8o3EnRrfVN2TQVuhsacZL+hFDnWWh rmq1csb6ey4AT5sVMiSGz7lzjoYZwaJ39vW6cm9bys3pmEvkIN/Qtd8HEcS2t1F/NTgcrLYIeMc kP83V8Pm6azeZJ3Gp7e0gykeZZlPUNyjEGueA2AJcIMtUeu6bZjIOEIcywEXWnTXIOVUEmUyWvV RTQ4iFe7AQj9dPEyDUg== X-Received: by 2002:a05:620a:3192:b0:7e1:79eb:18a3 with SMTP id af79cd13be357-7e696361ef6mr807807085a.10.1754396796114; Tue, 05 Aug 2025 05:26:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTqvg7PKrg7RvP+PrWNatruiQOsWWUKhTaUzQtAhQa7cxHfsXBhsvWzXAfiPrDug+//SFE+g== X-Received: by 2002:a05:620a:3192:b0:7e1:79eb:18a3 with SMTP id af79cd13be357-7e696361ef6mr807804985a.10.1754396795667; Tue, 05 Aug 2025 05:26:35 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a0a3b6csm896707866b.48.2025.08.05.05.26.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 05:26:35 -0700 (PDT) Message-ID: Date: Tue, 5 Aug 2025 14:26:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] arm64: dts: qcom: Add display support for QCS615 To: Fange Zhang , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Xiangxu Yin , Li Liu , Dmitry Baryshkov References: <20250718-add-display-support-for-qcs615-platform-v5-0-8579788ea195@oss.qualcomm.com> <20250718-add-display-support-for-qcs615-platform-v5-1-8579788ea195@oss.qualcomm.com> <1f6fc7ce-5826-4f59-89d7-ac691a3ae785@oss.qualcomm.com> <7e4d9dfe-428f-4374-9be7-97123cf36e5a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7e4d9dfe-428f-4374-9be7-97123cf36e5a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=OKwn3TaB c=1 sm=1 tr=0 ts=6891f87d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=lxqpRv2xsAHkpo9PiOsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: rfMUffydB5GG9VfkdjRNhh-3RSXpO9VV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA1MDA5MCBTYWx0ZWRfX2+Zvx+YC6PVy dGbPv5q3GeFGHGaZOIZJxala8+EOiveXzTbB183Y3cRJRYjiWByObxVId+klezIZjVXsbJMxGcj zh0BuqcjvWbn0D+yp0qm8vyEU8/xzr5MePHL5hUq5CilKxQXXJYNfLm4Lgn+MIBjtSzzRnMDPcY +0LU/JwO5CrGzpltsMJee+GX6XzHJw+DAinDHLewQx85GUpMJUs94UDK8/EUKjh6SDq/wBVuUR2 XuRsVSY8rdDf6E+tP66kdm+oBU465XSLLKpFVdggLngd2FPgkAGAC8fe4AnaG3wUvq4TVX67N+S lgQODqWFNP422G8Fm7Ui6NqPLvpEfM2NNIN7luja3KHopYYb/qIZWZ883vf7f88uLEblDg0p10j W0j0vvEStqUjFNZfXWU4h7F9y3yYwABAXcvwjvHzKr4dSTxe1NRzRH1N7r8O5V9ux31qdE4Y X-Proofpoint-GUID: rfMUffydB5GG9VfkdjRNhh-3RSXpO9VV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-05_03,2025-08-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 impostorscore=0 priorityscore=1501 adultscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508050090 On 8/5/25 2:24 PM, Fange Zhang wrote: > > > On 7/29/2025 7:17 PM, Konrad Dybcio wrote: >> On 7/18/25 2:56 PM, Fange Zhang wrote: >>> From: Li Liu >>> >>> Add display MDSS and DSI configuration for QCS615 platform. >>> QCS615 has a DP port, and DP support will be added in a later patch. >>> >>> Reviewed-by: Dmitry Baryshkov >>> Signed-off-by: Li Liu >>> Signed-off-by: Fange Zhang >>> --- >> >> [...] >> >>> + >>> +            mdss_mdp: display-controller@ae01000 { >>> +                compatible = "qcom,sm6150-dpu"; >>> +                reg = <0x0 0x0ae01000 0x0 0x8f000>, >>> +                      <0x0 0x0aeb0000 0x0 0x2008>; >>> +                reg-names = "mdp", "vbif"; >>> + >>> +                clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, >>> +                     <&gcc GCC_DISP_HF_AXI_CLK>, >>> +                     <&dispcc DISP_CC_MDSS_MDP_CLK>, >>> +                     <&dispcc DISP_CC_MDSS_VSYNC_CLK>; >>> +                clock-names = "iface", "bus", "core", "vsync"; >> >> 1 per line please, everywhere> + > Got it will fix it in next patch>> +                assigned-clocks = <&dispcc DISP_CC_MDSS_VSYNC_CLK>; >>> +                assigned-clock-rates = <19200000>; >> >> Is this necessary? > test pass without this, so will remove them in next patch> You need to leave a \n before you start typing your reply, otherwise the email text gets messed up (like above) Konrad