From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F4A141D11F for ; Tue, 13 Oct 2026 12:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791894731; cv=none; b=tgF50tk9uNzLmvlDQPJdUyXAV/cc+nY6Lcq4ptmZrQ6WFvR/HMsPi7V9H17hjf52Lv+zbhXekxX+RkwPwvniPVjzOJ2yhbORcD7zl0qsYjtcTUeOBzm/q3+79h7tptingVr1rp3oQ2Uh8nJD7blC31LFgtZGejBib4qeVRUJ5Zk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791894731; c=relaxed/simple; bh=ZRk0SmiiHPXTYrCGY1HqWUfRlbRsgSpESuwS25sKN5Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MtRkt9jhiZ4z5cqGVbJ/oCD+Op8wMqZa28anNnXfj+JKwWB950iXxwCKQIBz9PQfhRXiZ6ejpDVReynrhfVhDg2+bUeVLiD0ENPnqRuXktN7gODMq9e8E+ba5O9ZVP1TRo1/aNUZ/vnUh+L7bxVOoXO8wkMbZkyiiKhbO2pJxw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=oxEyYH0n; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=r0cQ9QUG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=X5Z1exIM; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YCNyKxPq; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="oxEyYH0n"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="r0cQ9QUG"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="X5Z1exIM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YCNyKxPq" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C5FB11F455; Tue, 13 Oct 2026 12:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1791894728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2SQssXF16ZyscciZ55hfy7cX7Urdr1os/GhQHzd6IyI=; b=oxEyYH0nAIGT5CZ/0VLwgA+s/9OIthZ6WGQzisaS/Zrbg4oM5SeY8yB3t9kTbPJ7qT3U1Y gBNa90nQ6oD51VCrMyAeLkaxjYglletXqJm7Xs8d9NKnglCBsd3bBsWRt3QXd7BZ3dzqUr MqcDGxcXU99gzyXifLZpAzMlF/k6knE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1791894728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2SQssXF16ZyscciZ55hfy7cX7Urdr1os/GhQHzd6IyI=; b=r0cQ9QUGo9W2zqtwOxstiqC1hF67vCl3Vs49rWGgJgWUTuQsSst4dUQkjixZRftZM8LV4t Ok4SXmczc398ImCQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=X5Z1exIM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YCNyKxPq DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1791894727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2SQssXF16ZyscciZ55hfy7cX7Urdr1os/GhQHzd6IyI=; b=X5Z1exIMQGS4PM627vYBjII6entNDkn0q2zvPQaUArSfv/ej+LkA8dRgGr5KimQm2k7QA9 AsN33qdlU5Y8CxRdLKYs5mxp3fBCLY6k6x3u3X496OBIFIv0R6YHDF5MP6zhqclousbI3k LCJ6ERcAFMhDycRluUlrmWA/fdt8ORM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1791894727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2SQssXF16ZyscciZ55hfy7cX7Urdr1os/GhQHzd6IyI=; b=YCNyKxPqv0YvD3hIc+oeBoUpJ0qnl6tJgfUoPYFnyRoMigYpaJxKrcTIBvNNPx9fdU/nSN N+lV12LWddha1PAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 719A013341; Tue, 13 Oct 2026 12:32:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ihKmCcckzmojNAAAD6G6ig (envelope-from ); Tue, 13 Oct 2026 12:32:07 +0000 Message-ID: Date: Tue, 13 Oct 2026 14:32:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/format-helper: Add XRGB8888 to UYVY conversion To: Jie Feng Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org References: <20261012170857.199561-1-hjf3108@gmail.com> <64707239-eac7-4259-a8ff-7ec43d13860e@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: C5FB11F455 X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-4.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[lists.freedesktop.org,linux.intel.com,kernel.org,gmail.com,ffwll.ch,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_SEVEN(0.00)[7]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email,suse.de:dkim] X-Spam-Flag: NO X-Spam-Score: -4.50 Hi Am 13.10.26 um 14:17 schrieb Jie Feng: > On Tue, 13 Oct 2026 at 15:11, Thomas Zimmermann wrote: >> Hi >> >> Am 12.10.26 um 19:08 schrieb Ho Jie Feng: >>> Add a helper for devices that use packed UYVY but accept XRGB8888 >>> framebuffers. >> Is there a description of UYVY available somewhere? > This is for a reverse engineered usb display adapter, which accepts > input in bytes of U, Y, V, Y in that order. I'm not sure what > counts as a description, apart from it matching DRM_FORMAT_UYVY? I see. The format exists already in DRM. > > This patch is meant to move this out of the driver: > https://github.com/rhgndf/ms912x/blob/main/ms912x_transfer.c#L153 > >>> Signed-off-by: Ho Jie Feng >>> --- >>> This is used for a driver, ms912x that I will be submitting. It only >>> supports uyvy framebuffers. >> Please resubmit as part of the driver series. We're not going to merge >> it without callers anyway. >> ... >> For naming, please follow the conventions used by the other helpers in >> this file. > Will send the driver in with this patch and its fixes, thanks for the review. > >> ... >>> + v = drm_pixel_rgb2_to_v_bt601(r, g, b); >>> + u = drm_pixel_rgb2_to_u_bt601(r, g, b); >>> + >>> + transfer_buffer[dst_offset++] = u; >>> + transfer_buffer[dst_offset++] = y1; >>> + transfer_buffer[dst_offset++] = v; >>> + transfer_buffer[dst_offset++] = y2; >> Rather that writing bytes individually, use put_unaligned_le32() or a >> similar helper. Byte order within a pixel is little endian, although >> I'm not sure what this means for UYVY. > This is meant to be sent over a usb transfer, so byte order needs to be > the same on both little and big endian systems. DRM formats always refer to little endian. As it is implemented now, it's not clear what the endianess of your output is. Please duplicate the other helpers' logic. They all pack the output with appropriate helpers. If the USB device requires BE, you have to write a separate conversion helper for that. BTW, you have an OOB access if the line width is not a multiple of 2. Best regards Thomas > >>> ... >>> +static inline u32 drm_pixel_rgb_to_y_bt601(u32 r, u32 g, u32 b) >>> +{ >>> + const u32 luma = (16U << 16) + 16829 * r + 33039 * g + 6416 * b + 32768; >>> + >>> + return luma >> 16; >>> +} >>> + >>> +static inline u32 drm_pixel_rgb2_to_u_bt601(u32 r2, u32 g2, u32 b2) >>> +{ >>> + const u32 u = (128U << 17) - 9714 * r2 - 19071 * g2 + 28784 * b2 + 65536; >>> + >>> + return u >> 17; >>> +} >>> + >>> +static inline u32 drm_pixel_rgb2_to_v_bt601(u32 r2, u32 g2, u32 b2) >>> +{ >>> + const u32 v = (128U << 17) + 28784 * r2 - 24103 * g2 - 4681 * b2 + 65536; >>> + >>> + return v >> 17; >>> +} >>> + >> These helpers seem too fine-grained. IMHO it would be better to have a >> helper like drm_pixel_rgb_to_uyvy() that takes two RGB values and >> returns the assembled 16-bit UYVY value. > Makes sense. > >> Best regards >> Thomas >> >>> /* >>> * Conversion from ARGB8888 >>> */ >>> diff --git a/include/drm/drm_format_helper.h b/include/drm/drm_format_helper.h >>> index 2b5c1aef80b0e..e50f96e07484c 100644 >>> --- a/include/drm/drm_format_helper.h >>> +++ b/include/drm/drm_format_helper.h >>> @@ -136,4 +136,8 @@ void drm_fb_xrgb8888_to_gray2(struct iosys_map *dst, const unsigned int *dst_pit >>> const struct iosys_map *src, const struct drm_framebuffer *fb, >>> const struct drm_rect *clip, struct drm_format_conv_state *state); >>> >>> +void drm_fb_xrgb8888_to_uyvy(struct iosys_map *dst, const unsigned int *dst_pitch, >>> + const struct iosys_map *src, const struct drm_framebuffer *fb, >>> + const struct drm_rect *clip, struct drm_format_conv_state *state); >>> + >>> #endif /* __LINUX_DRM_FORMAT_HELPER_H */ >> -- >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com >> GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg) >> >> -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)