mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>,
	'John Paul Adrian Glaubitz' <glaubitz@physik.fu-berlin.de>,
	Guenter Roeck <linux@roeck-us.net>,
	Sergey Shtylyov <s.shtylyov@omp.ru>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: Avoid using IRQ0 on SH3 and SH4
Date: Wed, 12 Jul 2023 11:20:46 +0300	[thread overview]
Message-ID: <c9483d7f-7f5f-dd29-2bba-5659a1dae7e0@gmail.com> (raw)
In-Reply-To: <c5ad5c59fcfa4888bd03fb8a855c989c@AcuMS.aculab.com>

On 7/12/23 11:12 AM, David Laight wrote:

>> Sent: 09 July 2023 00:13
> ....
>> Looking at arch/sh/boards/mach-r2d/irq.c, there is some IRQ translation going
>> on and maybe that's the part where we need to correct the offset by 16?
> 
> Would it be less problematic to use (say) 16 for IRQ_0
> leaving IRQ_1+ as 1+ ?

   I don't think so.

> At least that would only cause issues for code that needed
> to use IRQ_0.
> 
> (It has to be said that making IRQ 0 invalid seemed wrong
> to me. x86 (IBM PC) gets away with it because IRQ 0 is
> always assigned to platform specific hardware.)

   Not only x86, IIRC.
   Have you seen the commit below?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce753ad1549cbe9ccaea4c06a1f5fa47432c8289

   IOW, try arguing with Linus. :-)

> 	David

MBR, Sergey

  parent reply	other threads:[~2023-07-12  8:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 13:57 Guenter Roeck
2023-07-06 14:01 ` John Paul Adrian Glaubitz
2023-07-06 15:51   ` Guenter Roeck
2023-07-08 20:35   ` Sergey Shtylyov
2023-07-08 20:43     ` Sergey Shtylyov
2023-07-06 15:39 ` Geert Uytterhoeven
2023-07-06 15:51   ` Guenter Roeck
2023-07-06 16:38   ` John Paul Adrian Glaubitz
2023-07-06 17:04     ` Guenter Roeck
2023-07-06 17:41       ` John Paul Adrian Glaubitz
2023-07-08 20:55         ` Sergey Shtylyov
2023-07-07  7:14     ` Geert Uytterhoeven
2023-07-07  8:48       ` Geert Uytterhoeven
2023-07-07  9:30         ` John Paul Adrian Glaubitz
2023-07-07  9:53         ` John Paul Adrian Glaubitz
2023-07-07 14:34           ` Guenter Roeck
     [not found]             ` <407492B8-5D9F-41BC-A696-24C421C69F49@physik.fu-berlin.de>
2023-07-07 15:30               ` Guenter Roeck
2023-07-08 20:52     ` Sergey Shtylyov
2023-07-08 22:06       ` Guenter Roeck
2023-07-08 23:13         ` John Paul Adrian Glaubitz
2023-07-09  0:28           ` Guenter Roeck
2023-07-12  8:12           ` David Laight
2023-07-12  8:15             ` John Paul Adrian Glaubitz
2023-07-12  8:20             ` Sergei Shtylyov [this message]
2023-07-12  8:24               ` David Laight
2023-07-12 15:38               ` Guenter Roeck
2023-07-12 15:51                 ` John Paul Adrian Glaubitz
2023-07-12 16:22                 ` Sergey Shtylyov
2023-07-12 16:25                   ` Sergey Shtylyov
2023-07-08 13:26 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9483d7f-7f5f-dd29-2bba-5659a1dae7e0@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=s.shtylyov@omp.ru \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®