From: Thomas Zimmermann <tzimmermann@suse.de>
To: Asahi Lina <lina@asahilina.net>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Javier Martinez Canillas <javierm@redhat.com>
Cc: "Noralf Trønnes" <noralf@tronnes.org>,
"Rob Herring" <robh@kernel.org>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/shmem-helper: Revert accidental non-GPL export
Date: Mon, 27 Feb 2023 10:07:10 +0100 [thread overview]
Message-ID: <c94a0b2c-f061-3030-ecb7-abf0a16faa1d@suse.de> (raw)
In-Reply-To: <20230227-shmem-export-fix-v1-1-8880b2c25e81@asahilina.net>
[-- Attachment #1.1: Type: text/plain, Size: 1604 bytes --]
Hi
Am 27.02.23 um 10:04 schrieb Asahi Lina:
> The referenced commit added a wrapper for drm_gem_shmem_get_pages_sgt(),
> but in the process it accidentally changed the export type from GPL to
> non-GPL. Switch it back to GPL.
>
> Reported-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Fixes: ddddedaa0db9 ("drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()")
> Signed-off-by: Asahi Lina <lina@asahilina.net>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks a lot. I'll add your patch to drm-misc-fixes ASAP.
Best regards
Thomas
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 7e5c6a8d0212..75185a960fc4 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -744,7 +744,7 @@ struct sg_table *drm_gem_shmem_get_pages_sgt(struct drm_gem_shmem_object *shmem)
>
> return sgt;
> }
> -EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt);
>
> /**
> * drm_gem_shmem_prime_import_sg_table - Produce a shmem GEM object from
>
> ---
> base-commit: f3a2439f20d918930cc4ae8f76fe1c1afd26958f
> change-id: 20230227-shmem-export-fix-85fde1351104
>
> Thank you,
> ~~ Lina
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-02-27 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:04 Asahi Lina
2023-02-27 9:07 ` Thomas Zimmermann [this message]
2023-02-27 9:13 ` Javier Martinez Canillas
2023-02-28 9:14 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c94a0b2c-f061-3030-ecb7-abf0a16faa1d@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=daniel@ffwll.ch \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®