From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BEE0C4167B for ; Wed, 6 Dec 2023 16:21:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379244AbjLFQVt (ORCPT ); Wed, 6 Dec 2023 11:21:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379171AbjLFQVp (ORCPT ); Wed, 6 Dec 2023 11:21:45 -0500 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 4B52AD4E for ; Wed, 6 Dec 2023 08:21:50 -0800 (PST) Received: (qmail 460384 invoked by uid 1000); 6 Dec 2023 11:21:50 -0500 Date: Wed, 6 Dec 2023 11:21:50 -0500 From: Alan Stern To: Ferry Toth Cc: Catalin Marinas , Christoph Hellwig , Hamza Mahfooz , Dan Williams , Marek Szyprowski , Andrew , Andy Shevchenko , Thorsten Leemhuis , iommu@lists.linux.dev, Kernel development list , USB mailing list , Robin Murphy , Will Deacon Subject: Re: Bug in add_dma_entry()'s debugging code Message-ID: References: <20231128133702.GA9917@lst.de> <76e8def2-ff45-47d3-91ab-96876ea84079@gmail.com> <5425cf42-0f49-41b5-b26d-1e099d5bdcc2@elsinga.info> <5093ce37-047e-4aa8-a9e8-2978da9d734a@rowland.harvard.edu> <1e4df825-08fa-40cf-a565-9c0d285c9b73@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1e4df825-08fa-40cf-a565-9c0d285c9b73@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2023 at 05:12:40PM +0100, Ferry Toth wrote: > Hi > > On 05-12-2023 19:28, Alan Stern wrote: > > In the long run, it may turn out that trying to detect memory usage > > patterns that could cause problems for architectures other than the one > > currently running is not workable. Certainly it is a bad idea to have a > > Maybe. But while debugging code on your platform it is a good thing to get > warnings for potential issues on other platforms. Oh, absolutely! It's definitely a good thing. I'm just saying that doing it may not be practical -- there may be too many false positives (as in this bug report) and false negatives. > In this case we (I) got misled by the warning message itself. That should be > easy enough to improve. I don't think so. Issuing incorrect warnings that should be ignored is a very bad idea, no matter what the wording is. After seeing a few messages like that, people learn to expect them -- and then they ignore the valid warnings along with the incorrect ones. Alan Stern