From: Paolo Bonzini <pbonzini@redhat.com>
To: Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Lai Jiangshan <jiangshan.ljs@antgroup.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: Remove the unused macro KVM_MMU_READ_LOCK()
Date: Fri, 9 Dec 2022 08:58:03 +0100 [thread overview]
Message-ID: <c958aa5a-1bd2-7f81-0f20-fd3a42393528@redhat.com> (raw)
In-Reply-To: <20221207120617.9409-1-jiangshanlai@gmail.com>
On 12/7/22 13:06, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
>
> No code is using KVM_MMU_READ_LOCK().
And KVM_MMU_READ_UNLOCK() is also unused.
Paolo
> Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
> ---
> virt/kvm/kvm_mm.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/virt/kvm/kvm_mm.h b/virt/kvm/kvm_mm.h
> index a1ab15006af3..e98e294080bf 100644
> --- a/virt/kvm/kvm_mm.h
> +++ b/virt/kvm/kvm_mm.h
> @@ -14,13 +14,11 @@
> #define KVM_MMU_LOCK_INIT(kvm) rwlock_init(&(kvm)->mmu_lock)
> #define KVM_MMU_LOCK(kvm) write_lock(&(kvm)->mmu_lock)
> #define KVM_MMU_UNLOCK(kvm) write_unlock(&(kvm)->mmu_lock)
> -#define KVM_MMU_READ_LOCK(kvm) read_lock(&(kvm)->mmu_lock)
> #define KVM_MMU_READ_UNLOCK(kvm) read_unlock(&(kvm)->mmu_lock)
> #else
> #define KVM_MMU_LOCK_INIT(kvm) spin_lock_init(&(kvm)->mmu_lock)
> #define KVM_MMU_LOCK(kvm) spin_lock(&(kvm)->mmu_lock)
> #define KVM_MMU_UNLOCK(kvm) spin_unlock(&(kvm)->mmu_lock)
> -#define KVM_MMU_READ_LOCK(kvm) spin_lock(&(kvm)->mmu_lock)
> #define KVM_MMU_READ_UNLOCK(kvm) spin_unlock(&(kvm)->mmu_lock)
> #endif /* KVM_HAVE_MMU_RWLOCK */
>
prev parent reply other threads:[~2022-12-09 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 12:06 Lai Jiangshan
2022-12-09 7:58 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c958aa5a-1bd2-7f81-0f20-fd3a42393528@redhat.com \
--to=pbonzini@redhat.com \
--cc=jiangshan.ljs@antgroup.com \
--cc=jiangshanlai@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®