mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: Stijn Cleynhens <stijncleynhens@gmail.com>, netdev@vger.kernel.org
Cc: "Linus Walleij" <linusw@kernel.org>,
	"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
	"Alvin Šipraga" <alvin.sipraga@analog.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 0/2] net: dsa: realtek: rtl8365mb: fix FDB lookups in VLAN-unaware bridges
Date: Sun, 22 Nov 2026 15:04:47 +0100	[thread overview]
Message-ID: <c963f0ad-65fd-4d2e-823e-5c63251e2fe5@yahoo.com> (raw)
In-Reply-To: <20261106150225.3700205-1-stijncleynhens@gmail.com>

On Fri, Nov 06, 2026 at 04:02:23PM +0100, Stijn Cleynhens wrote:
> Tested on OpenWrt's 6.18 kernel, which carries the rtl8365mb backports up
> to v7.4; the code these patches touch is the same as in net. A station
> learned behind the uplink that moves behind the CPU port answers 10/10
> pings, its learned entry replaced by the CPU one, with VLAN filtering
> switched off at runtime: on an RTL8367S (TP-Link Deco X50-Outdoor), and
> on an RTL8367S-VB (Deco X50-PoE, with the family D series applied and a
> family D branch in rtl8365mb_vlan_pvid_port_commit()), where it also
> passes with VLAN filtering on. Before these patches the RTL8367S
> answered 0/10. Both patches build without warnings with W=1 C=1.
>
> Note for Mieczyslaw's RTL8367S-VB series in net-next (v8): patch 2
> replaces rtl8365mb_vlan_pvid_port_set() and
> rtl8365mb_vlan_pvid_port_clear() with rtl8365mb_vlan_pvid_port_commit(),
> which gets the target VID (0 for the neutral PVID) and the filtering
> state. The family D paths that series adds to set and clear become one
> branch there that writes the PVID register and the frame filter from
> those two inputs. Happy to send that as a follow-up once both are in.

Hi Stijn,

thank you for testing on an RTL8367S-VB and for the note about my series.
It is now at v13 (14 patches): [link to v13 on lore]

Since you have family D hardware and work on FDB lookups in VLAN-unaware
bridges, could you please take a look at two patches of it, and test them
if you have time:

- 7/14, which makes IVL_EN of the 4K VLAN entries follow the VLAN
  filtering state on family D;
- 12/14, which handles the L2/LUT differences on family D: no EFID, so
  an offloaded VLAN-unaware bridge is put in FID 1 with the port-based FID
  registers while standalone ports stay in FID 0, plus the lookup-hit
  isolation fallback (0x0A10 bit 0).

12/14 changed the most in v13 and has had the least testing. Your case of
a station moving between a user port and the CPU port, with VLAN
filtering on and off, would be a very useful check for it.

Best regards,
Mieczyslaw Nalewaj

      parent reply	other threads:[~2026-11-22 14:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 15:02 Stijn Cleynhens
2026-11-06 15:02 ` [PATCH net v2 1/2] net: dsa: realtek: rtl8365mb: use IVL in VLAN 0 Stijn Cleynhens
2026-11-10 15:21   ` netdev-bot+sashiko
2026-11-06 15:02 ` [PATCH net v2 2/2] net: dsa: realtek: rtl8365mb: keep the neutral PVID in VLAN-unaware bridges Stijn Cleynhens
2026-11-10 15:21   ` netdev-bot+sashiko
2026-11-15 16:17     ` Stijn Cleynhens
2026-11-20 19:29       ` Luiz Angelo Daros de Luca
2026-11-13 13:28   ` Luiz Angelo Daros de Luca
2026-11-22 14:04 ` Mieczyslaw Nalewaj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c963f0ad-65fd-4d2e-823e-5c63251e2fe5@yahoo.com \
    --to=namiltd@yahoo.com \
    --cc=alvin.sipraga@analog.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luizluca@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=stijncleynhens@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®