From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f65.google.com (mail-oo1-f65.google.com [209.85.161.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 264431CB324 for ; Thu, 31 Oct 2024 19:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730402705; cv=none; b=rVnMVUsUXpSQHng6+lUq0P1yFjPGr8DlSUg5qsOo5twl2tnzxSj6eoMvITmStCLq1CXnxVJtM/m2G+nWz7/wuSMCmDQIlGiZ4R1KZ5Sc8cBA9apZX+02UJq9Mp31N8q9cVGPVOz+zSqJ9NVW2DZIEwoq7kGNk/zbGSr015wcBvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730402705; c=relaxed/simple; bh=rGuTVD1KWxFW/iVXJuMMGl1bde0QDjUWD3zqWMNpPpw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PkXeCJx73C3zPvevX7N7FYyLP3XADNFgJ67dpw3boN5E7frxLvtmre5TkX5nqsXrV1Fc4cHMkObgJpbvisdoDaqQE+pszufzyJSBrKbhuP2ITtux0DZAnLsJ6sGQQKm2wdiFPx3+sD08qny6WBMNsJLXd9ozANfJQu3tcq0A9wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=sN8VEMR4; arc=none smtp.client-ip=209.85.161.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="sN8VEMR4" Received: by mail-oo1-f65.google.com with SMTP id 006d021491bc7-5ebc4e89240so692128eaf.1 for ; Thu, 31 Oct 2024 12:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1730402701; x=1731007501; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uhUAE7CiIIKadT6/yqK22wb65HeoOWbYs2QkpH1TFEc=; b=sN8VEMR417Sv2zxZVGodu5zpEft0CyrmVipctCPnfdFVkp4Mqx0L3F3o7bUmk5fco1 i239eIOpNudzF4SqjzOmgEaRjv2rNlvl0kfX3WsCBy3aGi9rg3tDXCRb/cnreUZpeqOX l67u1aZ8tla0zgcWYzaxv7XL/UMskka9Wc9JwSj/JE/zlbAQ4O3iS7wRr8rNryRe2h1d tYfVkt94uWjRz+cd+9zCcJhGFcvUg/jcp1Vc4dj/l+BL+BByZrKgtLXYhHL9BA2iwonO /VrzSbimBPbz4lc5M1mMLGp+gfkqGHIxtcsuMCbRiXcoy04C05lEManarmsLeiLnZtpq 6/0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730402701; x=1731007501; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uhUAE7CiIIKadT6/yqK22wb65HeoOWbYs2QkpH1TFEc=; b=hkHA6gsbKhQkAhKBpRcwXwO1yNGDwU8WH0E8lX29qcMrdF4YrPNoTisOezSRtdD91U KeZ++jlkta4NOiIa3BFMlI4lw0ZOw2FhVkPnn6pznKyM21bK3/ewFQMrh9otwYu5/689 I+qIKpqwMd7JZomzjcLELDyMlF1ks38m+/23PNtrTFSRsypwUhVEDVW84V4+TZY4xgSb alC72S0UVfImtYVudnDjOebbDLM4lOGp+7btsluTAbJDSkceYsXfUs+HTXS056d2hgD6 FNwRkHcElMGziycjgOeQZxE2nbQhFkTT+efgIM9ehGp0NBs0WE73vegF7+yXOp7CXQmc Ulng== X-Forwarded-Encrypted: i=1; AJvYcCVheuu7oQsHmri0msi0tVYz2VXWb1fMqdfCtq1KkV1fo31LqrR7J/u2srg6nJxDIxBvSPF2oTZXgOUsRes=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6DnfWiKDAS4AmiighSH87wXM9y0XpA62p45gsQ1jNNUPe4aE/ F1id8vkhYAXzKLqc29O2aYfcUuF+f94XqgkSJEYvcW55MiA4MfapPchgmz7vlQ== X-Google-Smtp-Source: AGHT+IE4RL0Dif6O3Ry2HBvWKw4OdWKQa4QtWRA9GyvNzx3ILrwjuqWLN3eWXUD22moyPASJ4KXWIQ== X-Received: by 2002:a05:6358:9817:b0:1c2:fcd0:d20a with SMTP id e5c5f4694b2df-1c5f9a4b3bcmr97124455d.25.1730402701046; Thu, 31 Oct 2024 12:25:01 -0700 (PDT) Received: from rowland.harvard.edu ([2607:fb60:2501:2805:c6d5:fe22:7fa3:ec54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d35415b1d6sm10958586d6.76.2024.10.31.12.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 12:25:00 -0700 (PDT) Date: Thu, 31 Oct 2024 15:24:57 -0400 From: Alan Stern To: Lorenzo Stoakes Cc: syzbot , akpm@linux-foundation.org, jannh@google.com, liam.howlett@oracle.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com, vbabka@suse.cz Subject: Re: [syzbot] [mm?] [input?] [usb?] INFO: rcu detected stall in brk (2) Message-ID: References: <6723b31e.050a0220.35b515.0165.GAE@google.com> <2928b6e8-3928-411d-82b8-6b17be266deb@lucifer.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2928b6e8-3928-411d-82b8-6b17be266deb@lucifer.local> On Thu, Oct 31, 2024 at 04:58:29PM +0000, Lorenzo Stoakes wrote: > +Alan re: USB stalls > > On Thu, Oct 31, 2024 at 09:41:02AM -0700, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did not trigger any issue: > > > > Reported-by: syzbot+7402e6c8042635c93ead@syzkaller.appspotmail.com > > Tested-by: syzbot+7402e6c8042635c93ead@syzkaller.appspotmail.com > > > > Tested on: > > > > commit: cffcc47b mm/mlock: set the correct prev on failure > > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/ mm-hotfixes-unstable > > console output: https://syzkaller.appspot.com/x/log.txt?x=1304a630580000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=6648774f7c39d413 > > dashboard link: https://syzkaller.appspot.com/bug?extid=7402e6c8042635c93ead > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 > > > > Note: no patches were applied. > > Note: testing is done by a robot and is best-effort only. > > OK this seems likely to be intermittant (and unrelated to what's in > mm-unstable-fixes honestly) and does make me wonder if the fix referenced > in [0] really has sorted things out? Or whether it has perhaps help > mitigate the issue but not sufficiently in conjunction with debug things > that slow things down. This looks very different from the issues that were addressed by the fix I mentioned in [0]. In particular, the log traces for this series of bug reports all start with something like this: serial_out drivers/tty/serial/8250/8250.h:142 [inline] serial8250_console_fifo_write drivers/tty/serial/8250/8250_port.c:3322 [inline] serial8250_console_write+0xf9e/0x17c0 drivers/tty/serial/8250/8250_port.c:3393 console_emit_next_record kernel/printk/printk.c:3092 [inline] console_flush_all+0x800/0xc60 kernel/printk/printk.c:3180 __console_flush_and_unlock kernel/printk/printk.c:3239 [inline] console_unlock+0xd9/0x210 kernel/printk/printk.c:3279 vprintk_emit+0x424/0x6f0 kernel/printk/printk.c:2407 vprintk+0x7f/0xa0 kernel/printk/printk_safe.c:68 _printk+0xc8/0x100 kernel/printk/printk.c:2432 printk_stack_address arch/x86/kernel/dumpstack.c:72 [inline] indicating that perhaps the problem is related to the 8250 driver. Or perhaps that driver just happens to wait for long periods and so is more likely to show up when the real problem occurs. By contrast, the log traces for the [0] bug reports all show something like this: context_switch kernel/sched/core.c:5315 [inline] __schedule+0x105f/0x34b0 kernel/sched/core.c:6675 __schedule_loop kernel/sched/core.c:6752 [inline] schedule+0xe7/0x350 kernel/sched/core.c:6767 usb_kill_urb.part.0+0x1ca/0x250 drivers/usb/core/urb.c:713 usb_kill_urb+0x83/0xa0 drivers/usb/core/urb.c:702 usb_start_wait_urb+0x255/0x4c0 drivers/usb/core/message.c:65 usb_internal_control_msg drivers/usb/core/message.c:103 [inline] usb_control_msg+0x327/0x4b0 drivers/usb/core/message.c:154 because that bug involved usb_kill_urb() waiting indefinitely for an event that never happens. Alan Stern > [0]:https://lore.kernel.org/all/967f3aa0-447a-4121-b80b-299c926a33f5@rowland.harvard.edu/