From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C7E927145D for ; Tue, 5 Aug 2025 13:22:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754400131; cv=none; b=bP8XLnbKkTWdITCNnrAztN+IppYkp9eTNdoBUV5/ACOxp8VQ6+I/1oLgPc3UltajjqI5BfsckRLv8vEB9RMr8hfdVkJua0ktwimU+MxxSlxNXVYY83xNy2c/TvPvVZQ06/UVsKPHdvPJpWjXtI0XoX5i2HKGTpE97Nz20pSZK54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754400131; c=relaxed/simple; bh=Byl/nL13FsRUyOv55gfHnHsItiTLelhTKmvqqbOAt0k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KqjKN1m04MudQlwiZ0rJEWpAoEVoo8aT7yhwYFr6JrmhZysLyWTNNTrco7UyItISySr+HtzZsYWys/5v96x0eEVLeAKl3YUrxAgD4uakSmN9ny1zQOJQBOM+F7O8qR/wzbsCDgS5cx80nk62L7qmsJIIMYHBo+Ht+g/7fPJqYmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e/BfRAfm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e/BfRAfm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754400129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5fwb6/daib0qsKP6ENXvqmzAK5HWFVCh16mUj7WQsrM=; b=e/BfRAfmQurJjI0RSB2812i3v+Okpl4g0UlVUVQOArH/z63pznAZRpA9xvsmv3nHYJ0WPU 7SWBUajSC7P4BryZfE0VOrPGJRwRv7rrn6NI2Giy5poEGGTT7p98Gb9YxAXVv3RMZI8XLY wh2rt+XIo8pbl0v4Gi1KACTjgl5qlO0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-j8vaECm8O_eK9oLnZ-5jvA-1; Tue, 05 Aug 2025 09:22:07 -0400 X-MC-Unique: j8vaECm8O_eK9oLnZ-5jvA-1 X-Mimecast-MFC-AGG-ID: j8vaECm8O_eK9oLnZ-5jvA_1754400127 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-459d6c83e2eso12534245e9.1 for ; Tue, 05 Aug 2025 06:22:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754400126; x=1755004926; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5fwb6/daib0qsKP6ENXvqmzAK5HWFVCh16mUj7WQsrM=; b=ptCPsoPIyxFVUq4fmZVV66nUk0au1lAhSnftG1ZFYD9eRFHm+GpkfeVChG9T3K50aB L1F7HUTZ5JcklLZGs/uDrUVSEWcBkl9+PAt3PHYjdCxrVB6T/6WAFZZ1Pu9ebYV6za9s bXFOJ99ohN+fxUl+tj1OikJbVFGPqSLi1DP3xYRuk9SAcVqoeNSPjNnfD5o51naAwHlA k5RSD4+X6kUthxabCrWAPbBfwjng3DwwGQ4gg+8esZTv1frxZzy2F3C5XTzGuPC6ijgM y6hCabuq7c8EslrgRJH4j48RbdyZ0Cbzv1uoou/pFxk57/9cfyePQsmQvT/OZqm/D7t+ s6YQ== X-Forwarded-Encrypted: i=1; AJvYcCXfEFCOgjoULr+DqcuhB3W0Pzyiic2q77BJwZSf9UUFM/jy8HuqU+tbVvTZbYe0RdM4kA7STQh3HZ2RGz8=@vger.kernel.org X-Gm-Message-State: AOJu0YyjviGJN6VV/Ub9wRQbcZbZKejylsB631Ul2PfNBWBqx517w1YC ENdeFzKAJ/wfZfUrhI/IyhAaInjfNExdjiBf5YQUXObcFEekRgZQmuJq4JpkL4zv3GjpABlAqGL z9JXwmAZ14w2H3XLppeYbaKhMs8Wx0pQ2/2fEMeXMem8x5Ud1+z8w4ZdyVdiwlEI7Sw== X-Gm-Gg: ASbGncsAvg2HccJYH3gW1TEB9iP7XbrrmlKciOACb5tN8bKQSjuHByryv+0VF9b41eU Q/E671eznW48rNKB82Mue/ZYli6sbQr+jXtKi5UK14q5GdrEbDAtp2t0DZHAAPyiUcDqO9K+l1c m+ahH2o/9Z02kosyysYiKum4LcDvoUQPknrriaFPgwe7crv21GHD0XYdAe7v7L88/8kToj0gXvM 7xircmQupKsOF6CEIdsBCRsAD1xmtFDHy6Y8O0Bre8nPiejRYsUMtOxtBNLPcoEg185kcNCU4vs E4g8yA6aEmkuke+p0CnZVt15WjKCjb0/RizjDjgkDA4b361If1QztzeZN0zozCiNaLfwPpA= X-Received: by 2002:a05:600c:8b61:b0:459:dde3:1a27 with SMTP id 5b1f17b1804b1-459dde31ef4mr54719395e9.26.1754400126593; Tue, 05 Aug 2025 06:22:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQ5z71kBdTOm3vKI1raiUutHNjtrO4k9neXdCPoHWjzHt02qOZBq3U9ZmkSrWR5dIkmUgMig== X-Received: by 2002:a05:600c:8b61:b0:459:dde3:1a27 with SMTP id 5b1f17b1804b1-459dde31ef4mr54719115e9.26.1754400126161; Tue, 05 Aug 2025 06:22:06 -0700 (PDT) Received: from [192.168.3.141] (p57a1a26f.dip0.t-ipconnect.de. [87.161.162.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e075805csm44029665e9.4.2025.08.05.06.22.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 06:22:05 -0700 (PDT) Message-ID: Date: Tue, 5 Aug 2025 15:22:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] VFIO updates for v6.17-rc1 To: Linus Torvalds Cc: Jason Gunthorpe , Alex Williamson , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lizhe.67@bytedance.com" References: <20250804162201.66d196ad.alex.williamson@redhat.com> <20250804185306.6b048e7c.alex.williamson@redhat.com> <0a2e8593-47c6-4a17-b7b0-d4cb718b8f88@redhat.com> <20250805114908.GE184255@nvidia.com> <9b447a66-7dcb-442b-9d45-f0b14688aa8c@redhat.com> <20250805123858.GJ184255@nvidia.com> <20250805125643.GK184255@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.08.25 15:15, Linus Torvalds wrote: > On Tue, 5 Aug 2025 at 16:05, David Hildenbrand wrote: >> >> So I don't like the idea of micro-optimizing num_pages_contiguous() by >> adding weird tweaks to the core for that. > > Seriously - take a look at that suggested sequence I posted, and tell > me that it isn't *MORE* obvious than the horror that is nth_page(). > > Honestly, if anybody thinks nth_page() is obvious and good, I think > they have some bad case of Stockholm syndrome. > > This isn't about micro-optimizing. This is about not writing complete > garbage code that makes no sense. > > nth_page() is a disgusting thing that is designed to look up > known-contiguous pages. That code mis-used it for *testing* for being > contiguous. It may have _worked_, but it was the wrong thing to do. > > nth_page() in general should just not exist. I don't actually believe > there is any valid reason for it. I do not believe we should actually > have valid consecutive allocations of pages across sections. Oh, just to add to that, 1 GiB folios (hugetlb, dax) are the main reason why we use it in things like folio_page(), and also why folio_page_idx() is so horrible. -- Cheers, David / dhildenb