From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.55 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793205457; b=C+97Dyj0XeQuuvqbrwK0jPCF0dNVPIRn38O1Mi8Ira99dVb54pOmnRT5XF0tWyY31FUt v7Mr+BHMD6NCuDxc9D8maEYI5BJsJrUhDcf/gc8wJ0uCSRxmQfQ+e8pNQ9RLwJ2ZAc1cg GYEWAQxLonV84cfrIfKJVod2oQLhTJ/nLWTMhPOlWrv0RNujabECLQco1RjNiGc+RMMcg Q+OiJQxR5I78a+Yk/immar5ghFVrpbWsPU8CEXpHdjm/jgGRatn9ke6S5rpssqb8aLr/C 7OhgSNRsIHbMsEGRNv/uD7z/e6x8vRF6NTQtM1VBGbvMS7xo1NuRAxp+p+UmaNwqfpw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793205457; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-Id: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=nK3Nt8cGE3hJPWcMvC7YNISaGC69jVpDN/QOixd7gtc=; b=fR9tW0mbrdwrwwm3rilx7K3siyHhKVtH62QvnIoM7ZSBMZ9n/P+rJnioFvFO+d72bfD7 PAY0lkJxAnpPBkh03XB3LFMqWfnOIRHkKHa3uWXEmXDh/qK8AMMcDKUt+BEFrES50AyOL TH0n1XQGMKWTMsowyCcH1+vZVWr8GKgMt1MMWcOFuXiH787zQhd0tOxGNdnfd6QGCwBvq Ca50mfq/SWIVRoGJi9wkpR8b2D/9po0ldEstuASyue4fC+GtQJRqRaKWkY7FQOYpuWgV4 8rpiL4M2OngAvUFyobhYFJyf/eA4X/b82KTbD6wSENT8NT81x1+2oCf87/MORg5hQ7g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=GvX2RI4Z; arc=none smtp.remote-ip=95.215.58.55 Received: from mta1.migadu.com (out-55.mta1.migadu.com [95.215.58.55]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C75A60A2601 for ; Wed, 28 Oct 2026 16:37:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2C75A60A2601 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=GvX2RI4Z X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=0y0cpyImzffhtGDB41PPSGb7C8URf8GX0d2rmRQc21M=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793205454; v=1; x=1793810254; b=GvX2RI4ZUGGf8yQ4BPPQm5R3xrlMOXRdpblpLi7tH+znBDm6z0mCPPnCCP24FPcWFvJBmBWH E+W7ASYyzbxU3tRzzxFkFUsQOPdRZLwpRqU0r9ETIePweXOfbHhFtlyeUAHyCi4YOP34dywlUbo KSJDfFpgjXk1GjWq0MdUH970= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta11.migadu.com with ESMTPS id d9f5c6d6368c6816; Wed, 28 Oct 2026 16:37:34 +0000 X-Mizu-Trace-ID: d9f5c6d6368c6816 X-Migadu-Flow: FLOW_OUT From: wen.yang@linux.dev To: Joel Granados Cc: Wen Yang , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 21/39] sysctl: refresh device-dependent bounds per call Date: Thu, 29 Oct 2026 00:35:00 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wen Yang Refresh device-dependent limits before validating sysctl writes. Suggested-by: Joel Granados Signed-off-by: Wen Yang --- drivers/base/power/main.c | 21 +++++++++++++++------ drivers/gpu/drm/i915/i915_perf.c | 19 ++++++++++++++----- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index 88a31e09e4f3..8346875a4fa2 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c @@ -543,7 +543,6 @@ MODULE_PARM_DESC(dpm_watchdog_enabled, "Enable DPM watchdog"); static unsigned int __read_mostly dpm_watchdog_timeout = CONFIG_DPM_WATCHDOG_TIMEOUT; static unsigned int __read_mostly dpm_watchdog_warning_timeout = CONFIG_DPM_WATCHDOG_WARNING_TIMEOUT; -static const unsigned int dpm_watchdog_timeout_max = CONFIG_DPM_WATCHDOG_TIMEOUT; static int proc_dodpm_watchdog_timeout_secs(const struct ctl_table *table, int write, void *buffer, @@ -565,23 +564,33 @@ static int proc_dodpm_watchdog_timeout_secs(const struct ctl_table *table, return 0; } +static int proc_dodpm_watchdog_warning_timeout_secs(const struct ctl_table *table, + int write, void *buffer, size_t *lenp, + loff_t *ppos) +{ + struct ctl_table tmp = *table; + + tmp.max = READ_ONCE(dpm_watchdog_timeout); + return proc_douintvec_minmax(&tmp, write, buffer, lenp, ppos); +} + static const struct ctl_table dpm_watchdog_sysctls[] = { { .procname = "dpm_watchdog_timeout_secs", .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dodpm_watchdog_timeout_secs, - .extra1 = SYSCTL_ONE, - .extra2 = (void *)&dpm_watchdog_timeout_max, + .min = 1, + .max = CONFIG_DPM_WATCHDOG_TIMEOUT, }, { .procname = "dpm_watchdog_warning_timeout_secs", .data = &dpm_watchdog_warning_timeout, .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_douintvec_minmax, - .extra1 = SYSCTL_ONE, - .extra2 = (void *)&dpm_watchdog_timeout, + .proc_handler = proc_dodpm_watchdog_warning_timeout_secs, + .min = 1, + .max = UINT_MAX, }, }; diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 19b82427aa41..2e758f2008db 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -4795,6 +4795,15 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, return ret; } +static int oa_max_sample_rate_handler(const struct ctl_table *table, int write, + void *buffer, size_t *lenp, loff_t *ppos) +{ + struct ctl_table tmp = *table; + + tmp.max = (unsigned long)READ_ONCE(oa_sample_rate_hard_limit); + return proc_dointvec_minmax(&tmp, write, buffer, lenp, ppos); +} + static const struct ctl_table oa_table[] = { { .procname = "perf_stream_paranoid", @@ -4802,17 +4811,17 @@ static const struct ctl_table oa_table[] = { .maxlen = sizeof(i915_perf_stream_paranoid), .mode = 0644, .proc_handler = proc_dointvec_minmax, - .extra1 = SYSCTL_ZERO, - .extra2 = SYSCTL_ONE, + .min = 0, + .max = 1, }, { .procname = "oa_max_sample_rate", .data = &i915_oa_max_sample_rate, .maxlen = sizeof(i915_oa_max_sample_rate), .mode = 0644, - .proc_handler = proc_dointvec_minmax, - .extra1 = SYSCTL_ZERO, - .extra2 = &oa_sample_rate_hard_limit, + .proc_handler = oa_max_sample_rate_handler, + .min = 0, + .max = INT_MAX, }, }; -- 2.25.1