From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF4C62236F7 for ; Tue, 7 Apr 2026 02:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775529229; cv=none; b=og4eMuhIzcgmL14cLRUhYx/IC/TE19+miHGCbWEf+6EOGFRngSel4bcj06YjoL457JB9qPvyx3YuTBWWHpLQzk2q2M9tFdLGA9vMgUEjO959VOmUYP9D9e+J2/eg2bEagrjq6QRur58yrZSfMYVyWHM0+lq9ZTEh+jGLCBPt4QU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775529229; c=relaxed/simple; bh=oES0rGsVrHO4Qzz9FgagQdej1AO8/4pAXIKUeCAQ030=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hd7y8kMBRQctT1x3dD50ILOB2u5abnS136oSVCROlmyUBFvQcVAyUYTPdTXbixt8rDmp6MjelLF5HYwCMcXqe91p8rsoCBqhdm6DhNSAHf+dq8g/L6OFajUjjJZSwo9SnIik9qytQ+nsCLmC67URUjiCJVtwpf/Jn+SQ/X3LWsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iLcqfOVm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U0YqoW0C; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iLcqfOVm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U0YqoW0C" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LQLea3537351 for ; Tue, 7 Apr 2026 02:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 89gbJ4/Y+ioC9vThJOmb87Wer206nh06egfFrTvEDCY=; b=iLcqfOVmi8BwWlPX brlIBgMjYBJPxI4zh74O1bmM3TPrhSv2SIM2g0H0b2OnotGZ66R/sixcCnaDOZd2 KXx5PtUHMzFojsqr30jfOF4O73weUia4mZbD2AJj9svp5HzJ5qiwhsaG7qxVSrr3 cecxGPzWQzUt58nAtLObTo1CcwH6n0nQKfE1TorkvUJmu137ZnBOha4kT29tDTTx mcuiXL70AotzszhAFtimswpBKorTtDZ609EPfcXWQEzMCoNSW5X1NMNp8cG5djDP iY70VjgPabilOI8hise+odrZFXiLUbYAS1UkQREGBAivudtwtDh1Qnlgvy22I9e5 8g3yAg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmra0nxt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 02:33:47 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c76b6db8bb2so1974185a12.3 for ; Mon, 06 Apr 2026 19:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775529226; x=1776134026; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=89gbJ4/Y+ioC9vThJOmb87Wer206nh06egfFrTvEDCY=; b=U0YqoW0CQXpZrDJG1FA+JWYKPnysy0fX5K2O4VQBe0LDZ600bVXzGWl6ZO+p6+Oc4W 00u8tXsQUlf56Nre6hAiqt03y+wPJ1i/2luNbSloaj1LNbimsdrCXpWRuBv7KIqmedLD +te34LZHRVOIVg/N9ZaOA+HQRKT4tRc9kToScC2WxF1n8+vCW5TVkMG/bQ+9ggTcXssG h1gkafAxLE+hzc3VURIw9daF4gRZejL5VnReheEfkG6AKLeJ4tN9cGzC4guSPvr8x+M8 7KmjBJ7WU9TLd4A6zITPhaZeAoYVFBOTylvzyzxWYay0W5ncP4rsMYkXxIFXru97avdn mk/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775529226; x=1776134026; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=89gbJ4/Y+ioC9vThJOmb87Wer206nh06egfFrTvEDCY=; b=SQKssuHBO1mXXBBoWtfWVkdaT9f5MiVBt+gqKMzjza0hHnZCFmCS1vc/reo54EHfuP EjGSYv5Bv4ZuZSqypLbuh+RMyWkeZnboRXHe2vJfUZ8UIvqbJbef1lec+uRjFfWy+oiN 2IvZrGRra7B7kObVpjuk+xoJhwdJ9AODM1pRX9WG+cNh2HjjZsAfgcpqyKF5BnW0u1zX Dq7cL8jkE3CuqK8fsYRTp7pSeKKuakTrZLwpRVU1fq2rkoOS3bdcmpCs3FQEq6rd3IHs kK2FtZGa9iIgce+Aaw2ZH+w8bmrR23QcdqGsJXOupo6eow4Czj09vZK1iap9Ux2hB8qW MWoA== X-Forwarded-Encrypted: i=1; AJvYcCXhMkb+fqTVL5Z9R6bJiFv9wli6984QrJAexVzgSX4Oh847IwGUM5PewW4XPr1gBmKlmKy4qhaClej1iFY=@vger.kernel.org X-Gm-Message-State: AOJu0YwzPSPmdgn0ITcNtG4PMEwrda61q5rlnTpAj3SWgNDPlu8FnNsu jWV6d98vR89MBqD6cU7Tzx7cDXuPiMfsZy5gBVEjqV+pGroltfovjlyZIryuZ8BHNxXSzIJR7oC ipFdpBl9vaG7Idg2vJY6rQUxsZXvB7xqV0fmdrlA2ShpreSBKchjh6U0u4Dgu0T30hpA= X-Gm-Gg: AeBDietjS0TsBlNibdAVyUlvog0MQlFl3z86jcmMP+r6Z0ZzEsP29JlFGcFUBtdLtgN l7bEWKghljWahmsrsqHRpdnzpH7OKhsRhR2XyYRRSLCzK31A3k9e80qAv0+MDDNOAo3irbGoP0j JAzfWlstPhPwuBoKeU3sVzmwa4DurfXoL56JlFyGG2PqBVG+PxRj5owrAuHi8MKv7mAyMLPS/ea z2PyRRiVhkTSpM3v9pVmnHX2ITKivmkuRnbxaXSuf/cx6Yqnp8EgzR0uTI0IWV+rSa1ZyKppkVZ de+uz651Onz6DiGRSHWAxfKW3KARHjN3gAzOt2W42C4CgAYCS6hYW3B3pS89qfTlouy0nQ29gMJ HV8n3PgBy2UOX3K9KzyzSMW/zHpc07pi8U4AoH7do2ltmvkX3q9makxMXUpNH8WL5gQ61EdwYpq s75Lpp4V4fx3v2lUK0aw== X-Received: by 2002:a05:6a00:2d10:b0:829:9f46:280d with SMTP id d2e1a72fcca58-82d0da345b2mr13849262b3a.1.1775529226373; Mon, 06 Apr 2026 19:33:46 -0700 (PDT) X-Received: by 2002:a05:6a00:2d10:b0:829:9f46:280d with SMTP id d2e1a72fcca58-82d0da345b2mr13849234b3a.1.1775529225895; Mon, 06 Apr 2026 19:33:45 -0700 (PDT) Received: from [10.133.33.129] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b589b8sm15404155b3a.24.2026.04.06.19.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 19:33:45 -0700 (PDT) Message-ID: Date: Tue, 7 Apr 2026 10:33:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 35/38] drm/msm/dp: initialize dp_mst module for each DP MST controller To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-35-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: PaKp9YFRfd2vo3z93zxvjQTyFLH3ljeX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDAyMiBTYWx0ZWRfX1XG7P0kw5pfD MYp3bqkytFQnPtQ39kYV9Q3AXXpL6tfrj2RGUibsR/w15aC16VqXgxQHx0NmPhop9XZ25fFyo7f Kr2301cH3seEUQUyMWw7kw3y+hGgwgxYJqUSLGkP7l5AiQ3mgrXf9GDiWLahA+D4VWBGbVmzoll 3nQQoZLGj0z6Z7LU5OUMCTOi2VONsVW+1WvJ0kgTitxHkiO8lHXEgY0M4KFdZANWtlJf/eaBAt0 +8nQCg7ySfwjovUQqjBTlZxtMz5m2/RuPpDu75LaSAfVRaJKstDRYxzppkWbU64BmLa0O4ZJTEG HPrzawJ8Xg6jz4et/1ZTlWiUlE7xCwBwmMInKiZnAokNg4CcadNMp/xvUu0uzJNJZ0OjI8VcQ7Y J5BylFPpCUZ8OkudgchRJDeWOGmjAWzRqvZBaVWXvBANFH+LHoSSaB8kbwYeViSCylJu1Fr2nRf FnsDy5wZ4uTMYOI57ZQ== X-Authority-Analysis: v=2.4 cv=BKGDalQG c=1 sm=1 tr=0 ts=69d46d0b cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=fATO5yK3SkeBLP2YPJcA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: PaKp9YFRfd2vo3z93zxvjQTyFLH3ljeX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_01,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 bulkscore=0 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070022 On 8/27/2025 5:27 AM, Dmitry Baryshkov wrote: > On Mon, Aug 25, 2025 at 10:16:21PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> For each MST capable DP controller, initialize a dp_mst module to >> manage its DP MST operations. The DP MST module for each controller >> is the central entity to manage its topology related operations as >> well as interfacing with the rest of the DP driver. >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 ++++++ >> drivers/gpu/drm/msm/dp/dp_display.c | 9 +++++++++ >> drivers/gpu/drm/msm/msm_drv.h | 6 ++++++ >> 3 files changed, 21 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c >> index 0b9d9207f4f69e0d0725ff265c624828b5816a8b..4036d3445946930e635401109ac4720ed2282c2f 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c >> @@ -681,6 +681,12 @@ static int _dpu_kms_initialize_displayport(struct drm_device *dev, >> stream_cnt = msm_dp_get_mst_max_stream(priv->kms->dp[i]); >> >> if (stream_cnt > 1) { >> + rc = msm_dp_mst_register(priv->kms->dp[i]); >> + if (rc) { >> + DPU_ERROR("dp_mst_init failed for DP, rc = %d\n", rc); >> + return rc; >> + } >> + >> for (stream_id = 0; stream_id < stream_cnt; stream_id++) { >> info.stream_id = stream_id; >> encoder = dpu_encoder_init(dev, DRM_MODE_ENCODER_DPMST, &info); >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index 909c84a5c97f56138d0d62c5d856d2fd18d36b8c..897ef653b3cea08904bb3595e8ac10fd7fcf811f 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -1586,6 +1586,15 @@ int msm_dp_modeset_init(struct msm_dp *msm_dp_display, struct drm_device *dev, >> return 0; >> } >> >> +inline int msm_dp_mst_register(struct msm_dp *msm_dp_display) > > Why is it inline? Also please move this to a corresponding patch (the > one which adds msm_dp_mst_init). > Got it..will rework patch to make them look more reasonable. >> +{ >> + struct msm_dp_display_private *dp; >> + >> + dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); >> + >> + return msm_dp_mst_init(msm_dp_display, dp->max_stream, dp->aux); >> +} >> + >> void msm_dp_display_atomic_prepare(struct msm_dp *msm_dp_display) >> { >> int rc = 0; >> diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h >> index 3e64ec7b7dbe1d1107e85def9aa80277131f40bf..c46c88cf06598df996a17c23631570fda078b371 100644 >> --- a/drivers/gpu/drm/msm/msm_drv.h >> +++ b/drivers/gpu/drm/msm/msm_drv.h >> @@ -365,6 +365,7 @@ bool msm_dp_wide_bus_available(const struct msm_dp *dp_display); >> >> int msm_dp_get_mst_max_stream(struct msm_dp *dp_display); >> int msm_dp_mst_drm_bridge_init(struct msm_dp *dp_display, struct drm_encoder *encoder); >> +int msm_dp_mst_register(struct msm_dp *dp_display); >> >> #else >> static inline int __init msm_dp_register(void) >> @@ -392,6 +393,11 @@ static inline int msm_dp_mst_drm_bridge_init(struct msm_dp *dp_display, struct d >> return -EINVAL; >> } >> >> +static inline int msm_dp_mst_register(struct msm_dp *dp_display) >> +{ >> + return -EINVAL; >> +} >> + >> static inline void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp_display) >> { >> } >> >> -- >> 2.34.1 >> >