mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Daniel Parks <danielrparks@ti.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>
Cc: linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/6] dt-bindings: crypto: ti,sa2ul: add pka subdevice
Date: Tue, 9 Aug 2022 08:44:15 +0300	[thread overview]
Message-ID: <c97e7080-9d93-ae09-9bb2-106539f9b1ae@linaro.org> (raw)
In-Reply-To: <42d04e9ec43d10f978cee1dd974bbfdccf121d85.1659985696.git.danielrparks@ti.com>

On 08/08/2022 22:12, Daniel Parks wrote:
> The PKA (aka eip29t2) is a subdevice of the SA2UL on k3.
> 
> Signed-off-by: Daniel Parks <danielrparks@ti.com>
> ---
>  Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 02f47c2e7998..e4adb8192608 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -64,8 +64,14 @@ patternProperties:
>      type: object
>      description:
>        Child RNG node for SA2UL
>  
> +patternProperties:
> +  "^pka@[a-f0-9]+$":
> +    type: object
> +    description:
> +      Child PKA node for SA2UL

If PKA is from "Public Key Accelerator", could you include here full
name of the abbreviation?

Anyway you need here reference to schema for your node or describe the
contents.

Best regards,
Krzysztof

  reply	other threads:[~2022-08-09  5:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 19:12 [RFC PATCH 0/6] Add SA2UL Public Key Accelerator driver Daniel Parks
2022-08-08 19:12 ` [RFC PATCH 1/6] dt-bindings: crypto: ti,sa2ul: add pka subdevice Daniel Parks
2022-08-09  5:44   ` Krzysztof Kozlowski [this message]
2022-08-09 23:22   ` Rob Herring
2022-08-08 19:12 ` [RFC PATCH 2/6] dt-bindings: crypto: add binding for eip29t2 public key accelerator (PKA) Daniel Parks
2022-08-09  5:47   ` Krzysztof Kozlowski
2022-08-09 23:22   ` Rob Herring
2022-08-08 19:12 ` [RFC PATCH 3/6] arm64: dts: ti: k3-am64-main: add SA2UL public key accelerator subdevice Daniel Parks
2022-08-08 19:12 ` [RFC PATCH 4/6] arm64: dts: ti: k3-j721e-main: " Daniel Parks
2022-08-08 19:12 ` [RFC PATCH 5/6] crypto: sa2ul: turn on PKA engine Daniel Parks
2022-08-08 19:12 ` [RFC PATCH 6/6] crypto: sa2ul_pka: Add SA2UL PKA driver Daniel Parks
2022-08-08 21:52   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c97e7080-9d93-ae09-9bb2-106539f9b1ae@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=danielrparks@ti.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®