From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035DBC4346E for ; Tue, 29 Sep 2020 05:59:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE2E820BED for ; Tue, 29 Sep 2020 05:59:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="gqGVhGn+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727494AbgI2F74 (ORCPT ); Tue, 29 Sep 2020 01:59:56 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:51148 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbgI2F74 (ORCPT ); Tue, 29 Sep 2020 01:59:56 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08T5xoZD117847; Tue, 29 Sep 2020 00:59:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1601359190; bh=TrXUDYwBoolpojQ6Vfg8wnJtYyuv0RloSLQXWZhaFZ0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=gqGVhGn+kDNb1lIjakW9NjRvhoo4wDRrnfraR8al+W1Z/k11TgHKAqbFAPZMU7M+U Z8oGja6ui6vKhIiz2WMyENQK/X/cE15izZ/KTYefF70SOnKe8ktVDdrxv67ye39V8H heLIPyI57K4k+wwSPouA29JMJicOm2kw38vQtr0s= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08T5xohb101094 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 29 Sep 2020 00:59:50 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 29 Sep 2020 00:59:50 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 29 Sep 2020 00:59:49 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08T5xmPH048457; Tue, 29 Sep 2020 00:59:48 -0500 Subject: Re: sound/soc/ti/j721e-evm.c:528:34: warning: unused variable 'j721e_audio_of_match' To: Mark Brown , Nick Desaulniers CC: kernel test robot , , clang-built-linux , LKML References: <202009271553.4OjMpGkX%lkp@intel.com> <76cae106-b643-57a9-e82e-48e46ebf1b70@ti.com> <20200928180412.GA4827@sirena.org.uk> From: Peter Ujfalusi X-Pep-Version: 2.0 Message-ID: Date: Tue, 29 Sep 2020 09:00:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200928180412.GA4827@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/2020 21.04, Mark Brown wrote: > On Mon, Sep 28, 2020 at 10:52:54AM -0700, Nick Desaulniers wrote: >> On Mon, Sep 28, 2020 at 12:27 AM 'Peter Ujfalusi' via Clang Built >=20 >>> Right, in the attached .config: >>> # CONFIG_OF is not set >=20 >>> There must be a clean way to handle this without extensive ifedfery..= =2E >=20 >> Pretty sure I just saw a patch go by wrapping another device table >> definition in #ifdef CONFIG_OF, so it's not unusual. >=20 > It's the standard solution, it's just not as clean as would be ideal :/= The ifdef would be preferred if the driver could work in non DT boot (to save few bytes) but since it is not the case here: https://lore.kernel.org/alsa-devel/20200928074330.13029-1-peter.ujfalusi@= ti.com/ Not much point to size optimize for randconfig builds ;) - P=E9ter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki